PR https://github.com/tianocore/edk2/pull/2495 is created for this patch. 

 

Thanks

Liming

发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Rebecca Cran
发送时间: 2022年2月1日 7:33
收件人: Sami Mujawar <Sami.Mujawar@arm.com>; Christopher Jones <Christopher.Jones@arm.com>; devel@edk2.groups.io
抄送: ray.ni@intel.com; zhichao.gao@intel.com; nd <nd@arm.com>
主题: Re: [edk2-devel] [PATCH v1 1/1] ShellPkg: Fix incorrect PPTT FlagName dereference

 

It looks like this hasn't been committed yet - I still get a crash when running acpiview on my Overdrive 1000 system, and see the original code is still on the latest master.

Could someone commit it please?

 

-- 
Rebecca Cran

 

On 12/14/21 09:08, Sami Mujawar wrote:

Hi Chris,

 

Thanks for fixing this issue.

 

Reviewed-by: Sami Mujawar  <mailto:sami.mujawar@arm.com> <sami.mujawar@arm.com>

 

Regards,

 

Sami Mujawar

 

From: Chris Jones  <mailto:christopher.jones@arm.com> <christopher.jones@arm.com>
Date: Tuesday, 14 December 2021 at 12:38
To: devel@edk2.groups.io <mailto:devel@edk2.groups.io>   <mailto:devel@edk2.groups.io> <devel@edk2.groups.io>
Cc: ray.ni@intel.com <mailto:ray.ni@intel.com>   <mailto:ray.ni@intel.com> <ray.ni@intel.com>, zhichao.gao@intel.com <mailto:zhichao.gao@intel.com>   <mailto:zhichao.gao@intel.com> <zhichao.gao@intel.com>, rebecca@nuviainc.com <mailto:rebecca@nuviainc.com>   <mailto:rebecca@nuviainc.com> <rebecca@nuviainc.com>, Sami Mujawar  <mailto:Sami.Mujawar@arm.com> <Sami.Mujawar@arm.com>, nd  <mailto:nd@arm.com> <nd@arm.com>
Subject: [PATCH v1 1/1] ShellPkg: Fix incorrect PPTT FlagName dereference

Bugzilla: 3770 (https://bugzilla.tianocore.org/show_bug.cgi?id=3770)

The PPTT parser in AcpiView incorrectly dereferences a pointer to
FlagName when trying to log an error with the PPTT cache flags, which
can lead to random crashes and other errors.

Also fix some spacing in the error message to ensure the message is
printed cleanly.

Signed-off-by: Chris Jones  <mailto:christopher.jones@arm.com> <christopher.jones@arm.com>
---
 ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c
index 8d52bb5e4811298ddc45cdaef41150f6ee7819af..53777644580e779adab4e8047ea279e1c0de14a3 100644
--- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c
+++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c
@@ -40,9 +40,9 @@ LogCacheFlagError (
   IncrementErrorCount ();
   Print (
     L"\nERROR: On Arm based systems, all cache properties must be"
-    L"provided in the cache type structure."
-    L"Missing '%s' flag.",
-    *FlagName
+    L" provided in the cache type structure."
+    L" Missing '%s' flag.",
+    FlagName
     );
 }
 
-- 
Guid("CE165669-3EF3-493F-B85D-6190EE5B9759")





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#86400): https://edk2.groups.io/g/devel/message/86400
Mute This Topic: https://groups.io/mt/88962976/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-