From nobody Sat May 18 23:55:36 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+86400+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+86400+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1644198211; cv=none; d=zohomail.com; s=zohoarc; b=TzL6NbUPlDyOdBSyNqemauNZ0il7z5es8q1tQQkYYBokGfq6uIWACSu9lQrFi7CWvaW4jLLIGgmjZBP0tG4c3rw/WKNpNldqMwf8+cdHFUTi+tPTlClckwA9CFBdOqYygBfuw+RmipPdzoNd7qaRIQckzA2lQLyyOjO3K6aiXqw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1644198211; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=i1NnBX1CsPniLsQxNnADUtyPGkCp3M8a0Mr2X7vKFYY=; b=Bz9N03orSVahnOZ7fNRqPW5NQPKA59CWZbn7BjghVTFIPB109dwcBgXNiVw0b2q+NYMTDPulQ878wikIdxyo/8abW0H1keyMATpBOvxMORCZzMNFibJXJ1+v1bPCq5Qi3LUcpZ0qCGZqqhw13h1PJnt0HVputm26i77aNl5JoOc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+86400+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1644198211195385.79770564687317; Sun, 6 Feb 2022 17:43:31 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id Dp45YY1788612xHiSDGCdfKk; Sun, 06 Feb 2022 17:43:31 -0800 X-Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web09.16937.1644198208184706540 for ; Sun, 06 Feb 2022 17:43:29 -0800 X-Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Mon, 07 Feb 2022 09:43:20 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , , "'Sami Mujawar'" , "'Christopher Jones'" Cc: , , "'nd'" References: <20211214123736.10854-1-christopher.jones@arm.com> <3c7731ad-7036-fc92-3c2e-8748b760714f@nuviainc.com> In-Reply-To: <3c7731ad-7036-fc92-3c2e-8748b760714f@nuviainc.com> Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIHYxIDEvMV0gU2hlbGxQa2c6IEZpeCBpbmNvcnJlY3QgUFBUVCBGbGFnTmFtZSBkZXJlZmVyZW5jZQ==?= Date: Mon, 7 Feb 2022 09:43:22 +0800 Message-ID: <004801d81bc4$176785b0$46369110$@byosoft.com.cn> MIME-Version: 1.0 Thread-Index: AQD0EHuZomzRXoAuM2yRE5sYfBacBQGZy+cUAUBULw6uOJYlMA== Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,gaoliming@byosoft.com.cn X-Gm-Message-State: 68tQZselIzWvb5ztGIJifBBAx1787277AA= Content-Type: multipart/alternative; boundary="----=_NextPart_000_0049_01D81C07.258CE890" Content-Language: zh-cn DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1644198211; bh=13uM4pvbiDi6/SbfALQ3tAGPMeSBfeeoCj6nLWMSBf4=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=wOgUQxTQ/GFSG4DhsOJYr2lnLdm7fU90S7JxhrjObTfYXGz8/XUA/26CA8IbNvBjcAx Rya/Knx/eUVdOeSVVAeLN0pxbYVI7iW9B8JL6rDJ8OoEYTcDAxGxciQvsIuRgYQD5ucFw hjE9dFjnUpQJ+y1wA9ysq5zOUYCma4m9agg= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1644198218674100001 ------=_NextPart_000_0049_01D81C07.258CE890 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" PR https://github.com/tianocore/edk2/pull/2495 is created for this patch.=20 =20 Thanks Liming =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io = =E4=BB=A3=E8=A1=A8 Rebecca Cran =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2022=E5=B9=B42=E6=9C=881=E6=97=A5 7:33 =E6=94=B6=E4=BB=B6=E4=BA=BA: Sami Mujawar ; Christoph= er Jones ; devel@edk2.groups.io =E6=8A=84=E9=80=81: ray.ni@intel.com; zhichao.gao@intel.com; nd =E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH v1 1/1] ShellPkg: Fix incorrect= PPTT FlagName dereference =20 It looks like this hasn't been committed yet - I still get a crash when run= ning acpiview on my Overdrive 1000 system, and see the original code is sti= ll on the latest master. Could someone commit it please? =20 --=20 Rebecca Cran =20 On 12/14/21 09:08, Sami Mujawar wrote: Hi Chris, =20 Thanks for fixing this issue. =20 Reviewed-by: Sami Mujawar =20 Regards, =20 Sami Mujawar =20 From: Chris Jones Date: Tuesday, 14 December 2021 at 12:38 To: devel@edk2.groups.io Cc: ray.ni@intel.com = , zhichao.gao@intel.com = , rebecca@nuviainc.co= m , Sami Mujawar , nd Subject: [PATCH v1 1/1] ShellPkg: Fix incorrect PPTT FlagName dereference Bugzilla: 3770 (https://bugzilla.tianocore.org/show_bug.cgi?id=3D3770) The PPTT parser in AcpiView incorrectly dereferences a pointer to FlagName when trying to log an error with the PPTT cache flags, which can lead to random crashes and other errors. Also fix some spacing in the error message to ensure the message is printed cleanly. Signed-off-by: Chris Jones --- ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c | 6= +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/Pptt= Parser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttPa= rser.c index 8d52bb5e4811298ddc45cdaef41150f6ee7819af..53777644580e779adab4e8047ea= 279e1c0de14a3 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c @@ -40,9 +40,9 @@ LogCacheFlagError ( IncrementErrorCount (); Print ( L"\nERROR: On Arm based systems, all cache properties must be" - L"provided in the cache type structure." - L"Missing '%s' flag.", - *FlagName + L" provided in the cache type structure." + L" Missing '%s' flag.", + FlagName ); } =20 --=20 Guid("CE165669-3EF3-493F-B85D-6190EE5B9759") -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#86400): https://edk2.groups.io/g/devel/message/86400 Mute This Topic: https://groups.io/mt/88962976/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- ------=_NextPart_000_0049_01D81C07.258CE890 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

PR https://github.com/tianocore/edk2/pull/2495 is created for this patch.=

 

<= p class=3DMsoNormal>Thanks

Li= ming

=E5=8F=91=E4=BB=B6=E4= =BA=BA: devel@edk2.groups.io <dev= el@edk2.groups.io> =E4=BB=A3=E8=A1=A8 Rebecca Cran
=E5=8F= =91=E9=80=81=E6=97=B6=E9=97=B4: 2022= =E5= =B9=B42=E6=9C=881=E6=97= =A5 7:33
=E6=94=B6=E4=BB=B6=E4=BA=BA: Sami Mujawar <Sami.Mujawar@a= rm.com>; Christopher Jones <Christopher.Jones@arm.com>; devel@edk2= .groups.io
=E6=8A=84=E9=80=81: ray.ni@intel.com; zhichao.gao@intel.com; nd <nd@arm.co= m>
=E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH v1 1/1] ShellPkg: Fix incorrect PPTT F= lagName dereference

 

It looks like this hasn't been committe= d yet - I still get a crash when running acpiview on my Overdrive 1000 syst= em, and see the original code is still on the latest master.

Could someone commit it please?

 

--
Rebecca Cran

&nb= sp;

On 12/14/2= 1 09:08, Sami Mujawar wrote:

Hi Chris,

 

Thanks for f= ixing this issue.

 

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

 

Regards,

 <= /p>

Sami Mujawar

 

From: Chris Jones <christopher.jones@arm.com>
= Date: Tuesday, 14 December 2021 at 12:38
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: ray.ni@intel.com <ray.ni@intel.com>, zhichao.gao@intel.com <z= hichao.gao@intel.com>, rebec= ca@nuviainc.com <rebecca@nuv= iainc.com>, Sami Mujawar <= ;Sami.Mujawar@arm.com>, nd <nd@arm.= com>
Subject: [PATCH v1 1/1] ShellPkg: Fix incorrect PPTT = FlagName dereference

<= div>

Bugzilla: 3770 (https://bugzilla.tianocore.org/show_bug.c= gi?id=3D3770)

The PPTT parser in AcpiView incorrectly dereferenc= es a pointer to
FlagName when trying to log an error with the PPTT cache= flags, which
can lead to random crashes and other errors.

Also f= ix some spacing in the error message to ensure the message is
printed cl= eanly.

Signed-off-by: Chris Jones <christopher.jones@arm.com>
---
 ShellPkg/L= ibrary/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c | 6 +++---
=  1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/S= hellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c b/She= llPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c
inde= x 8d52bb5e4811298ddc45cdaef41150f6ee7819af..53777644580e779adab4e8047ea279e= 1c0de14a3 100644
--- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Pars= ers/Pptt/PpttParser.c
+++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib= /Parsers/Pptt/PpttParser.c
@@ -40,9 +40,9 @@ LogCacheFlagError (
&nbs= p;  IncrementErrorCount ();
   Print (
  &nb= sp;  L"\nERROR: On Arm based systems, all cache properties must b= e"
-    L"provided in the cache type structure.= "
-    L"Missing '%s' flag.",
- &n= bsp;  *FlagName
+    L" provided in the cache t= ype structure."
+    L" Missing '%s' flag."= ;,
+    FlagName
     );
 = }
 
--
Guid("CE165669-3EF3-493F-B85D-6190EE5B9759"= )

_._,_._,_
G= roups.io Links:

You receive all messages sent to this group.

Vi= ew/Reply Online (#86400) | | Mute This Topic | New Topic
Your Subscription | Contact Group Owner | Unsubscribe [importer@patchew.org]
_._,_._,_=20 ------=_NextPart_000_0049_01D81C07.258CE890--