From nobody Mon Jun 8 08:43:54 2026 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 094883EAC89 for ; Wed, 3 Jun 2026 16:25:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780503931; cv=none; b=V1MASE+CzFdxCP+HWPNY38qzF37jNCsDJ7tXq8wwQmGaWxlxfKlSdg+tQhN7TQnEt+F48S9iG+6RpfXRF/YX3NrPC++SEuXiVYYrh5B1O1T/iZZi/a7U225H1/B9T1CoocjwKUXT2DKJTRGZEMCqxmpv/wDk5juZ25joJAgkEco= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780503931; c=relaxed/simple; bh=YujDDyuGrciDS0gWHtUWpXqnP5DMsYmaDFfvtq1vBWk=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=qlgC/6UXPHD0tDmzYi0TsAiSdZhaI4UkcOijCEFbAGh//otW+KFYN4SL+6xJlJ+9SINLpjzdYLpC9r7Ia124oOmPtBK8VQQktevwSyF1Z3xqySNsLUgOc/GU66toe9Wt2bZbSOU+12P5ZpB3IH1X/s7AXll9zWoxaw02EP+zMV4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZQRSbvA0; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZQRSbvA0" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-2bf22d29dabso44332215ad.2 for ; Wed, 03 Jun 2026 09:25:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780503929; x=1781108729; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=HXTwm/dv/FFCf2h8WWpinsWjPQ3nXBBRBwX5/F3AfLc=; b=ZQRSbvA0irX+i1RSe+gIq2CkH91x/7kjGi8N36CMO7IqTqa7jCTal2bdHSoNblYpJz pKTQ+Q4EoeC1HiulZ3rZ5mD6Z70yworUSJ7yg/idmqg7Ctk66UU8FyjS1IE74oNnLL9D hBjWCvb4KCvaVlVqNmq8571ZazvfSeTT88XbLdJAOx8+Ry2XBcCo3efW+4gbpbzKLOSx 4XZJEkagsXwy31pqeZ1o0EWAdvsWbbrx372ce3AlLFn8jDJmE99eu8KJ229We7eTM41Y 4zRUvWg/U5DWE8sN7cNdWzvsTj7xppva6ts+qTmIMTKkZna2pZMKkDy1tFkYsnxNOwEp cFUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780503929; x=1781108729; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HXTwm/dv/FFCf2h8WWpinsWjPQ3nXBBRBwX5/F3AfLc=; b=mSVGKCvxsjss278Ply2BcTOz6B4vK8Va6trbe6RWJvGjRWhtUKcZPJgyPDGsQB8iLu ZW8uOc/395Emc5dQIdTCRzYDF0vNZ6cov8ylIFuaPysJMedcv5aRh7TPftnbAVnDadId J1GeLA4K5D/YIQhMHkQw3bk7ifj5YZfg+RuF8Op6mpQIkrGQsEbHvk/sx4gjd+lDLDHa vdacrk6cUjW3LYJIArTrwrZjioVKyHcfAOgvOh1sx34xtWAWr3q1PmcsH8NphJDwY9i3 QVkApWeYRe0+D1crflI3zcgVRiL0DTnp7PnZuqpBaNe6aRhMTJh44ptZX/lw0vl47X05 v5lg== X-Forwarded-Encrypted: i=1; AFNElJ97Mzja5mn5f7DW/todEcnOQh2Wb5Zw/tyetVyr1qMqAOMC2YFz2T1HZhqjfliSxUVVDSz8SCGdwPjcWr8=@vger.kernel.org X-Gm-Message-State: AOJu0YwvYdA32f2QTJ1nkjwfIKZc3Xu38rtTb8jLOKtMSi9oOwGQXUSk 3xM5SBilW1Tlov9L+qXchLT1n4ec1iWiAB4TYo5BEKTIdOpa9tUmmD4sHyyyiA== X-Gm-Gg: Acq92OGWs60IG8DUZzFVFAaL1rpuJYr0Vh5QvA+A/hVBMXngLQ68WeXV/NmU/k2It3l BVSs4RpGT0YWd5cJcZalzKzgYfQ7cTj8XMCdaQA7ugLpgNNXwGypR9n8e3ZRuTcNQOjEOI8qQw0 LtDZe2wBDAx6XpYdk3CcZfsMUHfg/YRoCfxL6ITuLeyVP/md+aP5MKzHfnYPrHk2KFzDN6rdHTU 18N9t4GDAFWiDwvJfk4ORKeE5PLIu/VkQWxTQhkKJMumJf/0LtU1o1qljLYJvE//gumkSNznNdj WL/NnW8FpKp02XZOU/KFFjutRvsi0ngZYJ4eNBrFLbw8kJ99ZLzaYm1Ekw7r4WnZ8hAIJHMxF4k 2/Ka5/HaHN0ayBUgGPJMUvcBG5YwxzBMkZ2WpkyQmDKpc+UiD0VqPgoXawJDJdxdgYM+gPG0rx6 OPPEy9pgvZQx1e5HN4WJh24WEQ8ZM+GeK3GUMNQmdkWbKVDw== X-Received: by 2002:a17:902:d58c:b0:2c0:ccdb:e02c with SMTP id d9443c01a7336-2c163a1d814mr48649235ad.7.1780503929003; Wed, 03 Jun 2026 09:25:29 -0700 (PDT) Received: from localhost ([2405:201:4027:a919:e2b2:8560:26ea:4d1]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c1664ae328sm29323695ad.84.2026.06.03.09.25.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jun 2026 09:25:28 -0700 (PDT) Date: Wed, 3 Jun 2026 21:55:26 +0530 From: Naveen Kumar Chaudhary To: mcgrof@kernel.org, petr.pavlu@suse.com, da.gomez@kernel.org, samitolvanen@google.com Cc: atomlin@atomlin.com, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] module: dups: use strscpy() to copy module name in dup request Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" kmod_dup_request_exists_wait() uses memcpy() with strlen(module_name) to copy into new_kmod_req->name, a fixed-size char[MODULE_NAME_LEN] buffer. This does not bounds-check the copy and does not explicitly NUL-terminate. The buffer is zeroed from kzalloc_obj() so NUL-termination happens to work, but the pattern is fragile and lacks an explicit bounds check. Replace with strscpy() which bounds the copy and guarantees NUL-termination. Signed-off-by: Naveen Kumar Chaudhary --- kernel/module/dups.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/module/dups.c b/kernel/module/dups.c index 1d720a5311ba..33bddfb57317 100644 --- a/kernel/module/dups.c +++ b/kernel/module/dups.c @@ -129,7 +129,7 @@ bool kmod_dup_request_exists_wait(char *module_name, bo= ol wait, int *dup_ret) if (!new_kmod_req) return false; =20 - memcpy(new_kmod_req->name, module_name, strlen(module_name)); + strscpy(new_kmod_req->name, module_name, MODULE_NAME_LEN); INIT_WORK(&new_kmod_req->complete_work, kmod_dup_request_complete); INIT_DELAYED_WORK(&new_kmod_req->delete_work, kmod_dup_request_delete); init_completion(&new_kmod_req->first_req_done); --=20 2.43.0