From nobody Fri Dec 19 13:30:39 2025 Received: from tarta.nabijaczleweli.xyz (tarta.nabijaczleweli.xyz [139.28.40.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F85A2D9ED1 for ; Mon, 8 Dec 2025 21:50:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=139.28.40.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765230630; cv=none; b=GpiK7SqbHcpsD2BiMfqhBIlxnvm/3XsG+DgiThQiA22CpJA3sj8SrPapmL1iu+iy2feHHkK21/Zg0/ZrUGipPvy0NM13TMeSJqd+lJEBO7g+DWuTFOP8qQCqSHI6fCoy8AL8m9JF0Upl7DhNLTn1ksi6PpJT7xWKkdeiOwpTjpQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765230630; c=relaxed/simple; bh=0PKTKFXGxd2aclzI0UHRl6n4Lefqy7Wq32pHokcYqTI=; h=Date:From:To:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=moRkCyIVTDj6GKnyfFdlIuZmTCAW7FyseTZEEOFvE2tc6DbNxEngoPKuAdeB5HxBSSlV49cZBP9X0Cdto+yBkAsNM4jcNJHAe7wFoPlC3JUVb6f8eV+zS8D6uixrb344E/NwL3vbr3WwI672/0JTx+ruRnuQMfcMta30P22nC8c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nabijaczleweli.xyz; spf=pass smtp.mailfrom=nabijaczleweli.xyz; dkim=pass (2048-bit key) header.d=nabijaczleweli.xyz header.i=@nabijaczleweli.xyz header.b=V67/bGoV; arc=none smtp.client-ip=139.28.40.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nabijaczleweli.xyz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nabijaczleweli.xyz Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nabijaczleweli.xyz header.i=@nabijaczleweli.xyz header.b="V67/bGoV" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nabijaczleweli.xyz; s=202505; t=1765230615; bh=0PKTKFXGxd2aclzI0UHRl6n4Lefqy7Wq32pHokcYqTI=; h=Date:From:To:Subject:From; b=V67/bGoV09QofbjWU4KsbuLK8Sx4FsQn9jUzwP+hKMTBBDW32BzV5SP0q5DRvQQvZ WDkU7dC+1G7lXXx8FR1iluvXmVI5h0E/T4kY4TCuRBFYn437KsczLnzPsbkXto2Ml3 JG/BH9cgZtfy7AEecgAi1u8RCvvK4UKgvW0biU5leRRrTKUTWaX/P+r4PWnKzK2DyL lr0p30t0aTot37tKd/gsxZIhQQxVNZA43VWW3cdieM6bek6BxabNI09GbwwU6uoJHY C3h0ZPPcj7DN/jvOq7n4d0xwPRqMeu/CSswflCGyuQHiQhtisET4lWyg+7pr2/euTL aEi97hEEgvd1Q== Received: from tarta.nabijaczleweli.xyz (unknown [192.168.1.250]) by tarta.nabijaczleweli.xyz (Postfix) with ESMTPSA id C4621F3BE; Mon, 8 Dec 2025 22:50:15 +0100 (CET) Date: Mon, 8 Dec 2025 22:50:15 +0100 From: Ahelenia =?utf-8?Q?Ziemia=C5=84ska?= To: Hugh Dickins , Baolin Wang , Andrew Morton , Matthew Wilcox , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] tmpfs: enforce the immutable flag on open files Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="27dnkjatirtu5y4b" Content-Disposition: inline User-Agent: NeoMutt/20231221-2-4202cf-dirty --27dnkjatirtu5y4b Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" This useful behaviour is implemented for most filesystems, and wants to be implemented for every filesystem, quoth ref: There is general agreement that we should standardize all file systems to prevent modifications even for files that were opened at the time the immutable flag is set. Eventually, a change to enforce this at the VFS layer should be landing in mainline. References: commit 02b016ca7f99 ("ext4: enforce the immutable flag on open files") Signed-off-by: Ahelenia Ziemia=C5=84ska --- v1: https://lore.kernel.org/linux-fsdevel/znhu3eyffewvvhleewehuvod2wrf4tz6v= xrouoakiarjtxt5uy@tarta.nabijaczleweli.xyz/t/#u shmem_page_mkwrite()'s return 0; falls straight into do_page_mkwrite()'s if (unlikely(!(ret & VM_FAULT_LOCKED))) { folio_lock(folio); Given the unlikely, is it better to folio_lock(folio); return VM_FAULT_LOCK= ED; instead? /ext4# uname -a Linux tarta 6.18.0-10912-g416f99c3b16f-dirty #1 SMP PREEMPT_DYNAMIC Sat Dec= 6 12:14:41 CET 2025 x86_64 GNU/Linux /ext4# while sleep 1; do echo $$; done > file & [1] 262 /ext4# chattr +i file /ext4# sh: line 25: echo: write error: Operation not permitted sh: line 25: echo: write error: Operation not permitted sh: line 25: echo: write error: Operation not permitted sh: line 25: echo: write error: Operation not permitted fg while sleep 1; do echo $$; done > file ^C /ext4# mount -t tmpfs tmpfs /tmp /ext4# cd /tmp /tmp# while sleep 1; do echo $$; done > file & [1] 284 /tmp# chattr +i file /tmp# sh: line 35: echo: write error: Operation not permitted sh: line 35: echo: write error: Operation not permitted sh: line 35: echo: write error: Operation not permitted $ cat test.c #include #include #include #include #include int main(int, char **argv) { int fd =3D open(argv[1], O_RDWR | O_CREAT | O_TRUNC, 0666); ftruncate(fd, 1024 * 1024); char *addr =3D mmap(NULL, 1024 * 1024, PROT_READ | PROT_WRITE, MAP_SHARED,= fd, 0); addr[0] =3D 0x69; int attrs =3D FS_IMMUTABLE_FL; ioctl(3, FS_IOC_SETFLAGS, &attrs); addr[1024 * 1024 - 1] =3D 0x69; } # strace ./test /tmp/file execve("./test", ["./test", "/tmp/file"], 0x7ffc720bead8 /* 22 vars */) =3D= 0 ... openat(AT_FDCWD, "/tmp/file", O_RDWR|O_CREAT|O_TRUNC, 0666) =3D 3 ftruncate(3, 1048576) =3D 0 mmap(NULL, 1048576, PROT_READ|PROT_WRITE, MAP_SHARED, 3, 0) =3D 0x7f09bbf2a= 000 ioctl(3, FS_IOC_SETFLAGS, [FS_IMMUTABLE_FL]) =3D 0 --- SIGBUS {si_signo=3DSIGBUS, si_code=3DBUS_ADRERR, si_addr=3D0x7f09bc029f= ff} --- +++ killed by SIGBUS +++ Bus error # tr -d \\0 < /tmp/file; echo i mm/shmem.c | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/mm/shmem.c b/mm/shmem.c index d578d8e765d7..432935f79f35 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -1294,6 +1294,14 @@ static int shmem_setattr(struct mnt_idmap *idmap, bool update_mtime =3D false; bool update_ctime =3D true; =20 + if (unlikely(IS_IMMUTABLE(inode))) + return -EPERM; + + if (unlikely(IS_APPEND(inode) && + (attr->ia_valid & (ATTR_MODE | ATTR_UID | + ATTR_GID | ATTR_TIMES_SET)))) + return -EPERM; + error =3D setattr_prepare(idmap, dentry, attr); if (error) return error; @@ -2763,6 +2771,17 @@ static vm_fault_t shmem_fault(struct vm_fault *vmf) return ret; } =20 +static vm_fault_t shmem_page_mkwrite(struct vm_fault *vmf) +{ + struct file *file =3D vmf->vma->vm_file; + + if (unlikely(IS_IMMUTABLE(file_inode(file)))) + return VM_FAULT_SIGBUS; + + file_update_time(file); + return 0; +} + unsigned long shmem_get_unmapped_area(struct file *file, unsigned long uaddr, unsigned long len, unsigned long pgoff, unsigned long flags) @@ -3475,6 +3494,10 @@ static ssize_t shmem_file_write_iter(struct kiocb *i= ocb, struct iov_iter *from) ret =3D generic_write_checks(iocb, from); if (ret <=3D 0) goto unlock; + if (unlikely(IS_IMMUTABLE(inode))) { + ret =3D -EPERM; + goto unlock; + } ret =3D file_remove_privs(file); if (ret) goto unlock; @@ -5286,6 +5309,7 @@ static const struct super_operations shmem_ops =3D { static const struct vm_operations_struct shmem_vm_ops =3D { .fault =3D shmem_fault, .map_pages =3D filemap_map_pages, + .page_mkwrite =3D shmem_page_mkwrite, #ifdef CONFIG_NUMA .set_policy =3D shmem_set_policy, .get_policy =3D shmem_get_policy, @@ -5295,6 +5319,7 @@ static const struct vm_operations_struct shmem_vm_ops= =3D { static const struct vm_operations_struct shmem_anon_vm_ops =3D { .fault =3D shmem_fault, .map_pages =3D filemap_map_pages, + .page_mkwrite =3D shmem_page_mkwrite, #ifdef CONFIG_NUMA .set_policy =3D shmem_set_policy, .get_policy =3D shmem_get_policy, --=20 2.39.5 --27dnkjatirtu5y4b Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEfWlHToQCjFzAxEFjvP0LAY0mWPEFAmk3SBIACgkQvP0LAY0m WPFVnhAAmdkHtpNU4LAEDVg6qRIA6QyAykW1zd+zM6yKhMtP7gmbFJd9fcy8TyGl Ym7JXRoma+VxA8xfl8pnbMOiRaR2gEo+iAd418PHg09BvY13PRtt2/nWQ6vzTlKM M4qSVZZC6tIKEEuPmEti98M/Zn12iHorTGSQ2OgNVLhvs7DDnkUn4VkLW45Z+DEb e73zuGnFA5stBNUcKeOw2aqAKo/1d2PYu4rGFQb1FMFBMvvVHbI4YRpSSnUJfPkH iohvghgxPe896hoImjFhJUWX53td7U+smRFWVJQhxky85zap95NyPlCjf6Xd3wOX i+XqvQFnbybc8FQNxs5j6cikVrXDNvPuZ4IfqadnpowmuDtMkZ0s2ZSFGN916k+6 TqyXUnIkzA/ORdHs2Y2cpN0Gg+EHP8jD6OPkv41oRptJujkyRC0zFYOio6AV+QNs QgGPCwzk4NlmEi23a0OzYD4NApOVo3eCEnFQaooqz0xbb5FuMga7P2oBPPqnJ2+r 09TAninZR0PuNtyuyi+LXhF7A3nBotUNfSL/8D8nssvLTHzMd+a1mRMARo/IE/JH uIAa2S30dmYsrVBrJMmfn0mG2utJL3NC5GXFpsjiQeDzCq1Jb0oh3LUNvS1lxHXn IOabN4FYeHB6R5f4//gB0Ldx5wFCdoupMn0mPSQJjewfWend1/k= =rA2t -----END PGP SIGNATURE----- --27dnkjatirtu5y4b--