From nobody Tue Jun 23 13:18:36 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06644C433F5 for ; Fri, 4 Mar 2022 08:18:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232660AbiCDITM (ORCPT ); Fri, 4 Mar 2022 03:19:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34252 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232172AbiCDITI (ORCPT ); Fri, 4 Mar 2022 03:19:08 -0500 Received: from out203-205-221-233.mail.qq.com (out203-205-221-233.mail.qq.com [203.205.221.233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 75BE7195330 for ; Fri, 4 Mar 2022 00:18:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1646381894; bh=SflRFPXtxQ3Pmt1KAgrpB/jeO17kuUf3fZk7Z71M+LI=; h=From:To:Cc:Subject:Date; b=qwU/2L9mtNdKJ13RVM39hLHms151Z7e1Kjn6aO+GrTYThWor+GF/GKFtPOzo2qLXj LM3GO2/iLkAvUyTn4D3ol3tNnQDD4pYQrkr/mkDa0K7DMtPQeRVGRNyGs9nLbuZ85T fswcLNpCpr1y54V/04LA5LsF/S5vWFoqHTB2lIoM= Received: from localhost.localdomain ([218.197.153.188]) by newxmesmtplogicsvrszc7.qq.com (NewEsmtp) with SMTP id 48A25A60; Fri, 04 Mar 2022 16:18:10 +0800 X-QQ-mid: xmsmtpt1646381890trs7be3wl Message-ID: X-QQ-XMAILINFO: NrI1OKqG5KOqYtBiK5U/ckeV9MUoGKaby4GqN3lWsSuBEkaa0eRPazt2b3O2H/ fBQlRwzB/Ri3MxZ4C9pKVwp9ZBD/UcsVUzSUK6p8EpjzKyAdSoF+psk88JHAObIGXBbpSK6MKGby ODFbZ8iDJojgkgsBIoEZJRuVwQUhOnrYxDiNwM2k+ueC1dVfrWmE88AlWX4nx9QeyidIWLF73oNj lJaiF+YUW2Ub/gyui03lnAOZEBiRwgCEycAg/72QHzNZzE1S2TtAKzlH5JmlCekNMmp79cpoyP2F clYyw0NLPVy5Z/kNEv+iqapayhBK3rOGF5W3YF7O+5ZocBsoAbIoil8CmDGMSCcOJVBKS/yaITds dP/qi34GsBSGNxNqpeZ1uTFW/9bbiLatbtl57mEJoHUFdfIV0+n8A4NWqvPCrhlE1o+5Ywkorh9j Pn7YpVhc9FNvVJMdEzovVcZ75gFFpZIuA5F1o9vgIYpQFWca+MGoBkUi9ylzeBKdtmInTAlIoLju 1U6KxNCvYn11k6RjT6WHnMHMURiVWAPK8KxdyMwmxIlXgjw1OvCHyGTv5npfRLgZhFuNZ7qktayy ezHfA4Cs4nUbXNdvVdyJ7qPgHZU0yFzwIsamTrorcZPoegHQSdEDCsW9dVnnLQpFz94xTEIfqqEE Ewory+ATlrBW/MwuCdrpmEuQF/sz/Ivv/q+Bps3JETM7lntV53UkmDeKEIxz6Aq06SbJ1rVZD4cH tPzW9hDVhJZT8A4wvGgSr5sxjdut7EqfVJHDyy+B8E7M89kmPSo7JC6+ylAORmrhDEL60GDdFTUI E3ZMJasXtkZtkTg3IpPMnLfiTu/Rs3oCYPLwYbjOzmglpp/AYy+yYf/zFo4nKwrnVXObol3h6OH4 I5B3bS03HjK8c4Zdrxtk+IdaX57iDtCdABG2nI0p0OmBeY0Imvh6zG5tHEWT1/Dg== From: xkernel.wang@foxmail.com To: nsaenz@kernel.org, gregkh@linuxfoundation.org Cc: bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Xiaoke Wang Subject: [PATCH] staging: mmal-vchiq: add a check for the return of vmalloc() Date: Fri, 4 Mar 2022 16:17:41 +0800 X-OQ-MSGID: <20220304081741.4728-1-xkernel.wang@foxmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Xiaoke Wang vmalloc() is a memory allocation API which can return NULL when some internal memory errors happen. So it is better to check the return value of it to catch the error in time. Signed-off-by: Xiaoke Wang --- drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c b/driver= s/staging/vc04_services/vchiq-mmal/mmal-vchiq.c index 76d3f03..1bbd301 100644 --- a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c +++ b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c @@ -1909,6 +1909,11 @@ int vchiq_mmal_init(struct vchiq_mmal_instance **out= _instance) mutex_init(&instance->vchiq_mutex); =20 instance->bulk_scratch =3D vmalloc(PAGE_SIZE); + if (!instance->bulk_scratch) { + err =3D -ENOMEM; + kfree(instance); + goto err_shutdown_vchiq; + } instance->vchiq_instance =3D vchiq_instance; =20 mutex_init(&instance->context_map_lock); --