From nobody Mon Sep 28 19:23:41 2026 Received: from out203-205-221-192.mail.qq.com (out203-205-221-192.mail.qq.com [203.205.221.192]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1601646D540 for ; Tue, 18 Aug 2026 13:24:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.205.221.192 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787059459; cv=none; b=iCj0OVLopldVegdzsVkgag5q1jgKuiMLS0bXJjXYtiBLtMiRQ/QMcPPrNDJF9bg1xsI33B30Jx50/YO0d9e1soa1o6W538pH3t7PDsImy0sOb10MJSfvIMoj5VJbu0zH8oWRuVtvh1oD2IKz34fhw+N4XLkJXyTMoKSRlSxuUZ8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787059459; c=relaxed/simple; bh=B3Fpuuna6JNUL3U/stNnQ1YEAGjL6pfh2Cz99TWRUhU=; h=Message-ID:From:Subject:To:Date; b=t8y2y8sv9y6Qgl7GgzGZc6dgcp404GauCjTds+03gCV9joeG8jDzjDDvkT0re0FnBLlnTIx3VdqAoK5/M96mLtDySpBZRUPLoc3z87em3TymzYuz9MgbwJmyiKQx4tF3HXCk9AUktWyvuY25rgmwcpk+1m+oGTv927oY7YcEV+M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=qq.com; spf=pass smtp.mailfrom=qq.com; dkim=pass (1024-bit key) header.d=qq.com header.i=@qq.com header.b=HsWQyjiC; arc=none smtp.client-ip=203.205.221.192 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=qq.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=qq.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=qq.com header.i=@qq.com header.b="HsWQyjiC" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512; t=1787059454; bh=fjtyryIYmmBpuRdf3jOKdD9JLI/NGQs9gcidVZKkY4Q=; h=From:Subject:To:Date; b=HsWQyjiC5NEdYQp0Fy2i3yj0XXBOnCJaOR58FV4LZ5v2v7su+Hh9QUeg2qTK9Uww6 GhqVThD7giUCf8JHWvbW5coldsV4iFk8+3gcHWGMcQw7imH3cs/4flWWkLuPLaZHHF IOWvBS+Rur+3N/m2w7MRo3uLOhZmSrHdat4VCsxk= Received: from [127.0.1.1] ([5.195.0.150]) by newxmesmtplogicsvrsza63-0.qq.com (NewEsmtp) with SMTP id 1721C6D8; Tue, 18 Aug 2026 21:05:50 +0800 X-QQ-mid: xmsmtpt1787059362tdf415oc5 Message-ID: X-QQ-XMAILINFO: MDbayGdXPuoenuvFrsb4R9ybDGvmupbXOnUzUThfySO2oTEKwR0b9ZJEBJDZBS UxYmoQD6eu8IV7/Oo28c6OQkJsXG462njTtfZp8i80oucCWsvSESAoq3OxUXI7ji5yl931XM9hVu 5LLW+JZPOYyIRGQmmsK7E5ExnbV3N3a3uxxej0vRHO7KIw9dbr7RpUeYJK6Sa3XJlKbdsG4kpAiS pnnmqLOO4tvdTuS/r3223svzjvcLkzzSP3ZFI1H34JJiaUYsYnqYhdlDeQefMmaQdDFop1jNNmE0 pfkTQ53116Ds3v0uQDSa7MSJH052y8CZ8MLTtYUSHK6jwdJI9Or1whscFHW09xJJmQtsiyurEHeJ LDyPweuHjaKtFCVtxeEUttgfo4IdhvcXv4N+yp+sFY2vjqjmyFqwEXJhzbY+GSNajxccE36t+PKS CfDw0FcGVhlRM4vc586hpwi4nX8c/Stkw2gHv1b8C6JPujYeR4wCW0ZqgEWKsfH1QD25PCmYAQou /EtUvirJOCm6rp54XTYhcLlFNcdqcrFcSLVTRFBnSvHByQn03g1puIhQDII0nBbIwkmP1TlUh77z K68HTM3G6wd0ypFc7plHw3R6uHthoLazlM92oU7qAUgn0YEELX+DDZwDIU2sNZpzTsjaVVEN9X9D BcLzqMvepCiPuAn/H9T2j/NYilVLLkLkecuh7J29dNb+EuEdW4WmQVlsxE+Eyjc/O5NNK41uIZgO zeUXz/GqBDm3DoDyDN0odR/JJnmoMhT2oWzfEdNH1pPDY60ytbl1PxRwutEcx/eKTIwqcWh8iVCA bo5WXdTi6YYf7L5J1Z2Fq9MwmeRHHvoLoOCwDakJvGjaGTBNcmHSL+mz7YiGaS8srOtQXkOq1IaZ unsdnfCoZ9k4YRl1eXs7XindukaqTM5/ZpeO9zk8EVovsgUF5ESpHQGzuLLt+IhwkfWnknQ+lP47 e+xV051UenDpRbFKmsBiU6uPGMgHr9MJzssZY4M1AfL/nBsambPQfpGcKlJJYXmKYyweq+3coipQ sIH1OMHTnX1Y2PpQz2cJJPK7E9Mt/m99Bg/LnuY32Ntwzdh/5dVVVoF933qac= X-QQ-XMRINFO: OWPUhxQsoeAVwkVaQIEGSKwwgKCxK/fD5g== From: Jiawen Liu <1298662399@qq.com> Subject: [PATCH] mailbox: rockchip-mailbox: use devm_clk_get_enabled() for probe cleanup To: Jassi Brar , Heiko Stuebner , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Date: Tue, 18 Aug 2026 17:24:12 +0400 X-OQ-MSGID: <178705945273.291840.7809734835578127304@qq.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Make clock enable devm-managed. Probe enables pclk but later platform_get_irq/request_irq/mbox registration failures return without disabling it. No remove cleanup for non-devm clock. Use devm_clk_get_enabled() for pclk cleanup in rockchip_mbox_probe. Signed-off-by: jiawen <1298662399@qq.com> --- diff --git a/drivers/mailbox/rockchip-mailbox.c b/drivers/mailbox/rockchip-= mailbox.c --- a/drivers/mailbox/rockchip-mailbox.c +++ b/drivers/mailbox/rockchip-mailbox.c @@ -196,17 +196,11 @@ /* Each channel has two buffers for A2B and B2A */ mb->buf_size =3D (size_t)resource_size(res) / (drv_data->num_chans * 2); =20 - mb->pclk =3D devm_clk_get(&pdev->dev, "pclk_mailbox"); + mb->pclk =3D devm_clk_get_enabled(&pdev->dev, "pclk_mailbox"); if (IS_ERR(mb->pclk)) { ret =3D PTR_ERR(mb->pclk); - dev_err(&pdev->dev, "failed to get pclk_mailbox clock: %d\n", + dev_err(&pdev->dev, "failed to get or enable pclk_mailbox clock: %d\n", ret); - return ret; - } - - ret =3D clk_prepare_enable(mb->pclk); - if (ret) { - dev_err(&pdev->dev, "failed to enable pclk: %d\n", ret); return ret; }