From nobody Fri May 9 21:23:12 2025
Received: from out162-62-58-216.mail.qq.com (out162-62-58-216.mail.qq.com
[162.62.58.216])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B59B23F422
for <linux-kernel@vger.kernel.org>; Thu, 3 Apr 2025 07:22:14 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
arc=none smtp.client-ip=162.62.58.216
ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
t=1743664938; cv=none;
b=CzopxGneYGr8vpUNUojVeq01wzSKOy3x4D8vmJyJOzy/rDbPLfLCyfI5eUjWuW4WVp1kkyHMU/Ch9PIdeGhsaNkWjSNZ9IBnHvKKRmZgc1aUrVZxoiCIaaL3UGUxuen6L03S4KC+rRJJ1fn++ukHfPSP7dThrwLJ6rO7dCLBZfA=
ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org;
s=arc-20240116; t=1743664938; c=relaxed/simple;
bh=NXx5pxLC6aaOP2AVJLWfudGvIXmwCOmjaLb7zV77ijA=;
h=Message-ID:From:To:Cc:Subject:Date:In-Reply-To:References:
MIME-Version;
b=KktUriL9b4q6luh25g1eANXpOZlJHCGimupgqPksuniAVtJPOyZVGifU4GvhO0SXkdrG9jOPMoph/mHgGLty6R9WQ6c/7ecqXmQBKIJ6AX9gmbdv3NR5uMu187p5O2M6cGdPrqEXgmXSax50LCJLgLEM2ZC5zR0NxTbvwN0inzc=
ARC-Authentication-Results: i=1; smtp.subspace.kernel.org;
dmarc=pass (p=quarantine dis=none) header.from=qq.com;
spf=pass smtp.mailfrom=qq.com;
dkim=pass (1024-bit key) header.d=qq.com header.i=@qq.com header.b=rBgFL2ep;
arc=none smtp.client-ip=162.62.58.216
Authentication-Results: smtp.subspace.kernel.org;
dmarc=pass (p=quarantine dis=none) header.from=qq.com
Authentication-Results: smtp.subspace.kernel.org;
spf=pass smtp.mailfrom=qq.com
Authentication-Results: smtp.subspace.kernel.org;
dkim=pass (1024-bit key) header.d=qq.com header.i=@qq.com header.b="rBgFL2ep"
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512;
t=1743664931; bh=j0n1Yn3xof12J7AxPVd/N/p9DVfFFk4LYiLYsi1jpSA=;
h=From:To:Cc:Subject:Date:In-Reply-To:References;
b=rBgFL2epG/z2EvmdOrwjuQmuU4D3Q8q6NPWCqKSI+5PvLFizenWT3GdLBQ5IHDVjo
lrOIIHxv8j7l31IobYoJfAIsg4MlibFkku2zdmrNCeSkcIRG50vhqWur9M7UccNyum
cnnTd8VblyfWU6hcz7kn1bLgO5AgR1SbsLw6ZvjY=
Received: from localhost.localdomain ([116.128.244.169])
by newxmesmtplogicsvrszb21-0.qq.com (NewEsmtp) with SMTP
id 58993ED0; Thu, 03 Apr 2025 15:22:09 +0800
X-QQ-mid: xmsmtpt1743664929twng37n1l
Message-ID: <tencent_CB48668425E7D4B6BF13E377B7447B8C5205@qq.com>
X-QQ-XMAILINFO: NbgegmlEc3Ju7Zkxg19jQiwymA8b/D1+rGpbVhMXwqQJIzhunSWITcF7isi/kn
pQw21NUCkn119uoUrI5VVK2QxAabcVMoRi/tTIxt1llpDQOtvnq79kqfbayeiT9hb0S+a0zMVyo/
m3CT1pZ+4Ipznr6b+QkND4FxvlpDnzfMTnIVbZyDoTBmBeUzWylaE9ZazguOO4lDSmMZd2SPHgvf
F+yrh+b0wQxsSMq8giDAaTuqjUihxerNX6A59JA9ic5a274eTkG5ovUkbVkXqhhAVJ2w+n3DlMrC
4FXwiQKsYhDlm5oZUK51qtwEteFV6TAJILL0ZJGI/WaTmPfL9Eco15Fd3GF2FrH689n2c12t6SXf
ue0dbuO5BXXZ+OMvljyd01kG2QDYf/HLncRqMu+ZbpMU+7UJje3n3LsVLgefapa2DPvNjZW4wzVt
nwe09ztePNWiM68g6+6zmuTawCBvalN0orm87R29O3lUcbDKWIMKtrgwUFr6o5K/WdJKJujZr8Yp
14P5ZDyB04R6q0bnkNMTQ+XS1Rd4bFYA0YQoEcE/X67vNN6xaeHMDt23Vl8Zw1eTAfGqCc9smLug
PNIwbED4e4ubUpa6Gb2R7DjIvPn15y57v9CWVJ1FVknc1WgVKmYGeMlVpCNeTdpB8aY7/Lw3krzR
aoF0pNO/MAo1GKbCfc062BRFqOomOR/Iczh3yWmf01sJfXMoip1vwLRkZDKAchnrU8Po9nNgvUi5
cAUn3MmabtljVGUZ7EN+ZCK716UmGCt4r516/WInkkpexh/O1zjhZ1p1GFeskfCN5pkr81pxI+eO
Aln6slBSSSMUw5oTjyFrt7OqUB4KlCAR55jK2tTl5t4SiMIpK79zcg6M7N7YSxZ2JbC0nEPGP2js
TfsKaanD6B9KgQCIoPPc9hfgxIMjOLG8vrv8xCPkaSe06kMeZqgrxX/0Ly9iTPScYQfhGyRGPKmZ
QIr7lO5LSLYIxcO/+fo+l3IBRit8ZnuHdqcoyWz3KqMiRhkML2hjqVkw+4Ql3SxqMDEiXYpsgqEp
m7FwihmoAUEg7ZoLmWqOexwMQPlpk=
X-QQ-XMRINFO: NI4Ajvh11aEj8Xl/2s1/T8w=
From: Yaxiong Tian <iambestgod@qq.com>
To: kbusch@kernel.org,
axboe@kernel.dk,
hch@lst.de,
sagi@grimberg.me,
chaitanyak@nvidia.com
Cc: linux-nvme@lists.infradead.org,
linux-kernel@vger.kernel.org,
Yaxiong Tian <tianyaxiong@kylinos.cn>,
Chaitanya Kulkarni <kch@nvidia.com>
Subject: [PATCH v4 1/3] nvme: Add warning for PST table memory allocation
failure in nvme_configure_apst
Date: Thu, 3 Apr 2025 15:22:07 +0800
X-OQ-MSGID: <20250403072207.1208116-1-iambestgod@qq.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <tencent_A9D89C90E6484E0EBFED4F67D6EF4589F506@qq.com>
References: <tencent_A9D89C90E6484E0EBFED4F67D6EF4589F506@qq.com>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
From: Yaxiong Tian <tianyaxiong@kylinos.cn>
Currently the function fails silently on PST table memory allocation failur=
e.
Add warning messages to improve error visibility.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Signed-off-by: Yaxiong Tian <tianyaxiong@kylinos.cn>
---
drivers/nvme/host/core.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index c2d89fac86c5..eca0d0d2c2b4 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -2678,8 +2678,11 @@ static int nvme_configure_apst(struct nvme_ctrl *ctr=
l)
}
=20
table =3D kzalloc(sizeof(*table), GFP_KERNEL);
- if (!table)
+ if (!table) {
+ dev_warn(ctrl->device,
+ "Failed to allocate pst table; not using APST\n");
return 0;
+ }
=20
if (!ctrl->apst_enabled || ctrl->ps_max_latency_us =3D=3D 0) {
/* Turn off APST. */
--=20
2.25.1