From nobody Mon Sep 28 19:24:47 2026 Received: from out203-205-221-242.mail.qq.com (out203-205-221-242.mail.qq.com [203.205.221.242]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C643C472F61 for ; Tue, 18 Aug 2026 12:41:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.205.221.242 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787056892; cv=none; b=pYzL3fC1t3IMDmW5Dbl60APrK/tJJT8GTuJJSfULh50x2cZ9C1i1/ZPRFYq02fj8AB5N9vAdC7Dwh6ez49iysLbJMuO1Vbs1fyUn0y1b8f2JX8TDdH5pP3krLldEtHKtjBfBCu+XnsMX6d/fMRJXWK1YygUBQrBtSXJhWkJYU5E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787056892; c=relaxed/simple; bh=tFvXbpa6OyJ0nOsXbD15rkA3slCbgbUTqOqt4XHauD0=; h=Message-ID:From:To:Cc:Subject:Date:MIME-Version; b=oRfXarsG4hRONnj613rUfci3LjpDwOdCxDE0xk8+J26qNeKO6/HBC86dYdeWMDpRiTXBR62YyJvZu4yNaYcQt2FQV5aQe3GJjqiXuWUg2xTmRLUHlYyW2f/FY5PH707nhRjPDWFgHGbbIt3jrSB2/lLPnXC7rWnmyU9HbIOvWQ8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=qq.com; spf=pass smtp.mailfrom=qq.com; dkim=pass (1024-bit key) header.d=qq.com header.i=@qq.com header.b=juSTHrwQ; arc=none smtp.client-ip=203.205.221.242 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=qq.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=qq.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=qq.com header.i=@qq.com header.b="juSTHrwQ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512; t=1787056885; bh=u5HjavDM57+tHoNGzplZZwhNzCckopNZ0dngFdmd6do=; h=From:To:Cc:Subject:Date; b=juSTHrwQZLAS//+DZHD1fv7iK0qwZWYi/2Z1wyBiKWTYekxlXwboJy3y3mNiNAJgh pVvlgvyluynVCXG4PymOUhpD2vSW9m1RLRfkNEbZUFPer+flgpzXGVRq9z+z8HIWMm rWt2beKEhKd3UQSGYxyLQayapGXUrRgZ/nemgLv8= Received: from ws006419.mbzu.ae ([5.195.0.150]) by newxmesmtplogicsvrszb51-1.qq.com (NewEsmtp) with SMTP id A5618CC1; Tue, 18 Aug 2026 20:41:22 +0800 X-QQ-mid: xmsmtpt1787056882te8hosznl Message-ID: X-QQ-XMAILINFO: MDbayGdXPuoejfPLqL4ymCuTGrKCAiwaM+lnnOfRe++ZlDKbIwcFatD1fXNUSl JnOgR7K/2j8h8LPaCZ+xr8krKe2LlUi6QkmFbQJF9m6kq1ltc5Q+QTcRBELYmvwrwmMxTdWJugp+ JnrByeG9Z57vKknil9k9yMSeLqq5BN4c5Iw+rpJ2phg2eP2fNaKNM0c/sliEgvQAHLT6p0Bt6I/N KAW400fZWbGOVAXeheIjw36ui6H+AAOG0Pnfj5ovwlZdghDRbHGX+Fg5hAcXEn9PDM0t9psU7Cwk Bsu9Y/tDhHRZztyAEG27qGGvG0JMOxYelAhJgk/YnElOpgL3T8MyhPiJs7GOf29rXJZhfIDQOKyO SW2FRkWmaGZO47U5OBd4YA8u6iPcUOOZLKEYo2xVkt95Pe7XeGFbad9mmAqAPWpUiRaxPUDE5hcn x7wSBc40BgagpQJipd0zlnIJkr2HEE2K+SupDGltdD09O8UG1W3GEhksMmDjvxlctyhJSXUIH65J 1QvEH78QGoKvMq+6IqjenmEvhVAhmLi8OpxSQB1Ox29jqgF3FOSM9wYn2ULQGGkq+q/BGIVrPJIt jMGCpbh8abgXnGrRwP5B6L/FV0VtIFHa8L9b+qn0AIx4nYRQcipNAcGLybky7ejM7axfuocLuM8U hsWgntyp+rJcMnvF6lOKWFC+5w0y3O+D6OgilU4DD0kAvJTR9UUB9P9ak96cujl1MDozAtE2W2Nb YsiM9kPFWCammf4+Og4lyX+v+PUwGWw0Kd8eBzNm5fTYBBE7SHJtog1ncdlZW0SYEog+25uFb5w4 LHj6o2lVhkYwLcgCzD7eYR2YBKkP+AYFGiJGOW6QObRG6xjbMQomK0DweuPmHYpDyBclKfjQod5b cSvoB6gP4SdxIHssQ7EOiHxZhc51/Qjq/EUBbsXAFo66KxS5Lq5OX8mMHM8PknXiRsDxWHI5ToP8 inCdF/HJsVLSrBBf+WSx+50ju9voh9mBMwy394eNBiCKfxUhUnlkoByMuM/8twucB1DJycBdKWTq oaoolMIWRhlvn7z6r/VvmSxmDEId9Jt4XcehpGxVENaRcmYSLvPljUFQVkDN+sVz1qU2GSPzeDcz u1b1vFQefrwn6DLNQ= X-QQ-XMRINFO: MSVp+SPm3vtSI1QTLgDHQqIV1w2oNKDqfg== From: Jiawen Liu <1298662399@qq.com> To: Vladimir Zapolskiy , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: jiawen <1298662399@qq.com> Subject: [PATCH] rtc: lpc24xx: fix clock disable order in remove Date: Tue, 18 Aug 2026 16:41:21 +0400 X-OQ-MSGID: <20260818124121.246938-1-1298662399@qq.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: jiawen <1298662399@qq.com> lpc24xx_rtc_probe enables clk_rtc before clk_reg, and its error path disables clk_reg before clk_rtc. However, lpc24xx_rtc_remove disables clk_rtc before clk_reg, which is the opposite order. This can leave a clock prepared if probe fails after enabling both clocks, since remove is not called on the error path. Fix the remove function to disable clk_reg before clk_rtc, matching the enable order and the error path cleanup order. Signed-off-by: jiawen <1298662399@qq.com> --- diff --git a/drivers/rtc/rtc-lpc24xx.c b/drivers/rtc/rtc-lpc24xx.c --- a/drivers/rtc/rtc-lpc24xx.c +++ b/drivers/rtc/rtc-lpc24xx.c @@ -272,8 +272,8 @@ =20 rtc_writel(rtc, LPC24XX_CCR, LPC178X_CCALEN); =20 + clk_disable_unprepare(rtc->clk_reg); clk_disable_unprepare(rtc->clk_rtc); - clk_disable_unprepare(rtc->clk_reg); } =20 static const struct of_device_id lpc24xx_rtc_match[] =3D {