From nobody Tue Dec 23 16:24:48 2025 Received: from out203-205-221-153.mail.qq.com (out203-205-221-153.mail.qq.com [203.205.221.153]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 604DD231A4C for ; Mon, 13 Jan 2025 07:13:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.205.221.153 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736752431; cv=none; b=QvHn/mBHys9EUeRQop+rfu33JgWYdx1qLOGHKul08N4i4oLCAmF7p7VEBJacErJB6l30b6c68k6xrjfzfCu2ufWeQ8pW3FKsz45kiUNCjcSCtXEvpLHLHKq82CA0Gl/rYrLwbQT9f9K4uUTJtwm/yvBovuTQALvmD4n//EO+btY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736752431; c=relaxed/simple; bh=Crp/ABeMqqkhvXHIudSW988GnUwbnnTtDbfdtVLktE8=; h=Message-ID:From:To:Cc:Subject:Date:MIME-Version; b=WVxgo2c92HOqrV9my7wTTA3u19HXJhCvL4xmipwN+Be5FI+Wp0vDNVME7eRw5a3ztkK7rcT2cswub9CQOgr3kpXdV0EVcpHlEX7eYgpgFlaSqFxVt5X+ZLoR4imniKe5iVLpC1z388FdYvBdLAMN8GeMeFyHPtk3i48/Psjh9nc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foxmail.com; spf=pass smtp.mailfrom=foxmail.com; dkim=pass (1024-bit key) header.d=foxmail.com header.i=@foxmail.com header.b=Qh0zLfJb; arc=none smtp.client-ip=203.205.221.153 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foxmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=foxmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=foxmail.com header.i=@foxmail.com header.b="Qh0zLfJb" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1736752118; bh=k3QRSjcnKk6Udfjid7rHbFoa3RL2T6VjHRZLWm2/r3w=; h=From:To:Cc:Subject:Date; b=Qh0zLfJbxv0IH30lJASOYTqkmKDawDSBv+Ijjm6AKnIYDR9yEzz5GhponLeSCjaJd cJwQilSsr9DwMg6/Q6+ywtFDFoIDP0M0ZkuWrbFh0bQYaHZC8xI70dhT3oI6MDcIKT Plie6O8SFDKghrkQeqZ1cF4nLPf27sQrfmI3AwfQ= Received: from localhost.localdomain ([116.128.244.169]) by newxmesmtplogicsvrszc16-0.qq.com (NewEsmtp) with SMTP id 22514A3B; Mon, 13 Jan 2025 15:08:37 +0800 X-QQ-mid: xmsmtpt1736752117tzsp8lkgd Message-ID: X-QQ-XMAILINFO: NMGzQWUSIfvT3QL66qYKb6PiCAeRC2eKNKnIJGJzEeF3FxGYBFLugxgWvltEBq BDiyECwy2SZ1voUrnOGT01sWU34MnmxyWRSmcs/oewOF43e0KWiX+lQM3rsqMhlKU0AUODjhauRB GGFVyB8JKSTAizeUoqtFgACZCk4+7vtfP+6ablVCO8xZL4kh9PcM5SJ7AXocu0tJmEgjcrJ5ODnh 6Mb/sGnjp1wE+ZplpFaOwR9bGc1EPcnsUAGM7K7lEgo6fxmOhWMjIamIHw7yKq8lMV74n+liYo0U /tTUotUWsJKxq0rBG2wbHEfc1aGaiKHBI+bwAMb62LsmY+cZJ4PP6cemjsZ0EIdw75q3HncTxQSv xMoYTQQJ4bpC/biXbUXx/sM6qBbrXGwfxIoF2UvuZpERoW0P7+HEstENuAxUR1J29y/mg0GiV21b Tkl5zveddvHMYW8k3V0DNiL/aXn1W0ws2to8JVvIS1KI8ZMlGzj8PMZnmVLk9d9btx35MYQ3QNwe Oq0zZJFpCR2SZNQNVfJqUHWKf9EaVI6BdH/lMO4a+U3FNmAT7JwrXkD54FF8al7IVK1jhIW/OeF3 gpfVutIxozsfQWCgnNOaRl3mbfp9DVGBGL/Sh240+Ily6KUNZkxUps1uiaQ04fJz5iFIbb6f+V4C UF6Azv8QVzm0D6fvriiXNbmUtvGIxuZjelhF2JJdqNzPUcgb9D6US1cq4v3P8YclXWrMm92zNmeP K1ShxVw2ANYKAybNdkXQDm42Byj8zn7Ngls+930cd2rDSEjGp4W4rJDG6WBmgHgUZzqwMZhUpiDi lD+LnvmSjJQtj0TqbKZMXxj/cT3Q3gAGAx8rkckjtwul+wbIdK8Xc/dFZwK06S3R3fM8JixGoDnv 1/KXs5eIBOx+SvlSdUDhQvulFPFpGvI0GqRPtVI1BvUdegFSsVl24LdAvfhwLyVpmY4ymt40luJI zP6M5NrK4= X-QQ-XMRINFO: OD9hHCdaPRBwq3WW+NvGbIU= From: xiaopeitux@foxmail.com To: vkoul@kernel.org, aford173@gmail.com, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Pei Xiao Subject: [RFC] phy: freescale: fsl-samsung-hdmi: Use helper function devm_clk_get_enabled() Date: Mon, 13 Jan 2025 15:08:33 +0800 X-OQ-MSGID: X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Pei Xiao Since commit 7ef9651e9792 ("clk: Provide new devm_clk helpers for prepared and enabled clocks"), devm_clk_get() and clk_prepare_enable() can now be replaced by devm_clk_get_enabled() when driver enables the clocks for the whole lifetime of the device. Moreover, it is no longer necessary to unprepare and disable the clocks explicitly. Fixes: 6ad082bee902 ("phy: freescale: add Samsung HDMI PHY") Signed-off-by: Pei Xiao Tested-by: Adam Ford # imx8mp-beacon --- drivers/phy/freescale/phy-fsl-samsung-hdmi.c | 17 ++--------------- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/drivers/phy/freescale/phy-fsl-samsung-hdmi.c b/drivers/phy/fre= escale/phy-fsl-samsung-hdmi.c index 1a079075de67..170eac317b16 100644 --- a/drivers/phy/freescale/phy-fsl-samsung-hdmi.c +++ b/drivers/phy/freescale/phy-fsl-samsung-hdmi.c @@ -667,7 +667,7 @@ static int fsl_samsung_hdmi_phy_probe(struct platform_d= evice *pdev) if (IS_ERR(phy->regs)) return PTR_ERR(phy->regs); =20 - phy->apbclk =3D devm_clk_get(phy->dev, "apb"); + phy->apbclk =3D devm_clk_get_enabled(phy->dev, "apb"); if (IS_ERR(phy->apbclk)) return dev_err_probe(phy->dev, PTR_ERR(phy->apbclk), "failed to get apb clk\n"); @@ -677,29 +677,16 @@ static int fsl_samsung_hdmi_phy_probe(struct platform= _device *pdev) return dev_err_probe(phy->dev, PTR_ERR(phy->refclk), "failed to get ref clk\n"); =20 - ret =3D clk_prepare_enable(phy->apbclk); - if (ret) { - dev_err(phy->dev, "failed to enable apbclk\n"); - return ret; - } - pm_runtime_get_noresume(phy->dev); pm_runtime_set_active(phy->dev); pm_runtime_enable(phy->dev); =20 ret =3D phy_clk_register(phy); - if (ret) { + if (ret) dev_err(&pdev->dev, "register clk failed\n"); - goto register_clk_failed; - } =20 pm_runtime_put(phy->dev); =20 - return 0; - -register_clk_failed: - clk_disable_unprepare(phy->apbclk); - return ret; } =20 --=20 2.25.1