From nobody Mon Feb 9 03:16:43 2026 Received: from out162-62-57-137.mail.qq.com (out162-62-57-137.mail.qq.com [162.62.57.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 156482773DA for ; Fri, 9 Jan 2026 16:27:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=162.62.57.137 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767976077; cv=none; b=M/B0LMmosotqx5EU9ljRic4fddOjBawNrT5kNBAdGZrlV98uTJu3phTDcE5D9JdekA+nAtGjo8Jaz0NNIR7Wc+eHrj5pcPd2oCA9I+a1orJlnTk80LerF1emEDTCLkLL5bc0/w2gWaj7jhKl7iZWbyI0+qJIgEusyNfDRxMX2vg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767976077; c=relaxed/simple; bh=REg6EYQlca9YXKTR1FHRDnNY34UXgs1oR37QE/L/VzI=; h=Message-ID:From:Date:Subject:MIME-Version:Content-Type:To:Cc; b=CW2f8h9I5Bev2nbdzeN4O4qUtae281HaPDOadtw1SMiaHOdPAp46HzId/4/LHugvgeBpGZBQ9mVnmo53VIl7z09pvstvUw2Ocb5xpz6R7V7MRkSVJX2JHsVJByRyY+eBL7MvSJX4zEW3/c0/MSaPSI7+ke374A48mYJ/LLnK4iE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=qq.com; spf=pass smtp.mailfrom=qq.com; dkim=pass (1024-bit key) header.d=qq.com header.i=@qq.com header.b=qrnHXk9c; arc=none smtp.client-ip=162.62.57.137 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=qq.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=qq.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=qq.com header.i=@qq.com header.b="qrnHXk9c" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512; t=1767976065; bh=vboWgPcAQso3BNG/Ppoc3DTn9juajR4TWjqsxcP+ry8=; h=From:Date:Subject:To:Cc; b=qrnHXk9c7382td4a6yWIoiZnn2pZhrr1SK9ZW2kK4yHo6jTVYKULdpn9D/TgzTxM2 DXRooTcSGYEO3xdLAwTVQJzy5QUg1KH8U7gI4VnjDrbnNQaJFVYRjgVpquaWluZnRm sfu7ov8l7qIPsKkEjt4gWiJOThcNdvhjnlby3q9o= Received: from junjungu-PC.localdomain ([223.167.147.103]) by newxmesmtplogicsvrszc41-0.qq.com (NewEsmtp) with SMTP id 6EC1FEB1; Sat, 10 Jan 2026 00:27:44 +0800 X-QQ-mid: xmsmtpt1767976064tmp81uzyq Message-ID: X-QQ-XMAILINFO: M+y8bvN21IbRtmeOceVnDhC0/35NAJusPssN+5Tt5WFmGItdBIADEvrl+CwIYb ATlfEO2O6uY8FEM85ZbtXvCsMqLZ7YZ4SDcz3ouLl+PG5NuMxwSWWl1BQU8xA+4nVSnl2cvOrdJ4 gzYKORvRXhYhxC8hF5bZ7DKm2glIOMlw8eeu/QoOZr+/3Ujcs0VGx/SlfWCtQ3tUQGQyAi2gGmXd qI2ivBGKZqmABNqZ4tgGlZgc8cmN7r83bmzjQaG9Bjx+xZHJCT41uqDjW9WTtP6LYFns8GRCh3Sw ThG6i4eF43Z5iuYgaPOKAJ5EO1fZG0Rb+NCdcbhS68ntqHkS2zwmkadnPJKYucUiHSeroV6aeNZx qq12u92Nrj8Ze50xR4WflqtOjFwzyT8h+8C9oKFHMdr5fqZ5eo8Yzp6jqUdRy2hc5hzyplO1DiSH B4spMckijSKnzSwHWaHHVp+wW4sevnT3Uw8Mc0DR1h/xd+BO0vsqpwLzD3zUtsgT3bI0M56Bo6WX ojEadoHKUuwg/l4lIhM/n1QPgRBdGrQG+h1bhW2qcCfpo99b+o7etTGRYgCX6rpKqBWOYS/FxR0Y q4INBBxIgNcGIEIzHQrzYtc7Z/dGIBekG8wZ1dQIOKxKkA5H5ZIFMyJv1TLQucDkNDm/h5q24nCi JXvNuk26yooiU57JkAhRDYcxvZ7c5sP+Xa9ZQV4+2tmtwMkLlFgDZVWkgRRnUoJIkhf91+dwZF6j nKd8p7Fb5CZ96PtMcG7IsvxW6tY0HQKn6F/rAALUXurWJnw10dxYVNM+hhxPjICyZL28rx10lsa3 RJblOv0G2PzIr2LzSKh25e4XjBK1Ua7SgN3xo//GBXr1M8pdsIQlKVEqp6FLqBuiNitXURiFz3DC lV3zYeaJ5T2HADXteORg3Xk3cObiTDyAnza0a3SxkGmzREgFc6i0P22Tv06XFrXVbZvRikJtGBtF qaSG3vHV3Pa2M4cxfPzMguBV0AcuNfBLNfAMvq0uULbhWREnk7cm6attBUCtYrzVONd/GH53Lea0 WwpXQNvbl0aj3EtiTer/lov49lNlcPuDirgEG87uVrTb7YTVOGQyEpNCFCJlVzSyssuVPoeABI7B 2Hvombsy8YRwRkjT5nVuOT4RY2gxJczNZeBwUT9QsGJc5aS1eFyjdOrbnDwTEZBAYjMaOQkGi/Rw RjXBEAPY7hMnpgpA== X-QQ-XMRINFO: MSVp+SPm3vtSI1QTLgDHQqIV1w2oNKDqfg== From: Felix Gu Date: Sat, 10 Jan 2026 00:27:44 +0800 Subject: [PATCH v2] mfd:tc3589:fix a potential resource leak Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-OQ-MSGID: <20260110-tc3589x-fix-v2-1-e6bee99e42ef@qq.com> X-B4-Tracking: v=1; b=H4sIAH8sYWkC/23MQQ6CMBCF4auQWVtDp6kFV97DsIA6yCyk0pIGQ 3p3R9Yuv5e8f4dEkSnBtdohUubEYRbgqQI/9fOTFD/EgDVajXhRqze2aTc18qZs7ckIvRtGkMc 7ksxH7d6JJ05riJ8jnvVv/d/JWmll2sG6BnXfk7sty9mHF3SllC+tgc3kowAAAA== X-Change-ID: 20251226-tc3589x-fix-50ce3358c7bf To: Lee Jones Cc: linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1767976065; l=1191; i=gu_0233@qq.com; h=from:subject:message-id; bh=REg6EYQlca9YXKTR1FHRDnNY34UXgs1oR37QE/L/VzI=; b=v6Q3gqp+SvuSxzQftBMVexPUl/dznZVKzXku80yxebvk8c0IZXDUEAacRCrCVJW8a5F8LWOaF vEcDQTAMYAIApJbfUMnCSC4pxuaVnN1FKSD3+iy6Rhi6uGlHIZpyQ79 X-Developer-Key: i=gu_0233@qq.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= Use devm_request_threaded_irq to repalce request_threaded_irq to avoid a potential resource leak. Signed-off-by: Felix Gu --- Changes in v2: - Fix format. - Link to v1: https://lore.kernel.org/lkml/tencent_EFCFAE871E8872447FF88F99= 091A51701D08@qq.com/ --- drivers/mfd/tc3589x.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/mfd/tc3589x.c b/drivers/mfd/tc3589x.c index 2d4eb771e230..f673ee4e1d16 100644 --- a/drivers/mfd/tc3589x.c +++ b/drivers/mfd/tc3589x.c @@ -410,9 +410,10 @@ static int tc3589x_probe(struct i2c_client *i2c) if (ret) return ret; =20 - ret =3D request_threaded_irq(tc3589x->i2c->irq, NULL, tc3589x_irq, - IRQF_TRIGGER_FALLING | IRQF_ONESHOT, - "tc3589x", tc3589x); + ret =3D devm_request_threaded_irq(tc3589x->dev, tc3589x->i2c->irq, NULL, + tc3589x_irq, + IRQF_TRIGGER_FALLING | IRQF_ONESHOT, + "tc3589x", tc3589x); if (ret) { dev_err(tc3589x->dev, "failed to request IRQ: %d\n", ret); return ret; --- base-commit: 3d845d25026c5b1050e927e3ee4c515977a9b490 change-id: 20251226-tc3589x-fix-50ce3358c7bf Best regards, --=20 Felix Gu