From nobody Mon Feb 9 12:11:25 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C83B1C001DC for ; Sun, 23 Jul 2023 07:13:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229760AbjGWHNr (ORCPT ); Sun, 23 Jul 2023 03:13:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41600 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229503AbjGWHNp (ORCPT ); Sun, 23 Jul 2023 03:13:45 -0400 Received: from out162-62-57-210.mail.qq.com (out162-62-57-210.mail.qq.com [162.62.57.210]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F0C69E4A for ; Sun, 23 Jul 2023 00:13:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1690096419; bh=BydRQ7LrlxKwL52rvHooi1sAXvD3aBwhb8X0VNEtSOM=; h=From:To:Cc:Subject:Date; b=xECZ8d3GEIMhVwS7A4hzYYweLjrZOguZBn/JJ5OfsWBn/pUCd+75UOKHM44vvNuCi oQdON8BWU8dugfVfryoTZ6XIAEjUQ/uam3HMq2khoAIDZmX87X2ktN/xV709hdu7K3 pPEek6wakIR+XuZP3IamdUnY/qtN1Skx6FHw7Lq0= Received: from localhost.ust.hk ([175.159.123.184]) by newxmesmtplogicsvrszc2-0.qq.com (NewEsmtp) with SMTP id 1E027011; Sun, 23 Jul 2023 15:07:32 +0800 X-QQ-mid: xmsmtpt1690096052ts63ans26 Message-ID: X-QQ-XMAILINFO: MtiJdzH17lJXn8+YGVSqosmIrUD6q6uQf2Rq1TAbO/gCztlBx7eFvcvCQ8lNvY 90FYDRtiC5jkEcC86Jdhcm0DnOC+7LBqavgEFhMB0xnQjxTm7c6XiGUj1ERsNj/6xzTSGUdaJxTz thQKSDDXCriwUzNhu9rlEWcclYxUfj0xy8p7ZKihAOMnMsKS+6ajYb02pqpZnyVJFWNir3hIzlGi vQgppJOGxBIFC6P8sanuLd3Eyt+GIttiw3sq4+T4nLCwkYv/E1+A8ycPS2Cz1+ZjBUuMlc/i4V+T lnTKTWLAhZzq/zKNaHGLDsYCMGcZKaGvT3QHF9ohTfiTSn82E2rL7i0QHyZIEMJaH0q7CmXozJk8 Dtp26om5Zi5yLNB3XYU1nSKbO7VvgEOkriac3emTDIM9j/Hhu/rEbasEr8XLyIKH2dtg773AxoC2 og+7zUlQ+MCOmlsGH/5XyTj+25+1P9G0PUV3FG1o8KTL66UZuaWDuyamDgzkw3W+BRT3lpasI0QR h6AMwN7rEHgwFNJJfmyKnN5Zs2xpZrbmhEdQSj0mOVdF90cMbbfTIt/V8CLYoFQkdslHIZSJo2RB Hoc/EooUXK5K6mF+Q9q0/3ertZ7306oBzqlelVy4BMBenVD4eQSTvfTkCseOG/41ueMHm3NpjHKK 649NAtCK9ilg7lFDDBnh6b6/5tc3AC3P311EcSANotAhEE8Qis6J+a86v6mRyLz6hQOrBK6FncBV CR9gl+Sq7oMX0IcRH32nMpEa3lN58A5Zxf2bHsYAiMt1sDdZFMRU4UPWg8RP1ebonbYGKsKBowsY exST73kZqa0D/B2HQDAfMRZWU7oxixaL64sFwLkBxMkxE0hIxHgOVq2tSCgPg2F2h+H/D1KmoRMp 3B5Mm79aD/RbESeXv4Ptb+LQ/GkgaS8Yl/Xx1pIqZb4+VWyGYx+W0T0e5dc3NAK7DwtJMr2+61zW 6a1vzJug9q4sJThXRdlZyMvR/0ZAD8151yHXEoW3YY8C6SggArug== X-QQ-XMRINFO: NyFYKkN4Ny6FSmKK/uo/jdU= From: Zhang Shurong To: oder_chiou@realtek.com Cc: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Zhang Shurong Subject: [PATCH] ASoC: rt5665: add missed regulator_bulk_disable Date: Sun, 23 Jul 2023 15:07:31 +0800 X-OQ-MSGID: <20230723070731.6195-1-zhang_shurong@foxmail.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The driver forgets to call regulator_bulk_disable() Add the missed call to fix it. Fixes: 33ada14a26c8 ("ASoC: add rt5665 codec driver") Signed-off-by: Zhang Shurong --- sound/soc/codecs/rt5665.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/sound/soc/codecs/rt5665.c b/sound/soc/codecs/rt5665.c index 83c367af91da..de36cad8a559 100644 --- a/sound/soc/codecs/rt5665.c +++ b/sound/soc/codecs/rt5665.c @@ -4756,6 +4756,13 @@ static void rt5665_calibrate_handler(struct work_str= uct *work) rt5665_calibrate(rt5665); } =20 +static void rt5665_i2c_disable_regulators(void *data) +{ + struct rt5665_priv *rt5665 =3D data; + + regulator_bulk_disable(ARRAY_SIZE(rt5665->supplies), rt5665->supplies); +} + static int rt5665_i2c_probe(struct i2c_client *i2c) { struct rt5665_platform_data *pdata =3D dev_get_platdata(&i2c->dev); @@ -4786,6 +4793,11 @@ static int rt5665_i2c_probe(struct i2c_client *i2c) return ret; } =20 + ret =3D devm_add_action_or_reset(&i2c->dev, rt5665_i2c_disable_regulators, + rt5665); + if (ret) + return ret; + ret =3D regulator_bulk_enable(ARRAY_SIZE(rt5665->supplies), rt5665->supplies); if (ret !=3D 0) { --=20 2.41.0