From nobody Tue Dec 23 14:22:02 2025 Received: from out203-205-221-235.mail.qq.com (out203-205-221-235.mail.qq.com [203.205.221.235]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DBFC910F4 for ; Sat, 8 Feb 2025 03:49:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.205.221.235 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738986558; cv=none; b=hNdm1fFFOvqC7R+4lABC6WCgb7kJDaoMVJzB+RCH1hynRqPl+snvAmrZAC03bxcg2/P3ie5Igkce21SJ1ajTIn5NgpVa/rXyNlFv2fAvMkZcSvwUwYdl7ejsBi8z5czwYx7v6yQDR5PIRqcnfWJMHBuY76BHWy0jmWGCMZNC/Ro= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738986558; c=relaxed/simple; bh=eo+At+lo0bBwqeHMaElxJVTUJ5rCLugH0Hra0W76Mv4=; h=Message-ID:From:To:Cc:Subject:Date:MIME-Version; b=ALrQvriso56fxTObCyLYBzWmVMccCjk8aBDbT0f1glOcCXdvu35Sr3s8GyjaPWWcPOgxYfMnPvteg5YtY5Px9LOc7NQOY7flxdIq1bGibierEY6eWgGcXSY5ttKeuwiWJbkUpSuHP+9tzOnDGxhF8kAYtttAZbRWrmbLqfWW8Ng= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foxmail.com; spf=pass smtp.mailfrom=foxmail.com; dkim=pass (1024-bit key) header.d=foxmail.com header.i=@foxmail.com header.b=D/WaaYIl; arc=none smtp.client-ip=203.205.221.235 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foxmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=foxmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=foxmail.com header.i=@foxmail.com header.b="D/WaaYIl" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1738986245; bh=e4n88+gDSsJKY+HVB64NCGgLJNMxgKvFLU8UcTTqY1w=; h=From:To:Cc:Subject:Date; b=D/WaaYIl6Ke1JsOnXy+kc9LTRnt9Xemj4+gRoxz9iiHKOFnTELu0yxlhTC0Eo5L2w DNgCJVydTPZaUEvDYE0w7uSNBCUGG7O8ukfwGfEOAiChqZe1eHTTT9hKj3bTEK1zhX 0A+Bldm+ieZpY75uz0/fSSDqq2oUnLNN/JCVWhB8= Received: from localhost.localdomain ([116.128.244.169]) by newxmesmtplogicsvrszb16-1.qq.com (NewEsmtp) with SMTP id B03A02E2; Sat, 08 Feb 2025 11:44:03 +0800 X-QQ-mid: xmsmtpt1738986243t4i6dngw2 Message-ID: X-QQ-XMAILINFO: MyIXMys/8kCtpCEsaE87BPfzxLKbNV7vBnnW2fDzpCzz68dTVclMNlgG33e1hw pts5h3vuLulekaFIbmi5eNmOe/fcFw0tP8C19AX5wQbmTkJsqIkm21ZIy/IeRlL0yX9MlcMj3nhO Auh+17CGxuaQpNPkrX4GOk+UfyjWn8lqiJiISvEjgQe9og5X4QCT7vSeO1uuwSeR+djeCEwOsf5K UaAhqo+xYbkC6rcGig8DS4v5Xow1HWEUVnIAyVWvYLkSb+YtKw0OcpTGI5f9NBbzfp7kLvVC9+zU 6nOYFNsoLlPwl4gA5qXrl/6PdU1nW7ix5Lcwv1dnv6xcZCDofsOmfGCr5pImmbMffo7vgU9zEm8s iCMmaiKZxZPF+GFxCraPlvwBgDHBQGcAIH9s/6t4vQWJKHWezjtb1+SiEipoZvyMuikTxJha9o12 0gWiy78RfP3U3MCllnD7+w6AxWFrTzSoAW84rAXEsOl0+RJGZF8PDbauUd9XJkwRtp5a7AkgiWQJ FVkn7N3a1CLxKfg7JIgbqAdsEFVRBifTXeHO0nfdTrFvZOTiFt1f2GQAv8viH1OL+dKghWfOLkun EhnJMxuDcdk9yRBeBwu5VV6+MHxAteWo9Hjgnvf7HsMwSDzziRZ4Kwd6q4Pnz8IhOYEX+B52xybH oXiy4hzc6s1PR1fOVKvEglzU504nFDFs4tGX2TVWTKPuAMCeWRZvYFRaRZClCNpCnO7IIolU2EGg 0x+0MJ2cUaCdiJk3p3sMmx1iIB6BAvp+eywFYIEyfuk6j1UvvuduM0+H0HDEBPtFrZgtkONRUULA XzsX5U7EMBMCzhrjmDYwEspBOg7KgR4xIvN7HEeCrqcep6nsVcHmxhUr8Rxm8yYcMmZwruvub+CV 4Re7tvtOxpBlAi9HtV00sGH7HOLF6MJurKX+SFWaudrkeECwQHDxiUr27Y1pgCzmiAT0Mj8OMs26 snE220GUY= X-QQ-XMRINFO: OD9hHCdaPRBwq3WW+NvGbIU= From: xiaopeitux@foxmail.com To: aford173@gmail.com, vkoul@kernel.org, kishon@kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Pei Xiao Subject: [PATCH] phy: freescale: fsl-samsung-hdmi: Use helper function devm_clk_get_enabled() Date: Sat, 8 Feb 2025 11:44:01 +0800 X-OQ-MSGID: X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Pei Xiao Since commit 7ef9651e9792 ("clk: Provide new devm_clk helpers for prepared and enabled clocks"), devm_clk_get() and clk_prepare_enable() can now be replaced by devm_clk_get_enabled() when driver enables the clocks for the whole lifetime of the device. Moreover, it is no longer necessary to unprepare and disable the clocks explicitly. Signed-off-by: Pei Xiao --- drivers/phy/freescale/phy-fsl-samsung-hdmi.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/phy/freescale/phy-fsl-samsung-hdmi.c b/drivers/phy/fre= escale/phy-fsl-samsung-hdmi.c index 6817ceabaab4..7be625a25f9a 100644 --- a/drivers/phy/freescale/phy-fsl-samsung-hdmi.c +++ b/drivers/phy/freescale/phy-fsl-samsung-hdmi.c @@ -669,7 +669,7 @@ static int fsl_samsung_hdmi_phy_probe(struct platform_d= evice *pdev) if (IS_ERR(phy->regs)) return PTR_ERR(phy->regs); =20 - phy->apbclk =3D devm_clk_get(phy->dev, "apb"); + phy->apbclk =3D devm_clk_get_enabled(phy->dev, "apb"); if (IS_ERR(phy->apbclk)) return dev_err_probe(phy->dev, PTR_ERR(phy->apbclk), "failed to get apb clk\n"); @@ -679,12 +679,6 @@ static int fsl_samsung_hdmi_phy_probe(struct platform_= device *pdev) return dev_err_probe(phy->dev, PTR_ERR(phy->refclk), "failed to get ref clk\n"); =20 - ret =3D clk_prepare_enable(phy->apbclk); - if (ret) { - dev_err(phy->dev, "failed to enable apbclk\n"); - return ret; - } - pm_runtime_get_noresume(phy->dev); pm_runtime_set_active(phy->dev); pm_runtime_enable(phy->dev); @@ -700,8 +694,6 @@ static int fsl_samsung_hdmi_phy_probe(struct platform_d= evice *pdev) return 0; =20 register_clk_failed: - clk_disable_unprepare(phy->apbclk); - return ret; } =20 --=20 2.25.1