From nobody Mon Apr 6 09:15:06 2026 Received: from out162-62-58-216.mail.qq.com (out162-62-58-216.mail.qq.com [162.62.58.216]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 98DD634572B; Fri, 20 Mar 2026 07:05:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=162.62.58.216 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773990307; cv=none; b=rvGfd37esdhqGGEYD+OJV2HX+6yW06PqA6UD/jnJjDWVLRdqrFzas1irDhjneVL4Lyy/d1s+8LerhVisE1vt+vOYjPfUOaxViKwOYDVEanr1M27jgn39zYhjsSx/JbkNR0ipyUNEXUUxA5EFXWXGfo05S9Ys549fKi9ZUBDCUBs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773990307; c=relaxed/simple; bh=bhG3+ejyfgREh/5n4GwjqSoOyMORTMNSPuX7d5gEKuk=; h=Message-ID:From:To:Cc:Subject:Date:MIME-Version; b=fNDkz/uVmW776q/LxbdRyGI0abwp2XwfAPerkWIR88E25pWOxhmD0+6Va+adcIswkfamN5uGHP+BvaECwteCF97cd7t90PVSRO6jrCki/J0bbDLCICCD5nw0pXp6cq5uCD40HNf2z0TjayX0HmirAkCyJbObqgoKFfYGY374d3g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=qq.com; spf=pass smtp.mailfrom=qq.com; dkim=pass (1024-bit key) header.d=qq.com header.i=@qq.com header.b=YFjyd2FB; arc=none smtp.client-ip=162.62.58.216 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=qq.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=qq.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=qq.com header.i=@qq.com header.b="YFjyd2FB" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512; t=1773990299; bh=5EyfsAtybbmg/tJsn3COKw4q7r7+MZy7e5S8MPIFPlU=; h=From:To:Cc:Subject:Date; b=YFjyd2FBwd3bJb3RyYExDFv8kF4iK/a4Gv3Xy9VKuTVV3RvMQTex2soPj0R6o3rJd +OuFPxXk1xUtKZdo63hrVUTq+d1aJjx3xWZ4tFxJigLpYuxFFB6z/2EXlY3JaAosT8 LcnzGLUZ3HLBGdeZ+dfcWy6duaABc1sRbmNKKOGw= Received: from June.localdomain ([123.121.145.35]) by newxmesmtplogicsvrszb51-0.qq.com (NewEsmtp) with SMTP id 137892B0; Fri, 20 Mar 2026 15:04:55 +0800 X-QQ-mid: xmsmtpt1773990295t3aq98a3q Message-ID: X-QQ-XMAILINFO: N/WmRbclY25GmJ6tVvoTTBzwSY9mMxX5NbqnrNt8vJFK0E2OIrFzggI8ejB8BG 2nmV8S8jhBF+4hH1LVs+FQ5iEHLtbhjqKfjlpHML7ACS6nO4PoX7wXH1lV7PuyDAc5UNZl+PVW8o Bp6d8eBndPDQN2R3rYApbLv2P5FtV4d3Z/friFDF6uCHRvatdBDMvdT6pcsT7dbTlCpf/sKKlm9n BXiFkOp1MEgKsNGMtctp9zcxAF8UJhJh90SJ21L0UKandtWyhZgKKDip93293iOk/qMA9MxQvLk+ /baXExvisZML+ggkhp6nsgv2jNNDcCsqbpttHteOpZjTsLINLlCJuH+lucyUeMBQWQrbq1z2+rzM miK8BqMtc+fNli7sTQEQZQh+FWlUNgCc1+QzdyIks7dlUzXsTR4ytQRxEhmU1ruZEfTC55t9P5YA i/Yoq+hTditn1eYlTGxSu8Dzr1jAxyPAjA1Z/TCs5DUsaOG7nljCZwMw31Q88dhEds9JFKM1WAmP TTIbKSmv3OQp/WAOcckSnfswySr3mUUzgdVeXLgTXCUk6sz+4Mxn/5ek2OPu6MacCadhTBlrbGS/ bEnLdptBsLjM68+mxQDlTgU8XTChfZckLlRbHdyIveJuwprId3tSE6RPNwAl+rG9QhORCpkc7312 M8ZiLoYQL7boDsN2IA6NZP8L3F2pL1QcbGxPOexGgAt0EmMHq6k9VHdkkBFHTv9Llgagav/DLbBU OmnxepFifMyZgak/AXxlJgYt5d+E+cO8cgRezOSZl7FmqOh6HJ8+IEjRrrMZCdr/RFdwISq/v8b9 Yaj1jduxaIMIL8ZvW5gRyW+coSaAaO4aQIf40icNAcqOBQitWMgEVyo3OkyNzBph5mSOLRuQVUvc KJ3Wz1QT4JV71cjb1qk1CkLaollebhJOf9VWPCW7V1QLIMpwQ8s0+xng0ZDsxhs6iLEDyNyjXb3X gwCUJwBQMqluzE2rDYWvkpZIq6nXG1GZUwXPEURI74pdbkKe130Vtf34E3Apz+xqkqvG8O1fg/Mp rmltZoHAdipcJKEaQSQBsgddEDNtic75PApPfIKQ== X-QQ-XMRINFO: Nq+8W0+stu50tPAe92KXseR0ZZmBTk3gLg== From: Wang Jun <1742789905@qq.com> To: Mauro Carvalho Chehab , Wang Jun <1742789905@qq.com>, Kees Cook Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, gszhai@bjtu.edu.cn, 25125332@bjtu.edu.cn, 25125283@bjtu.edu.cn, 23120469@bjtu.edu.cn, stable@vger.kernel.org Subject: [PATCH] media: cx23885: add ioremap return check and cleanup Date: Fri, 20 Mar 2026 15:04:53 +0800 X-OQ-MSGID: <20260320070453.614-1-1742789905@qq.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add a check for the return value of pci_ioremap_bar() in cx23885_dev_setup(). If ioremap for BAR0 fails, release the already allocated PCI memory region, decrement the device count, and return -ENODEV. This prevents a potential null pointer dereference and ensures proper cleanup on memory mapping failure. Fixes: d19770e5178a ("V4L/DVB (6150): Add CX23885/CX23887 PCIe bridge drive= r") Cc: stable@vger.kernel.org Signed-off-by: Wang Jun <1742789905@qq.com> --- drivers/media/pci/cx23885/cx23885-core.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/media/pci/cx23885/cx23885-core.c b/drivers/media/pci/c= x23885/cx23885-core.c index 0892a5fd137d..98878b6a448a 100644 --- a/drivers/media/pci/cx23885/cx23885-core.c +++ b/drivers/media/pci/cx23885/cx23885-core.c @@ -990,8 +990,12 @@ static int cx23885_dev_setup(struct cx23885_dev *dev) } =20 /* PCIe stuff */ - dev->lmmio =3D ioremap(pci_resource_start(dev->pci, 0), - pci_resource_len(dev->pci, 0)); + dev->lmmio =3D pci_ioremap_bar(dev->pci, 0); + if (!dev->lmmio) { + dev_err(&dev->pci->dev, "CORE %s: can't ioremap MMIO memory\n", + dev->name); + goto err_release_region; + } =20 dev->bmmio =3D (u8 __iomem *)dev->lmmio; =20 @@ -1096,6 +1100,12 @@ static int cx23885_dev_setup(struct cx23885_dev *dev) } =20 return 0; + +err_release_region: + release_mem_region(pci_resource_start(dev->pci, 0), + pci_resource_len(dev->pci, 0)); + cx23885_devcount--; + return -ENODEV; } =20 static void cx23885_dev_unregister(struct cx23885_dev *dev) --=20 2.43.0