From nobody Mon Sep 28 19:23:42 2026 Received: from out203-205-221-236.mail.qq.com (out203-205-221-236.mail.qq.com [203.205.221.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3E4A46EF84 for ; Tue, 18 Aug 2026 13:10:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.205.221.236 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787058632; cv=none; b=GW9hEQ0qQYNM2B8y5ZQYpBTWDSao/sLueScQC42U6A4LPVxhniiazMs8Nc5sVT95vOVtfoc+DOUmMmrKxabf77Dt6UWSTVKkHGjcKV0KnHVid36Pcs62FiybEoPZd4r54yG1z7Y8WgDw3q5bicgaixejhgrLzfsnRvjkfWZnNNU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787058632; c=relaxed/simple; bh=cmBoZua4ZPQei5fRUS4o32PFCk6Yj07d0y+VuBUlIt8=; h=Message-ID:From:Subject:To:Date; b=HrLKVojKH+uKMoBN45fpk4MfMCGYSYXFuNxLfvDV7SRXn2JzpqpdLz593328oqaOAYXL00Pm3Xn7GK+4FqGHaoAweFhvInIEemgfPG+BAq8+TqOEiOn0yDiA1vG8diVwYM4KFRuJI4/igv9WI6A7Fqxlt8OVme2cm8V8V2UoQos= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=qq.com; spf=pass smtp.mailfrom=qq.com; dkim=pass (1024-bit key) header.d=qq.com header.i=@qq.com header.b=CAMe5+bX; arc=none smtp.client-ip=203.205.221.236 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=qq.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=qq.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=qq.com header.i=@qq.com header.b="CAMe5+bX" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512; t=1787058627; bh=2NhmVga1InGwn8ASHqgBs7FKmeC8BxhLMZyrz+2ubOk=; h=From:Subject:To:Date; b=CAMe5+bXhJYQP6ecrat3DH7kq2L2J1LyDSrmCjFbrHeaZdgkRyr7BXBK4ehJG1IY4 QKnZCyyZzGGimLSD24f6BRn7RL0CF3D82moYVeLCk4JqE/uzddIH51mMusvSpYd+/r wNB4J+WYu25yGs+3OVQnJ3CHmHnv4q0mFkIaMc0o= Received: from [127.0.1.1] ([5.195.0.150]) by newxmesmtplogicsvrsza63-0.qq.com (NewEsmtp) with SMTP id 1721C6D8; Tue, 18 Aug 2026 21:05:50 +0800 X-QQ-mid: xmsmtpt1787058536te3wxsygg Message-ID: X-QQ-XMAILINFO: NGbyafB8LluuHu9gt6EK+9u9GdZI2j8XtIgCY9SgTcDGBZL4hKcJ+pZ5UGcEvJ CukB5ZJmk5qyI2+IbVIDIeYSxQmj9asSdKKPUOPgpfDwGfFy0BNudLkUv+H7W27cw50E516Y9r2g R4frUwi7VAOA5F5zouGrXRXrIGWmspGM+hcWnSufGZqX3PBzrif6roem/BJbvpN5D3PSZZ5TwzTP lgFAnzMhkrKH5qJHbHaLmImk5HBQhbzaawMdw5J7pV1riim7Wv85hR4nmTVA59JuBvDqjM5gO04G Nx1zoNJai1kopxtkJTDyoTYvoeTCC32u52e01ecQdTNqs+vYtC4fMWVg9tctMsbWOHTRubobtCbv BRFH9Wf/moBaeLcBo9jDt3WXa8DOByca2+0AX5ME91pgnDlSdB8detOYh3LiKYOijLU87TnB6NW7 7C7q5dubwuguGRkjBuouEkPkdCQzrINeAHGTVJYn9eb1A3yhoQO9g18TBr38a4dZJUxjkWgOewVW fCSDUj06Bf9w3uOaCDF97XSmeS1JGa86yK9GdtGNStdumhNrm+I/iqKVloEeg625MSjnZ0gXaWGr LijKGkIe49bk8nQu1+YaWi6lGKrM06ui1xWU8Ea5QtxCFtHlpPVDBTmzxpKG3cKq1M/t7NUexmgs 1Zcs2CbyhfdokL7u0GSyuVHcoqYCyjZNbLEyJC4xFs+WCPiQIxvB01wK/R0PXYwIDZllo8nfWMHa bKd83yJsR/r5O1F0mhoTb57sZhwS92m7cAMYaaidj8mFbT8ohZi3Hl15Nr2BkPkM5HcD4TuI4vKd Lij2iX8Lbq/59VNIW42zlB+691aPDXulRn+KNmrp4OjPWvO9p2HlpFydc1iH29qDCvRAxU2Fy7N/ AnZ8XYT00xxTxVCGftsymFUu5zlooPrAnlJwyNXvHmhmmshmtWRAYxGEGHqnfJpnHPV3W00UUKZm zTUkeICSvrLsPhYwTYCRUSNLwCRbrvMPv7X1nEiTIzAptmYPUJJ4A1GvGYxnpul9y+guvguZDqjk sz6wuqc49ziH/9AJ0LA1WzNI7ZiRo0kjbInVU4w8mztAaZu86QB1DSOtsZgxw= X-QQ-XMRINFO: Nq+8W0+stu50tPAe92KXseR0ZZmBTk3gLg== From: Jiawen Liu <1298662399@qq.com> Subject: [PATCH] rtc: rtc-pic32: handle clock enable failure To: linux-kernel@vger.kernel.org Date: Tue, 18 Aug 2026 17:10:26 +0400 X-OQ-MSGID: <178705862645.291840.11368647570601508871@qq.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Return error from failed clock enable. Pic32 RTC ignores clk_prepare_enable return before hardware access and later disables/unprepares clock same pic32 RTC unchecked clk_prepare_enable. Check early clk_prepare_enable(pdata->clk) return in pic32_rtc_probe. Signed-off-by: jiawen <1298662399@qq.com> --- diff --git a/drivers/rtc/rtc-pic32.c b/drivers/rtc/rtc-pic32.c --- a/drivers/rtc/rtc-pic32.c +++ b/drivers/rtc/rtc-pic32.c @@ -325,7 +325,9 @@ if (IS_ERR(pdata->rtc)) return PTR_ERR(pdata->rtc); =20 - clk_prepare_enable(pdata->clk); + ret =3D clk_prepare_enable(pdata->clk); + if (ret) + return ret; =20 pic32_rtc_enable(pdata, 1);