From nobody Thu Apr 9 05:47:46 2026 Received: from out203-205-221-233.mail.qq.com (out203-205-221-233.mail.qq.com [203.205.221.233]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FEDB3B19A8 for ; Tue, 10 Mar 2026 12:11:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.205.221.233 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773144686; cv=none; b=fbDoe/VfYx9eyd4al7QA6P29Hhqhb7YqFAZWOmQtCpvPN0/I2H5xpC4WyEyIbJ8taALY0QRb16TTmHr0ND64oSgfeNkhB1xrXjFeQwZqIRBFKHYtCE1NmCEdiHF03BuTGJi4dKY2opGJz5NWbYP9hSOnmSd6XW+wZrZ8e5p2jPs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773144686; c=relaxed/simple; bh=597eIuKjklfrEqhu7/4Y7RJJr2JdzZ5KPhyXXKKIcE4=; h=Message-ID:From:To:Cc:Subject:Date:MIME-Version; b=OK9Y8yKJVtBgE4c3OStCTPmGVyGnh8CBcm16JEDommqLehsWZX/jHkfOLkXxuMSbAuBcDEspB0H5qX0u1Og7sd5wwDJuZ/g5MjBjEz7v4QKgOMwch2eElMmpnEMd848ETAI/37lk8DmjFKHnQC9UaUTq8hJi0NCnL1LWd8lWD/0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=qq.com; spf=pass smtp.mailfrom=qq.com; dkim=pass (1024-bit key) header.d=qq.com header.i=@qq.com header.b=iZOBWadU; arc=none smtp.client-ip=203.205.221.233 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=qq.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=qq.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=qq.com header.i=@qq.com header.b="iZOBWadU" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512; t=1773144681; bh=dAaAL2bSaHFST8Z7y7B5rVa7Pqgb3PRmEPcRCp/FoW4=; h=From:To:Cc:Subject:Date; b=iZOBWadU9HQUupzCULzgof97sJeTGwEZStwV3dHyKW7zz689kglZ2MKKnVun3ZLfN nI4bNaq5swOLMjcVmSuTt1KYrC27buA4s3lc1abZbAIzg9BLNKp4+d+WWpSUbXbI6q IeQieKut+UNgmnra3naqj5nio2/8dltExSuC8Rnw= Received: from June.localdomain ([123.121.145.35]) by newxmesmtplogicsvrsza56-0.qq.com (NewEsmtp) with SMTP id 2D22C8B4; Tue, 10 Mar 2026 20:11:18 +0800 X-QQ-mid: xmsmtpt1773144678t5qus6dj6 Message-ID: X-QQ-XMAILINFO: OVFdYp27KdlJBOgVfCMaPom1z1vdwQSoYB1zGpFNKYpnXZmwXGoubgpCDvQClD joVU98FQEheYN78vjc8/kNxRrDf7yWqDNYcuDV+Ddw17EqXPyHMIYLFy2f4qAobGbOmtKXODuJCo n2SbtZ3YmvccWa6+vuGoo1ZZWmVBUK4A6K3ui3HL7ozotj+qgesAnXJZ8RWe533ym3V7mAM4t8En 01O7gAitaotAN2/ljZc4B5mg4k/G0cP86SGDqzz3u9YlEemcguUESI6SJ34Q7i+tBdZNC9GMlSxx GoPYs64mk0pyDc5kdJwyPrzZG5t5Vd+MnMOilA4tVpG9biqCIMBgmweYvRZOdDETi0U3ghJQ3Qcg dq5+2lBMh+nZvXMJbNgZTLXFT16RHPwcJhhYEqhHMC6GClhS/K48wFBkOBJUeZNGrwBbX3ep72mn p+PWIoXMVRQy4ogaAA5Imq9Fx6Ms+DP7Ua6sI58T/P/8SyRFe9qZl1Jchc+qLZOV8MrFCfmGivmr boDQ4TK6kF9AIDxIuJl65doHM3fYCQlyzvwnxfY0N4pR68kcfmzmKPBYxZqjnGFmMZZw5DdNvgUL NLKsSdCDlE/RT2jhG/9neuL9IzXkNz9LpoUwz+2jeWo80Y/XiITymbVlPUCQcd0KCMxFufwDjdly SxASAOxuK9gER8iW+Mknal1aH6GDN9/iWhzkQwEJ7LnZ0hyRZTHwek+i4nAiRAUnz5BF9LRjkndr qf9zxyBGLFJqABAPd+B8p+ng50xsaqwq3iLrBheG6BQhGmdoXY988tpoin1ETEqUyxQKeFziHdE9 ZZIdK7Yk0rB+x24Pvtnwn4Uh9v1FHMZLz9dabK/QMbkg9TnSvDBGxF/om4AWb+vw6/V1CNNRoboK sYkWhmrxK7XRFwaw+b+OZMahMYt4ohFSeX8jpySl+zfOejl5pd8mltOR3BaHlPoxbMHQP/1IVk6P rppfGd+0UCJb6eVU61NYVMuvwgN7Jj5ybEhsbsMZF8/VrrKaLjU/3UEKrUdnIsSCj8biywlcjHgM hQd+Vc3HWWpgUUCbSzO3JMHVR65i4iP/h/i5FTp0JwCLdCo3BB6oLSmKPg2PZNFUA4bLgXCg== X-QQ-XMRINFO: Nq+8W0+stu50tPAe92KXseR0ZZmBTk3gLg== From: Wang Jun <1742789905@qq.com> To: Qiang Zhao , Christophe Leroy , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org, gszhai@bjtu.edu.cn, 25125332@bjtu.edu.cn, 25125283@bjtu.edu.cn, 23120469@bjtu.edu.cn, Wang Jun <1742789905@qq.com> Subject: [PATCH] soc: fsl: qe: Fix potential NULL pointer dereference in qe_reset() Date: Tue, 10 Mar 2026 20:11:14 +0800 X-OQ-MSGID: <20260310121114.34906-1-1742789905@qq.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function qe_reset() uses qe_immr without checking if it is NULL, which could happen if ioremap() failed earlier. Add a NULL check and perform ioremap() if needed; if it still fails, print an error and return to avoid crashing the system. Signed-off-by: Wang Jun <1742789905@qq.com> --- drivers/soc/fsl/qe/qe.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/soc/fsl/qe/qe.c b/drivers/soc/fsl/qe/qe.c index 70b6eddb867b..6dcfa340970a 100644 --- a/drivers/soc/fsl/qe/qe.c +++ b/drivers/soc/fsl/qe/qe.c @@ -86,8 +86,13 @@ static phys_addr_t get_qe_base(void) =20 void qe_reset(void) { - if (qe_immr =3D=3D NULL) + if (qe_immr =3D=3D NULL) { qe_immr =3D ioremap(get_qe_base(), QE_IMMAP_SIZE); + if (qe_immr =3D=3D NULL) { + pr_err("QE: cannot remap IMMR\n"); + return; + } + } =20 qe_snums_init(); =20 --=20 2.43.0