From nobody Mon Sep 28 07:19:28 2026 Received: from out203-205-221-221.mail.qq.com (out203-205-221-221.mail.qq.com [203.205.221.221]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2AA4B330B14 for ; Tue, 25 Aug 2026 09:00:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.205.221.221 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787648456; cv=none; b=mJrAmzFevmIEgmvTeXNS7lX53kN8z+ga0t/DeRFxf2tlxo7JzDZOJ34ZuDU1bpAl6V9uuqV8Hl33SIbesPB7441lMMLGYLHYp3SWtRLnLHOCrW5QbaQhK3mJKnZSm5JzFSU8s7T9w6gFWnHKopiRVeZGPF9iIePyjCqSwtYpvkE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787648456; c=relaxed/simple; bh=dfG8wOJ5jcEThCIvNKzZ7GqPiZQewlmzx5jBy9jrXck=; h=Message-ID:Date:MIME-Version:To:Cc:From:Subject:Content-Type; b=h6hIeLahXcFWwSq4qbsC+nRVt42GGh6c6eWDzsoMJIFcDCOSis6X7LYR2LPTeuIuNSzO6Ylm7ZXgjRtKouf2fyipB6qUEU++8ar2HNgIyLTUPgyV/ri1RNdSxOadA8Nq8PlcEX5hhRSCFdWQDCm8K3LDZGXw2wo974AqAvIBAVs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=qq.com; spf=pass smtp.mailfrom=qq.com; dkim=pass (1024-bit key) header.d=qq.com header.i=@qq.com header.b=fRvcNZI2; arc=none smtp.client-ip=203.205.221.221 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=qq.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=qq.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=qq.com header.i=@qq.com header.b="fRvcNZI2" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512; t=1787648445; bh=dfG8wOJ5jcEThCIvNKzZ7GqPiZQewlmzx5jBy9jrXck=; h=Date:To:Cc:From:Subject; b=fRvcNZI2v+AhOvQbkQLZCpzjlFhcekmuU0FFhIXpKC9Ucw2ycOeMnVW9QpuENxyWv FAiX7ujrdJellDLESiJAEWNa+HcFgy9J0cFw1W0lwYtmrSRnIz8xvcakxK2gtKYPeu w17n0uD2uSq7eV3wYeNHVcuuV0i3sZqfXLR8S9Hg= Received: from [192.168.255.10] ([111.206.145.19]) by newxmesmtplogicsvrszc56-0.qq.com (NewEsmtp) with SMTP id 2B192A4; Tue, 25 Aug 2026 17:00:43 +0800 X-QQ-mid: xmsmtpt1787648443t3rcj8cad Message-ID: X-QQ-XMAILINFO: N0PTwYhxbheSwGHYLAcPN9sTXmSyN2fjd/huIF/Vk0A0ZksiGDJJnfdhOQVvqx FHNj1BtKQlyykvjedOtPDa17VC3CGCThr4yVUBOu2yJHPnMaFHZtRu0vQv6qZge05J2tnOUlm+eQ WgVDd1IhMf+laSieo2e4O8swORnTUlYXQIEhOTOOlBI2I3I4AlsluhigO7YLFXQ8cLKT1bi8NQM6 I73NGb8pkZ0XqILphSS0gXDtH2UTBjybzhJTIA12d4XKA+ydiAKvKy8CfuwlKFzyYBnrnXw264wc Z0/q6KeMrkXub47CbnyYSpYf/0IiLNnsYJ6l+d0CMhdW/561hoKjl7CsOaOGup5iAbG38mDtqf5s zTfnzo3814YDJXpxg0t+6zzOPvTcBVX/NcV+cLVP2zVzOOBvcWWnwrO9h5BICx5MUbd7FrZhb6bQ jfWoYsscqMDcx5CPy8TnCblxxqmsDV58ptGfSdJ5K66xrQ2qdwDuiXmS5lYpoamBfxL2ANtOARvd KDlTNyTQFi+bxvcWCivo13TiKNit4rJuoy8ELR+O3deJwrt17QqTMMUmD5PpA673UJtff51P3+LS gR4cNv5TpUS6d53mQjLLQI2KfEkitcXAURZWkfdb/8cIm807i69j3Y/vIoDiShIbzmS+vnaGH390 niCm4CZuOP24gjUg0mU8CJxi8/BjNrcqH4i1oK/Ue7VoL+XeVX6UkGSiQWeWxpCe52WuMr3oYvAA abGM4q7S09EWgvQIeqYkvbxj9OWMA9KAf2oLAYzuc4nQSkRQLcjHp77v0KB0FLjlxdhhvPbHsPK/ HcbwLjOm5gDVRICfrPyw2weQ+SnTrw8IPDYzzbJd133/sJTothPK9lkQrz5dEvl9aD3wxL61jCrp vO9t/vOV9vsJuwszmtbxuQefndxqgjsrt8ieGL6/L5BeXhcTndtlA61JRB1IuU1pagdOQ/5H2RQr 9MdA0pmc3q2WZrj8ix+4F5OYy0SXln0u040oSwHRidjxRDO784BR4PcNg91F2GGg74djxstIKWbt V6jK/jTyMAhtTCoRfgpJc0GAVjQw7YA3l1kvsfkxsCxqZ+NHlLmiJGGAo+rjaQjSPNo8sBx5dFRZ Db7f0y9EUMmnUos0li1n7WgtQREiIdlFl4OsaON9YCFufAkhmmhWLWsc+wlw== X-QQ-XMRINFO: NS+P29fieYNwqS3WCnRCOn9D1NpZuCnCRA== X-OQ-MSGID: Date: Tue, 25 Aug 2026 17:00:42 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: lgirdwood@gmail.com, broonie@kernel.org Cc: linux-kernel@vger.kernel.org From: Yang Zi <2959243019@qq.com> Subject: [PATCH] regulator: max1586: Fix NULL pointer dereference in probe Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable max1586_pmic_probe() dereferences pdata->v3_gain without first checking that platform data is available. When the device is instantiated without a device tree node and without platform data, pdata remains NULL and probe crashes with a NULL pointer dereference. Add a check after the platform data is resolved and return -EINVAL when pdata is NULL. Signed-off-by: Yang Zi <2959243019@qq.com> --- =C2=A0drivers/regulator/max1586.c | 3 +++ =C2=A01 file changed, 3 insertions(+) diff --git a/drivers/regulator/max1586.c b/drivers/regulator/max1586.c index e5cbc09c2d39..de7840a58638 100644 --- a/drivers/regulator/max1586.c +++ b/drivers/regulator/max1586.c @@ -222,6 +222,9 @@ static int max1586_pmic_probe(struct i2c_client *client) =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0pdata =3D &pdata_of; =C2=A0 =C2=A0 =C2=A0} =C2=A0 +=C2=A0 =C2=A0 if (!pdata) +=C2=A0 =C2=A0 =C2=A0 =C2=A0 return -EINVAL; + =C2=A0 =C2=A0 =C2=A0max1586 =3D devm_kzalloc(&client->dev, sizeof(struct ma= x1586_data), =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0GFP_KERNEL); =C2=A0 =C2=A0 =C2=A0if (!max1586)