From nobody Thu Apr 9 09:03:35 2026 Received: from xmbghk7.mail.qq.com (xmbghk7.mail.qq.com [43.163.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88EBC269CE6; Tue, 10 Mar 2026 01:14:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=43.163.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773105280; cv=none; b=NNdzfKclWeGZDQtvKec3IcrV/0T6CfxkJznlTGSZSh0TqMajW0Qoq9OUoakMvKK1MIiEf2k+zPtsrXxJJC6U9/k/ww2NGhAyztnBH0+H9SO+Sv01S+LsIEfIBr/6kC0W8rtT0Clh1woiW0azsI5dYtw8UJfjwJgQ93MLcpwEPHs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773105280; c=relaxed/simple; bh=ikLWKLR9UX5av66TuqbzzvZKNipcLCat+JFN0c79Wfg=; h=Message-ID:From:To:Cc:Subject:Date:MIME-Version; b=V9Q6/L563CcsOqLMkrQU8rZDePMuAvlGyzXZTWTWpX2BV/vqinC4+aKhaqB3B3ldyyO2RG+VLOg9uWj1sIdlebGPGJXEvI2Qp/s1fDROCDufk1aTUW8ElcWZaMnSOsqgL0Q2SW+LimmXMha+PeLLS86FtxVWPdhXbDqcK69JoP0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=qq.com; spf=pass smtp.mailfrom=qq.com; dkim=pass (1024-bit key) header.d=qq.com header.i=@qq.com header.b=anzuCJid; arc=none smtp.client-ip=43.163.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=qq.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=qq.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=qq.com header.i=@qq.com header.b="anzuCJid" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512; t=1773105267; bh=fKN1B1R1uGOi7aCqLWWpClnJb3rwC+frVI631Jx0TJc=; h=From:To:Cc:Subject:Date; b=anzuCJid6yDMmyFsOKTuVozL6DimfPA9GnwVTGWDTY+G+DOI+X/CjLaM7vpn8VPUZ 3U2OL660sETDZ2KmVwCgf12dAuur1hIBVmV4hS3kSpLtz1JXwIHgaKdsSI87oPC8jy qPcNYCGFvTDPHqnXOOvaSItfVKGse1ZJIt19ticE= Received: from June.localdomain ([123.121.145.35]) by newxmesmtplogicsvrszc43-0.qq.com (NewEsmtp) with SMTP id 3983A430; Tue, 10 Mar 2026 09:14:24 +0800 X-QQ-mid: xmsmtpt1773105264t57xncli5 Message-ID: X-QQ-XMAILINFO: OOyEews/EdUgX9pLo+jdYMbZkVK9uYEzTviH8Ko+bNNQ+MB8HFe4XY5qCSRAIM x8byOBC326ooghxICe+EEUk53Dui3B6oQJ3/ffLPWfglQ6leLBzHFmN0+vuqXZyxPe4nXg0ZuP2S bO22nYdBgCHCkX3oB0/wYf/3C69fa/1E6ugW91Cdx0otogiW7UvSZQyFI8gsMyToVVHEGWqGz7Lo 79osq9nPFoeC8Mauib+kwEQxEZRIPX7TljqWcNFFNKqWmxtXLDfoXP2wz904l1RsosrYOcsuE/Xa s95Nqkn5f9HvXFYXAXNtaxgvc+KuEEkIVaOL4ytLsLDVHDHb4VdROc2WVyLn25b8Jt0jUxLyP9hy RP5RUKhwegfHqJQxmFM4ogqHoWGD6dE7vl3JLv9SxvSI+3KIQzrCtAFgkDZYNYDNPKQkoNx8ChIF Crz9KIee26pYXlsOQRUl7UByegoXac9bCxwaFex0BqMpQPSfd0NiOnO2LCpyx9HrPixVQJJ3gJnl FTNzOBQsCiOt+YEqlkueuiMT/Mf//g9Pub7j4h0jrQgCJIjByIjoOvn5CFwVd0Z8cwsIPOjiIeSp P68iFDijxB/INICb89Kz3d55J8HabKOP1v/KUjreUnxmun2trDVuJdYPaDVMolfqGcx6yjGQ2yNM zj5ynMEIVSZ48WXF69Gi/6qJjqyRwOfHggh9KK7JMM84q+LghMcXhdeKKJ/GKEe8cEEiSR1fHKfL NjzJiY2/HrIehHGpIP1CkdmYK3YelLkNg5RN72YlfD/WaDfnEYJr2v6VdpA1KRXjBTQShEPVizpe QywQBYjNk5jfLjrKd24mP5CAwWT9TFEuny54GW1DSnxpIivmLRZii83k+5uOf9nddxZZ0QFLZxAx 0RlZbQKXw1O2YEv/pdAFYb7HH3UsbNB3Ta4PwipsALA/xr/j7ca2b//RtpMl4uijMv6voySqrC6X hJx9gah7krHYP4APJINYv6JumOuiNkmLk4iBLIQsjKf3hJuhkSluKEmH8yE+COIhb9ST/a16vf7u pVxIyS0/G+7r3WdSq9pGLC24rNj+I= X-QQ-XMRINFO: NS+P29fieYNwqS3WCnRCOn9D1NpZuCnCRA== From: Wang Jun <1742789905@qq.com> To: Florian Tobias Schandinat , Helge Deller Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, gszhai@bjtu.edu.cn, 25125332@bjtu.edu.cn, 25125283@bjtu.edu.cn, 23120469@bjtu.edu.cn, Wang Jun <1742789905@qq.com> Subject: [PATCH] video/fbdev/via: check ioremap return value in viafb_lcd_get_mobile_state Date: Tue, 10 Mar 2026 09:14:20 +0800 X-OQ-MSGID: <20260310011420.8844-1-1742789905@qq.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function viafb_lcd_get_mobile_state() calls ioremap() without checking the return value. If ioremap() fails (returns NULL), the subsequent readw() will cause a NULL pointer dereference. This patch adds a proper NULL check after ioremap() and returns -ENOMEM in case of failure. Signed-off-by: Wang Jun <1742789905@qq.com> --- drivers/video/fbdev/via/lcd.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/video/fbdev/via/lcd.c b/drivers/video/fbdev/via/lcd.c index 8673fced8749..91359d2b64fb 100644 --- a/drivers/video/fbdev/via/lcd.c +++ b/drivers/video/fbdev/via/lcd.c @@ -954,6 +954,10 @@ bool viafb_lcd_get_mobile_state(bool *mobile) u16 start_pattern; =20 biosptr =3D ioremap(romaddr, 0x10000); + if (!biosptr) { + DEBUG_MSG(KERN_ERR " Failed to remap BIOS memory\n"); + return false; + } start_pattern =3D readw(biosptr); =20 /* Compare pattern */ --=20 2.43.0