From nobody Wed Jun 17 05:15:36 2026 Received: from out162-62-57-137.mail.qq.com (out162-62-57-137.mail.qq.com [162.62.57.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E5D035898; Tue, 28 Apr 2026 06:27:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=162.62.57.137 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777357633; cv=none; b=RJEiPLnKi6s0GX7+VOV5PdkGFr0lp12D2FtNP5ri3/TpWwUcPZsd7FVr8Mf+8/Utm1TcT1Dv+55+TCH8PJA+i0Bgir0bpzTwxnWvIukI+/GhuRRgMFK4pO1+dp8LsEp2vZyJVQ4TXYPF/DR33XlyV1UGRkBk8Y5VDggdp0agLgA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777357633; c=relaxed/simple; bh=KsIAmnLob4ZTTe48Ql2J0gkqKjtyzI7gwllEBYwAv1Y=; h=Message-ID:From:To:Cc:Subject:Date:MIME-Version; b=IdEoQI70JXhUZchwOhuObCAepC8woOgEk/zrl99um+iYQwHXjGRrA+Z21qFkz0wUpX4RE4VpuFeyId/cNWOgBWCVWXJuOaJWY9oKaidTqxUz6pmhBs2yMv+6dqeLxtk+RTIlwc4D1+e/obMuYvBqQU7vgNfPu37vF0+HHYJiT9E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foxmail.com; spf=pass smtp.mailfrom=foxmail.com; dkim=pass (1024-bit key) header.d=foxmail.com header.i=@foxmail.com header.b=hGWQ0HE3; arc=none smtp.client-ip=162.62.57.137 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foxmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=foxmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=foxmail.com header.i=@foxmail.com header.b="hGWQ0HE3" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1777357618; bh=bh06cfQ61YF2IrXdjHDgvS8aqVFo7eN3jtbRKO4oJL0=; h=From:To:Cc:Subject:Date; b=hGWQ0HE3VmH//TwaNNvuMAUOhNy1uQGRsoMilsoNvX3xCBLrpvmm4CgtwiPabXjGU QepGCWa0IjmMnFuq6ng4ry3TX9bEhYsChbGf6Ipw75t0voE/cIRiEcC157lYKMmt0B +SVTIFiPQivnseUYP8jJD7vcBRS4zs127Ksd+kwU= Received: from xiao.localdomain ([223.73.200.233]) by newxmesmtplogicsvrszc43-0.qq.com (NewEsmtp) with SMTP id 6B699A2B; Tue, 28 Apr 2026 14:26:54 +0800 X-QQ-mid: xmsmtpt1777357614tma2lu1im Message-ID: X-QQ-XMAILINFO: NGZp1yYNf7Y+/TTNrQSMJgix2+vW821Dulk8tk9pKkj0nT5kbns+yf0076v4WR pzgd5eKWzKhfrk7Ow8kxLZ3TXW4wpzQ6iZDcvOyHGijalx9hQwMac7GtKH+3qxCp5j3xGP94pdmX jKS2SLm69GR0DOj+miYpa4ATZ/KM6QosbvxKDYScSFLb7lV1Rohomv8bxqR6juHD1DQwr9IDrD0R CBef7IMRa90RQjuDEgMTpkdgD+mlptTvOylUDTVKMpZzXFxJBxjyRo7eFlOLc6+o85NoTDDxXrje 2IVjX4CkfB1Isvlevtdn9dU82yYRPMp7APU8PrL7kqn9+mjv/tnQJ3iNFMDf0AbRizBw/sfccyJj Nf+QsTruy+sp7tB0koFIcy6XVpAiGWYKWW4tAJuF1vmiNL6/ebFOmnZOCG0Mu5/heaWEoIkHXhdG 2cf4VOheXsjr8X6I/eOeu3VigAGKCU+T/+oytSaP6GjJnG0vPR6qo6X53UEw+Yvk7bi+Mb/OkXvU WdJDvdwWdFqbeS7rMem2hePHWtQ/9D6zUtPb+JfhONBggRXeDto/fPkpfX71Ei2GaEAa0B35F1KU ZojTdGN9C3QYz418k8Trc8TCwyZM24p9jldBTIZKQmVxov8A8wlpsYCfUoY8/Baez0sxcOcClDYG uuSxzIBwUCqmOiMn/USYNunt9wPJghYzGR89VOGdfAfFIzqAX9HdwJbwiIC75fn0Yaqr7RsBZs3M aY64oXH9Yv8kAn7KUz9imV7fqO37l/Ev3dwsFF67JHMKcvFjKiNqxqgQ8mun4xRAj3Rd+lq6jol7 9tRSt3UWnnYEAim1+18he3JAV5Xv3X9OWXbkbCNpinqZl4mJUVffanmjXKwjs7VzG6kln9yaQzEZ X6mgNcpePc3COCPY/Pshqx0/m0pLKk5DopTPxwlLXHXBOpd5sCHFT1EnNtBO8L8IXbHaUnEmvDjk Cgbmxe7RshBnj0JAgvkojB+vroRTt3eGdKV8ERxJM4jaF3Bh2WauK50T8b359Gaurb0fDwLjnjSv MrCPJrsUK3d3Vcg+Ne+sVG1cpxtiDtGRxnOp57NOYqpK3bRl7XfQ66dcZd5FrN9lRToTVToww9hp dTE7US X-QQ-XMRINFO: MSVp+SPm3vtSI1QTLgDHQqIV1w2oNKDqfg== From: Li Jian To: linux-kernel@vger.kernel.org, broonie@kernel.org Cc: lgirdwood@gmail.com, loongarch@vger.kernel.org, chenhuacai@loongson.cn, zhoubinbin@loongson.cn, jeffbai@aosc.io, Li Jian , stable@vger.kernel.org, Jaroslav Kysela , Takashi Iwai , Zhang Yi , Charles Keepax , Kuninori Morimoto , linux-sound@vger.kernel.org Subject: [PATCH v2] ASoC: ES8389: convert to devm_clk_get_optional() to get clock Date: Tue, 28 Apr 2026 14:23:52 +0800 X-OQ-MSGID: <20260428062425.1377-1-lazycat-xiao@foxmail.com> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Per Documentation/devicetree/bindings/sound/everest,es8389.yaml, this driver does not require `mclk', so the DT node may lack this property (even the example lacks the `mclk' property). Therefore, the driver code should handle this situation by using `devm_clk_get_optional()'. Indeed there is already null checking based on CONFIG_HAVE_CLK, but the driver will not finish initialization, as previously devm_clk_get() would just return an error pointer. Address this by introducing a simple conversion to use `devm_clk_get_optional()'. Cc: stable@vger.kernel.org Fixes: commit 0319c26889f7 ("ASoC: codecs: add support for ES8389") Signed-off-by: Li Jian --- sound/soc/codecs/es8389.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/es8389.c b/sound/soc/codecs/es8389.c index 8d418cae371a..449d9574b03a 100644 --- a/sound/soc/codecs/es8389.c +++ b/sound/soc/codecs/es8389.c @@ -892,7 +892,7 @@ static int es8389_probe(struct snd_soc_component *compo= nent) return ret; } =20 - es8389->mclk =3D devm_clk_get(component->dev, "mclk"); + es8389->mclk =3D devm_clk_get_optional(component->dev, "mclk"); if (IS_ERR(es8389->mclk)) return dev_err_probe(component->dev, PTR_ERR(es8389->mclk), "ES8389 is unable to get mclk\n"); --=20 2.47.3