From nobody Wed Oct 8 02:02:18 2025 Received: from out162-62-58-69.mail.qq.com (out162-62-58-69.mail.qq.com [162.62.58.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC0D428DF20 for ; Thu, 3 Jul 2025 04:58:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=162.62.58.69 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751518715; cv=none; b=OwZ0f1pc7Ss3EtARTziI/aWdt6rj56fSbZRbdx1yGy45H3anuNhAEGu8SHb/LStgITR2hy4bPWEj7vkzVW5402V50Ra9s3tJ4hKFPMHwsrLo67AXZP3FQGbd/flXSi4AGohi/L612yvReitGDINR93Z/QKmMCvsSs7XgcFm7Fxk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751518715; c=relaxed/simple; bh=J+IYp9jcZdc1FY0DvzsgVosWeeClBCVHm2ukBDFdTuQ=; h=Message-ID:From:To:Cc:Subject:Date:MIME-Version; b=rEn56HY+g8KhXJSgWlbIqTyFnATsodedFpHXZxlGF4Zoh0vFRbi3bWUa4Fid/5FiaFu3QdPR8boZXpMbWEzsEgjhAf/vztqNEKgLngCj/oRxL7mczFPX0YhJmehUycREeuURkv19FNyq2ukIphMpPrk/YMiRZwcvAKjWG0DTxSo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=qq.com; spf=pass smtp.mailfrom=qq.com; dkim=pass (1024-bit key) header.d=qq.com header.i=@qq.com header.b=py68uFdk; arc=none smtp.client-ip=162.62.58.69 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=qq.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=qq.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=qq.com header.i=@qq.com header.b="py68uFdk" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512; t=1751518706; bh=F+ILISzDjtPPxv3dgfZUBuIfwYunt431F1PsflXRPJM=; h=From:To:Cc:Subject:Date; b=py68uFdkN89y6N4kmuQbC0RXu40W3QxreBexCjtI45pj9rD1ASV7DtImJWaxLdTz6 FgldKvVTtzwCzJ5kmtXzSA5JbVGJKebnGXjHkawj6e9SYa/yoe+d1VFtKyttJuQBPE VFNFkN0enawEdfmw2Uvhf24Z/BR3kC+HO/QJMJvk= Received: from VM-222-126-tencentos.localdomain ([14.116.239.37]) by newxmesmtplogicsvrszc13-1.qq.com (NewEsmtp) with SMTP id 9E327C20; Thu, 03 Jul 2025 11:39:35 +0800 X-QQ-mid: xmsmtpt1751513975trlfmosn8 Message-ID: X-QQ-XMAILINFO: OEnxXf6IMmheJ7ACWL7UaaRa8R2XU0uytHp9G+VfxLWKLXqiLR0EJcNmnngBLa UyD99zyxTwuxpuZaT0E9S6jYVq+Rj7ufMP7AYRjbLCFVwlDFeIae+t6y6ITtyJiW4h3gWhhyvbI7 zK1imbEOGJ8Rtzh7+ZUWYCIqXRYbCWTdp2yDVnWGG+8ZqUmylc/MPwCKQ3MLVo+Cu1aUFqxLAY0D FXRfxjnx2dBBUhKJnVw6R/9ghxeMXbYi24sLdP/BYsUSykWcOli+KOOrx+sui4d1usOWMActFjiV HPNlLjvIV4LqaYH0eMl8A8ceOvo3f69kwCXN938j6BGKQjvwa++XNdLrygakREJkivRhowkRnp0x rr1A+aEf+Lqiub/fa2p3396BGJkHvgeXnvuA8pGEHsTEvlMGLLWDveLnEzC7dB9xYgfJYvQQ9oCP lCWAihZFX42H3qZEeAWPBxI3z8p+xiY73eatQZzBg4r6QC4Hg2SW3lvigq57s/Tx/fVVL/6qCaNz ta48b1UusOU+X9lRqibTE/v6ECfho7Pq4d2bpnSvKksjOxNvMVbEMTnwbf9rmmIzDLZ4lWLJnv6w UowmV0XYnomiN7sZjyd0Qszhyt6ahnMh5LhbBEDkenQIuLc2S2qkis3A/WJwl8PZKlkQ2qatVBVA eRNMVYsLvRMwiMSQenu0Kpkmu3lJm+oTwbq/rz9crU83PleXDABoVxSBle8OdRmcHi8KOdYbJIza XinphfatitXh2pR5ze6ewDHbgV2IiZ8YAqpTw2hmCeUL+yFsXd9Bd0thuCiDkPB09ovRVG9UMugv W5/Z0YbxgdF4QjhWpxNP5kb6DQjJBkSBGEi4R84g5FTdcg7UwWlrJh2NMdSX4rmcgB/J3h3H+P6W ScfUGubsKIECqTqvp/peOzK53dPaxQoSt2xpoWXME0gUevza5vIPF6kly6JCtcqwXCWf/HPSANMm kOPmZ4Nk773NdImwy6O14dHzVCyX2eSXIzCuqB1m34Qz4pCINi5uEx+eYMkDw7F6743cDZZdsmJU NlNn1NjxNf+SEPBfm0M1whDKjSo8987d0x1+w0EA9PGoUtfeFykOE3TH7XbXhDtxCpF49ybg== X-QQ-XMRINFO: OD9hHCdaPRBwq3WW+NvGbIU= From: jackysliu <1972843537@qq.com> To: harry.wentland@amd.com Cc: sunpeng.li@amd.com, siqueira@igalia.com, alexander.deucher@amd.com, christian.koenig@amd.com, airlied@gmail.com, simona@ffwll.ch, alvin.lee2@amd.com, aurabindo.pillai@amd.com, Dillon.Varone@amd.com, Austin.Zheng@amd.com, Sung.Lee@amd.com, mario.limonciello@amd.com, Wayne.Lin@amd.com, ryanseto@amd.com, linux@treblig.org, joshua.aberback@amd.com, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, jackysliu <1972843537@qq.com>, jackysliu Subject: [PATCH] drm/amd/display:fix a Null pointer dereference vulnerability Date: Thu, 3 Jul 2025 11:39:28 +0800 X-OQ-MSGID: <20250703033928.2201509-1-1972843537@qq.com> X-Mailer: git-send-email 2.43.5 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" A null pointer dereference vulnerability exists in the AMD display driver's (DC module) cleanup function dc_destruct(). When display control context (dc->ctx) construction fails (due to memory allocation failure), this pointer remains NULL. During subsequent error handling when dc_destruct() is called, there's no NULL check before dereferencing the perf_trace member (dc->ctx->perf_trace), causing a kernel null pointer dereference crash Signed-off-by: jackysliu --- drivers/gpu/drm/amd/display/dc/core/dc.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd= /display/dc/core/dc.c index 56d011a1323c..3bda0593f66f 100644 --- a/drivers/gpu/drm/amd/display/dc/core/dc.c +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c @@ -934,6 +934,11 @@ static void dc_destruct(struct dc *dc) if (dc->link_srv) link_destroy_link_service(&dc->link_srv); =20 + if (!dc->ctx) { + dm_error("%s: called with NULL ctx\n", __func__); + goto skip_ctx_cleanup; + } + if (dc->ctx->gpio_service) dal_gpio_service_destroy(&dc->ctx->gpio_service); =20 @@ -946,6 +951,7 @@ static void dc_destruct(struct dc *dc) kfree(dc->ctx); dc->ctx =3D NULL; =20 +skip_ctx_cleanup: kfree(dc->bw_vbios); dc->bw_vbios =3D NULL; =20 --=20 2.43.5