From nobody Mon Oct 6 13:37:42 2025 Received: from out203-205-221-190.mail.qq.com (out203-205-221-190.mail.qq.com [203.205.221.190]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 485701DE89A for ; Mon, 21 Jul 2025 04:01:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.205.221.190 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753070510; cv=none; b=UkIpGTyMf3l2Bjnr61vriuYRt4ZpxrcLiJdtPP5poOEywj166CW+sUCkau/VrUk9CmrxHLBV0D+l7tcP2QDsL2AAvaIjdzoeLDg4j4TuO5HRVRjiIsiyfuB4dBQfwQLSP6cYT8vGiQckT5rCK4p9oFNoIS1A38oV3Gu3+onNbds= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753070510; c=relaxed/simple; bh=btpYYUIbFBEp+ktnsXZqqxkPFTnpTlE8q8VnCvyDrII=; h=Message-ID:From:To:Cc:Subject:Date:In-Reply-To:References: MIME-Version; b=CZVfwfQLBk/wRXvsKBR9nddSUiXu77HFX3/vhrtD5W0dVmaURLhstWwQtWcVmmf6wsQcwz7e8oCGtto7BLxA1eC7K2Lom6n8EX80Ef7GaOQeBWMFPg1DmhG2HpO78Pz9Hp1rSli+Ch6CSUrjd3vYUtc0goaf8BvfULd1tH4VG/Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=qq.com; spf=pass smtp.mailfrom=qq.com; dkim=pass (1024-bit key) header.d=qq.com header.i=@qq.com header.b=Vcfu4O2S; arc=none smtp.client-ip=203.205.221.190 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=qq.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=qq.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=qq.com header.i=@qq.com header.b="Vcfu4O2S" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512; t=1753070193; bh=sVN/AzOJY5mxP5MAX87gxt0LYQMkeR9l094mDeUFjL0=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Vcfu4O2SuNo1kLiO6dV65TItJxnex4F4UF22OGLSnlv3wey4EUjHLhZgxvADxnlpa jCG0AA7OBEvhJUmP74+TilDcdwe+9dsfdn1FwkO8rP3krxG2dXCZrnoUVV0IBIvJJu ySx4DsrC6IFRLJqHzuFu/jEJk6h4xNc3tpQewatY= Received: from VM-222-126-tencentos.localdomain ([14.116.239.33]) by newxmesmtplogicsvrszb20-0.qq.com (NewEsmtp) with SMTP id E1F824F9; Mon, 21 Jul 2025 11:56:31 +0800 X-QQ-mid: xmsmtpt1753070191t4v69hpdn Message-ID: X-QQ-XMAILINFO: Mkw1Oys1xyjC1/Lv+r5o6Q7xO1jo6/WJU9QWFmQnv71aUpxWCPWjFaBaSSfsd1 gFqjTbE/j38SjMwFyerFmnoQvnlf09MYhHV/Trr/HFGdl1IUwm2R+Z5kZajA1XICjETckiW/WaDT Mc1uoNfLleH9XMq0Vjl1Foyuia/vPSTIkOxY5M3PvP3N8vmA9UIQi89px8XPj1vuA+cTgEHFOVbu bc7Gi3fiSrnyfpbsPbEJvZiPuhpSIljksLknY6Tigq/pRs5IBxEhW89dOUPqnTaCED4XtdSvuW3c 12l9GOStp7CvO14Cyd9NdkFiSttH5xUYM66uMrEpsbn/z0HRy8e7zB6cjJK87+jPBl6En4IseS66 061BY0V7QWkPiEH5Y44lIgPlO2wYgT/jZKEk2O8Y+a0WOZ1WcumLcapuAF5xErR+bx/Ol+c2AP6e KhRxSYUVeu5dC/6KHi4qHQa2xIe6OYBqWHtFfGk3Q5vBF8CtY+gPtDiHsV2Wy1Kih6MvTqppio7f 9vrku6qQ+JSGmqqlX77qNN9Cppz6voA7syHk9yZ2Ef4I5CYPRl83kbwWoKyDI92VsJgHEDwlEnul nfiJ/+cPTlsMd9aaavYlB9lTAowahFKOiaGpi6sL0xg7cvPF4ubl2vA5YhUV/ktzZOnxFqdayKn7 s//HRLoOVzt/4U1rwKhv22x3a8qkyJGuDMwbrinZyeskkw7EDKPfP2SSD0t9vyt1Bfahvvwy6dQj EMLO0PnxGYji2plpA4cOXDSqaG21NlQAk2W3um0pbuApNJ1Ps7VELDxO/agNLGQpEsMTBdqZiZpy ui5M18u7+g6lr04WoGhFa/M8kW0M3SkCNMdCdnvfAsUSVSx4qgCo0mbDUtZDcLEP6GRgBMYntipa yyPzVvuvKdGD0aqxzrMpHQP5TBff+gPLg6iCbDurWn5mzwW0PnTYjEynG2JoqAplq91GtttBWB5Y 0bRdeHB/HajuvLjbEy81mBs7cbrnoISu8C3ocEIQ37QZXrBQEN1T3J454MNsAdjzD+F0NcwHZkbi I5FF0ghLHCr0X/Mslkn9LjC2Si6DXO7JMceVRehfNX4u/YF8gbYDWgxCigHZB2QEfHF3luGw== X-QQ-XMRINFO: NI4Ajvh11aEj8Xl/2s1/T8w= From: jackysliu <1972843537@qq.com> To: ptikhomirov@virtuozzo.com Cc: agk@redhat.com, den@virtuozzo.com, dm-devel@lists.linux.dev, khorenko@virtuozzo.com, linux-kernel@vger.kernel.org, mpatocka@redhat.com, snitzer@kernel.org, xni@redhat.com, yukuai3@huawei.com, Siyang Liu <1972843537@qq.com> Subject: [PATCH v2] arch: fix resource leak in jbusmc_probe() Date: Mon, 21 Jul 2025 11:56:24 +0800 X-OQ-MSGID: <20250721035624.128629-1-1972843537@qq.com> X-Mailer: git-send-email 2.43.5 In-Reply-To: <20250721034929.374552-1-ptikhomirov@virtuozzo.com> References: <20250721034929.374552-1-ptikhomirov@virtuozzo.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Siyang Liu <1972843537@qq.com> In the jbusmc_probe function, the device node mem_node fetched via of_find_node_by_path("/memory") is not properly freed on all code paths. This can lead to leakage of device node reference counts, which may result in kernel resources not being released. This issue was detected by rule based static tools developed by Tencent. Signed-off-by: Siyang Liu <1972843537@qq.com> --- arch/sparc/kernel/chmc.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/arch/sparc/kernel/chmc.c b/arch/sparc/kernel/chmc.c index d4c74d6b2e1b..fd20e4ee0971 100644 --- a/arch/sparc/kernel/chmc.c +++ b/arch/sparc/kernel/chmc.c @@ -412,7 +412,7 @@ static int jbusmc_probe(struct platform_device *op) mem_regs =3D of_get_property(mem_node, "reg", &len); if (!mem_regs) { printk(KERN_ERR PFX "Cannot get reg property of /memory node.\n"); - goto out; + goto out_put; } num_mem_regs =3D len / sizeof(*mem_regs); =20 @@ -420,7 +420,7 @@ static int jbusmc_probe(struct platform_device *op) p =3D kzalloc(sizeof(*p), GFP_KERNEL); if (!p) { printk(KERN_ERR PFX "Cannot allocate struct jbusmc.\n"); - goto out; + goto out_put; } =20 INIT_LIST_HEAD(&p->list); @@ -473,6 +473,10 @@ static int jbusmc_probe(struct platform_device *op) =20 err =3D 0; =20 +out_put: + of_node_put(mem_node); + goto out; + out: return err; =20 @@ -481,7 +485,7 @@ static int jbusmc_probe(struct platform_device *op) =20 out_free: kfree(p); - goto out; + goto out_put; } =20 /* Does BANK decode PHYS_ADDR? */ --=20 2.43.5