From nobody Mon Feb 9 20:18:58 2026 Received: from out162-62-57-64.mail.qq.com (out162-62-57-64.mail.qq.com [162.62.57.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D85A233154 for ; Mon, 13 Jan 2025 08:34:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=162.62.57.64 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736757305; cv=none; b=iXL2RlDrV5hFENVR+06zPyd48XgTLcvJlY7/tmy0OhyokXDxpJZ8WFakCKJQLhtDHaN4dA9M3A3iM5rqW2yF3EPh7s8xDCNL3REHTJw/wPY9xG1ssnfgmhcLOfK6GwOgQV+ikIGFBqZJWCqvjBuXKLgW95yQTIC37uN8nVvaIhI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736757305; c=relaxed/simple; bh=m2SjCyeJWyoVhHyJKe2NVMcUeK7JBX11mOIdJK2qbJs=; h=Message-ID:From:To:Cc:Subject:Date:MIME-Version:Content-Type; b=VF02D4+FlNuucSW+uCbUiugtnSLJ3ZZxmJzYiC61Y/kgZl5wbv1DapXreqlpqv+5KIngOybRuzzK52SrxRrTPPEeJ6jfylbhR/Ento4kKoImXvd8rSVbDJlMqVozxT5BxdMkNdA8W392lWxkl23xhuW4yzu6k3UD8d+drOU52Hk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foxmail.com; spf=pass smtp.mailfrom=foxmail.com; dkim=pass (1024-bit key) header.d=foxmail.com header.i=@foxmail.com header.b=YxMn70+5; arc=none smtp.client-ip=162.62.57.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foxmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=foxmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=foxmail.com header.i=@foxmail.com header.b="YxMn70+5" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1736757288; bh=0+SQZzWrxgJ9UsOya2bHhmoy5BNjFGhMHadR6NlfL6o=; h=From:To:Cc:Subject:Date; b=YxMn70+5gOWu0cWlA4FKCaLtsKd9O8K7y/8ucnyAGHLvP493HTK0JgDCjI7kbzR29 PP672DTi0MRifJ7phFGR6efoigbefv027GrtK/vev33EZnG/F9QJ0+L3e1+Vy35U2Y aY1E0lyZSC5ewljvBmQXQuaLRoThrtRceCY+zvtk= Received: from localhost.localdomain ([116.128.244.169]) by newxmesmtplogicsvrszb21-0.qq.com (NewEsmtp) with SMTP id 8AE88614; Mon, 13 Jan 2025 16:34:46 +0800 X-QQ-mid: xmsmtpt1736757286t1rwzrinv Message-ID: X-QQ-XMAILINFO: OaoBA5NOFC/jZfSGVN0SnHadfAwtrnU+ikD7O5PPsJUS0WT2vLJi7UuroR5FNl ZSdeTCt4UtRpYt4usfzlRCVkvwo1o/TOR8QjqBoGmz0Gpt9XJ9RaMtuGC0Gy0FTbaaDCQ/i6aek7 haxaZItqRyiZ68xM4IA0w6fMgCVVGrmllzGcM1HpcjRHNDGMpi6SvQO1GMduaKuRHQa/1xszrwyE KPHwgU3Jmc4K+GsbpHZQgtkV9Gyib2jsknFoqMpzptGx41ofGCbSx/rK0pBndNfqLcAuRPlgHwtf OaE5Zqvz2YHoMOegA0L/xOrAK45W0F/qIHV2Xy6n5fQTbmX+KL6bqa2RQwFtMSdveNOAl6BKb7Ap fO9yQzZvHg2eoYmxcC3gjCzu2fNuVH6J0LyfrZ6DyEc5/lJ6cLmRPKjiTBwYTl79eNVYSwLpRhNV Eos2toGsamnXK3mtkZZCoh1dxBi8dC4+p1Vg3rXAOdBRc1xR4RI2i/MsTAQnpnukPbbbJQ22H+1K lmNLhKpu0AY7bCazNW7CJ+gUSXmUEQSWJDvRwc8lZmoPb+EzpqjexkqwZOnwpBEYJ6uP7wd7f/uq 0/9z49uUYOhjB1AJEWf+a4vOtmQBPkXPMhveQN1BpCTJ8D8XZQt9K44U/XOM0/nnpyd6JGkFm9er 1i0XTaS3KBm0WaC+ULQpeDPTyhjB3r2LfYbzHk03ndzw0aDrtsoi2kB3axjCfmDRpJzskcaLPs6i XJtWeefDNxNyV2H/MZoXORJc2FKUSsdOq9LPGQa+QIIX2Z+WChTi5jM99L2zO298NCkRQ59VMEL3 nzz5kqifywf/AnRs2X2witd6N82vBYxyQOrQlVV7XMlbc2c+lBdy71qTEyefHeov06sAnwYBbmCD aWLjzpfl4UzD7uA/Z+bxBLVyWjAt1ZaSbyXeRHW7/3zBXIld2c6wByZikTPHmLqvszhChPn5PEER xgCHR+FS/ESdiMyl51OA== X-QQ-XMRINFO: OD9hHCdaPRBwq3WW+NvGbIU= From: xiaopeitux@foxmail.com To: =vkoul@kernel.org, aford173@gmail.com, geert@linux-m68k.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Pei Xiao Subject: [PATCH V5] phy: freescale: fsl-samsung-hdmi: fix build error in fsl_samsung_hdmi_phy_configure_pll_lock_det Date: Mon, 13 Jan 2025 16:34:45 +0800 X-OQ-MSGID: X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: Pei Xiao FIELD_PREP() checks that a value fits into the available bitfield, but the index div equals to 4,is out of range. which gcc complains about: In function =E2=80=98fsl_samsung_hdmi_phy_configure_pll_lock_det=E2=80=99, inlined from =E2=80=98fsl_samsung_hdmi_phy_configure=E2=80=99 at drivers/phy/freescale/phy-fsl-samsung-hdmi.c :470:2: ././include/linux/compiler_types.h:542:38: error: call to =E2=80=98__compil= etime_assert_538=E2=80=99 declared with attribute error: FIELD_PREP: value too large for the field 542 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) | ^ ././include/linux/compiler_types.h:523:4: note: in definition of macro =E2=80=98__compiletime_assert=E2=80=99 523 | prefix ## suffix(); | ^~~~~~ ././include/linux/compiler_types.h:542:2: note: in expansion of macro =E2=80=98_compiletime_assert=E2=80=99 542 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) REG12_CK_DIV_MASK only two bit, limit div to range 0~3, so build error will fix. Fixes: d567679f2b6a ("phy: freescale: fsl-samsung-hdmi: Clean up fld_tg_cod= e calculation") Signed-off-by: Pei Xiao Changlog: Reviewed-by: Adam Ford --- V5: add return ret from Geert suggestion V4: change to use if statement V3: change to use do-while V2: change to use logical AND --- drivers/phy/freescale/phy-fsl-samsung-hdmi.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/phy/freescale/phy-fsl-samsung-hdmi.c b/drivers/phy/fre= escale/phy-fsl-samsung-hdmi.c index 5eac70a1e858..6817ceabaab4 100644 --- a/drivers/phy/freescale/phy-fsl-samsung-hdmi.c +++ b/drivers/phy/freescale/phy-fsl-samsung-hdmi.c @@ -325,7 +325,7 @@ to_fsl_samsung_hdmi_phy(struct clk_hw *hw) return container_of(hw, struct fsl_samsung_hdmi_phy, hw); } =20 -static void +static int fsl_samsung_hdmi_phy_configure_pll_lock_det(struct fsl_samsung_hdmi_phy *p= hy, const struct phy_config *cfg) { @@ -341,6 +341,9 @@ fsl_samsung_hdmi_phy_configure_pll_lock_det(struct fsl_= samsung_hdmi_phy *phy, break; } =20 + if (unlikely(div =3D=3D 4)) + return -EINVAL; + writeb(FIELD_PREP(REG12_CK_DIV_MASK, div), phy->regs + PHY_REG(12)); =20 /* @@ -364,6 +367,8 @@ fsl_samsung_hdmi_phy_configure_pll_lock_det(struct fsl_= samsung_hdmi_phy *phy, FIELD_PREP(REG14_RP_CODE_MASK, 2) | FIELD_PREP(REG14_TG_CODE_HIGH_MASK, fld_tg_code >> 8), phy->regs + PHY_REG(14)); + + return 0; } =20 static unsigned long fsl_samsung_hdmi_phy_find_pms(unsigned long fout, u8 = *p, u16 *m, u8 *s) @@ -467,7 +472,11 @@ static int fsl_samsung_hdmi_phy_configure(struct fsl_s= amsung_hdmi_phy *phy, writeb(REG21_SEL_TX_CK_INV | FIELD_PREP(REG21_PMS_S_MASK, cfg->pll_div_regs[2] >> 4), phy->regs + PHY_REG(21)); =20 - fsl_samsung_hdmi_phy_configure_pll_lock_det(phy, cfg); + ret =3D fsl_samsung_hdmi_phy_configure_pll_lock_det(phy, cfg); + if (ret) { + dev_err(phy->dev, "pixclock too large\n"); + return ret; + } =20 writeb(REG33_FIX_DA | REG33_MODE_SET_DONE, phy->regs + PHY_REG(33)); =20 --=20 2.25.1