From nobody Mon Sep 28 07:23:09 2026 Received: from out162-62-57-49.mail.qq.com (out162-62-57-49.mail.qq.com [162.62.57.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 58ACE3AA182 for ; Tue, 25 Aug 2026 08:56:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=162.62.57.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787648200; cv=none; b=DGTnm9PUUFN94NsBNqWBXPg/6z/MZll3bOuF8LCLQPH8n7oDedIXxg3LU+S+ZjuIh1srcTAjDj0QQA1Gq8LzhsoBGl3bVHJYrk5VGjCDKzRWoatAGJr9x7SNPUWFPCDifFgUpC+nsLVTTkLUA9T+/zK9yqzFTj/dQAth3Y7PhLU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787648200; c=relaxed/simple; bh=J+3oidzUjVrTjy/Ar/qwB7BrPUM+sJN8Jlw51fXZhxk=; h=Message-ID:Date:MIME-Version:To:Cc:From:Subject:Content-Type; b=prysogSbeRQkVo4DCvH3KBeW8juwzLtfcrzdJ85UDUgc6RzQMTFjsmbZ2xUPlVoOivi7vNKpgElSA6fYjvWce0P9u/VlkqF4ihjUNk7D5kkmv/5CDjyv+oloGSm6koaYi8UeNA3AZMyLmh1iSh7TjKGARnVT8fONs8/OeOq5CPk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=qq.com; spf=pass smtp.mailfrom=qq.com; dkim=pass (1024-bit key) header.d=qq.com header.i=@qq.com header.b=MhC6j6rB; arc=none smtp.client-ip=162.62.57.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=qq.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=qq.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=qq.com header.i=@qq.com header.b="MhC6j6rB" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512; t=1787648187; bh=J+3oidzUjVrTjy/Ar/qwB7BrPUM+sJN8Jlw51fXZhxk=; h=Date:To:Cc:From:Subject; b=MhC6j6rBNaV+T6J101Jafx9RmUtaN5K/laM271L5VIcdAqF6WQ4iscIs0AqsDIb4f OQ9dOu96cUdRG2Wp9UAcaltmvnMjLA/qI6pH8jW5YMOvAsZw9h4ByKFTDjefTAhjOj mAS/gKbqpqUGTjnNelf100Ruja97az8j7wmybbSY= Received: from [192.168.255.10] ([111.206.145.19]) by newxmesmtplogicsvrszc43-0.qq.com (NewEsmtp) with SMTP id E1983CAD; Tue, 25 Aug 2026 16:56:25 +0800 X-QQ-mid: xmsmtpt1787648185tevzzae8h Message-ID: X-QQ-XMAILINFO: MllZffuBkEb5Mdb8NJGONLU4hONTIVBZ6uv/Xfse3skowZ+/iHhe6ncxMti9sq glzfPNp5oDL3nhWRy3ktbw18IR0o9K8kK3AffqMu4sNR5o35s7vfdVRHcFZIvEgHHfPIjyUNEWu/ 9t/Q88TORyR5FQ5bKY1/Nmqc0A4xp7yxyMOwWzwqexDxfp9Mu8hMTRViFhBmYnvtvd5OziWe0Rz3 MngEpb00g52JpyXxE3fqNx6to3BXSwaxHpcCll2eXWoS3zUojXUUaRhud4YRGAmeUvLv3fGg9Upr gzXTk2ml1GPaOZ+c+sn4Cz9KuMHTgKwv3TL8IbIHjq5EYvHNGfzVT4i9UPeF+ruEQYdhkb9P6RoH ZToYkswLVkspVHr2r8ZGMpEFP5AdQNVqvrBEiDlbt7M4VquNsdBrJGq0MwJ8EioexKaRK9R57fuv TeX221MSEUsCqcpvkLocNbqIh70UqPRUWi7xSZME/PtfHvcVxUk2PyX285bqltz4sz5+Ut1z0Bxq 510bQ7GbP6k/6HiXc/MyXdWf7lfd05bAUm5g58CaiRw9vpJuCxvYTUKCCAKpBU4ikX0wGH0uYDJZ k0ATUAK/ZgNhgOk2C4arU+5PzeWndCLnqwfiAx6CekU2fvD7Dccchz1sN8VVWLdRLif3u6TediuF cXdFhdcz9xEHmfGRofANr4oDdMhT7dFK4+mPlfDsl6zRR8jc1bBZSz1WAyxP2xdYZWizaz9Thc9S bCiWRbzhl7FFaxtywCbUfSsCQwyknXEuMlOGu+nWqlka92f0F6Un0gLRWRHkcoFAXUuhYiPf4Lsm 5oNXy1y6vc25LiwlLx+4KxVdedhZS+lRfTCBqV9TQUL29eJoemhwl7B+k75ayIA47ixu7KsDJQg1 xh2Vk5qaBpwFfoRNpjqIr7eZ6GZNXllXt7LoxJt+RPoySZIxR9O7hdq2cg3Yamiohz1TeRxXs7yU 7v5b8I0L8TBsuCMka/ijG51igqvltZBpUR96Ivffha2E941944y5xkiui6ry6b5y/gXeJy+HZgSe 30u+FSjPrAyckRG0oVTqwxAedpCdc8I158DR/GT2J3LkwegGuZNZz7oywPul0= X-QQ-XMRINFO: OWPUhxQsoeAVwkVaQIEGSKwwgKCxK/fD5g== X-OQ-MSGID: Date: Tue, 25 Aug 2026 16:56:24 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: bmasney@redhat.com, sboyd@kernel.org, mturquette@baylibre.com Cc: linux-kernel@vger.kernel.org From: Yang Zi <2959243019@qq.com> Subject: [PATCH] clk: si544: Fix NULL pointer dereference in probe Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable si544_probe() dereferences client->dev.of_node->name without first checking that a device tree node is present. When the device is instantiated without DT, e.g. via sysfs "new_device", client->dev.of_node is NULL and probe crashes with a NULL pointer dereference. Add an early check and return -ENODEV when no of_node is available, since this driver requires device tree bindings. Signed-off-by: Yang Zi <2959243019@qq.com> --- =C2=A0drivers/clk/clk-si544.c | 3 +++ =C2=A01 file changed, 3 insertions(+) diff --git a/drivers/clk/clk-si544.c b/drivers/clk/clk-si544.c index 09c06ecec1a5..a9f0765f41ae 100644 --- a/drivers/clk/clk-si544.c +++ b/drivers/clk/clk-si544.c @@ -437,6 +437,9 @@ static int si544_probe(struct i2c_client *client) =C2=A0 =C2=A0 =C2=A0struct clk_init_data init; =C2=A0 =C2=A0 =C2=A0int err; =C2=A0 +=C2=A0 =C2=A0 if (!client->dev.of_node) +=C2=A0 =C2=A0 =C2=A0 =C2=A0 return -ENODEV; + =C2=A0 =C2=A0 =C2=A0data =3D devm_kzalloc(&client->dev, sizeof(*data), GFP_= KERNEL); =C2=A0 =C2=A0 =C2=A0if (!data) =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return -ENOMEM;