From nobody Mon Jun 8 07:38:29 2026 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B0A062264D3 for ; Mon, 1 Jun 2026 04:35:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780288502; cv=none; b=pJX9BOLHkGQW3DoeaZq7yrd1qQbuWyh8MMFPn3+KPipZzuiA1RIOCqaUzYkNY9KP+WZ7ZzWs7byctp19kixnvAckFnxeVjdBXvYmuJgQRPOWX2EWsvTOrA6OpRDExDwwKL4WOUenc4yCjmjgxB97akoRr2t0Y1Bv1vUNCj9enac= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780288502; c=relaxed/simple; bh=v58kITCdQULNaKlQeChNpaMiUZbHLv//0Kb3XekZx70=; h=Date:From:To:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=RA3My0maV5kQESaEMCPoHCkEFZKrvphnPfkFdSt4DU/07CZn0YYpMKlcpKRwBcT0mpm+B1zwH192i/4y1ntNYNOePctcWtOs04fnE9p7Da2KPUvcY1AobPbK6yq9TbffvZYEk7apDeAtjNSijs1oH+tXNyQfkEo1OPQ9ME9GErY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=THyQmnsF; arc=none smtp.client-ip=209.85.216.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="THyQmnsF" Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-36d630c0e35so1302068a91.3 for ; Sun, 31 May 2026 21:35:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780288501; x=1780893301; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=r1V7SYiejbcVvpUUcmfXve5MVJ8Iiq82CXPHyJxdT+I=; b=THyQmnsFHpbNG5zfWSZi5j8bThSq0otBqC62wJnhTLrNpRdiPj7i6LQeCo7E9AVxxx w/bkt0345+X75jJGB28dH2pl2vjPPu6DfBdEelA6LFLR5PA1mFNUJz+KIKTsjaJVsHvC v0m3SXQELYfyyi1uD5u5BFLDdV+Bf9Hk0ctMV1cC4nYAOSEoHtJgVyR9ujsriKWo2OQE /7vnzt7jl1FvlV/dm7tQdJXAwCUsNXhS3SpUYRKR7hf3BGXLeYdLpNOjEqUz9bzL7agk Yz4bLuUr9V6n6nrtLBSDskW4nYyKiX9m7SHsSMcB8IvStKq+M6Ghlxpntoqg+ESWRn28 L/8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780288501; x=1780893301; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=r1V7SYiejbcVvpUUcmfXve5MVJ8Iiq82CXPHyJxdT+I=; b=rUufOVDadIhRhwFLzJfu0hH26XggPbx6n6Z25+H/5rgEsIiUUiu89hKteYrnyzRly9 8V6X/eGHijErlXFlwS+QBCiS1Hd0SQk31lTjTQSHxJkljSRCbkQ16FDfaELf+s42GEXt qlEcF7YMN2BikIduWM1nQJVyEhXVupeMXiWGyKv2FMgr1HM9b3uj70/y1rkW0j4ffRtl Cp8HnaOWI2oExKgwVSPJPIFMiAEA/7n1ljYJ2tMk2XIH5bmH2SmDKGX9BwhyBULbOW4/ S99FLahkU6KwYYY9Rkb73vsvqQyWvBgy2+D0gQiuHxg2MBqvFUYXBh4FpOSwr447psaR JhYg== X-Forwarded-Encrypted: i=1; AFNElJ9JMIVUnmuIHnp14eMaIe31d0ZFGkchx1UlZSJZ/z9uBmmMzFlbTNnJ4560bwDFcFdsc+RfLqP036r2Seg=@vger.kernel.org X-Gm-Message-State: AOJu0YzgWPQzh6CTf4Fr9w4navH89TponUD2XcjYKDYhZVxTleeglZWJ gBId+B59c2umHsBH6oZFfYXFWsORR23/YoKDzmcQffG6RLcvRfm+dZHi X-Gm-Gg: Acq92OHsLiLECsjMB5voi2d9EsKzXnsLmsZJAPbKpnSnpRzNkwaB3CfLQo87BafsxIH NBPHgpZ0K/GZtOEuHTB/6B/TDmZ2SFPw9/h4WSG4aZCPUWHsSRHNy4m8G80wKAHqoetK1lJSf8T pt34gEEc3a1XsznXh3f+kw/AszxKlmW5pExAuktXD+s0H9RshPS2oafeW2EoHQlg185XVvY7KzB S/4Lf5tgfrKWldg2VBqqqXiqbzQOVleg6/NZcU2JrhNX2i5+4flU3OHsqLWyrANgF6H+PzlTsBI iOVv4Jejp0zNiQadmtArgnPK19FAvl/Q9KWoODgmwLZEDUXimT/cAOIPpMthe6k0VK0R5UvzK79 dYquKTJlvJXzOpJC25zdIcug56FLLOLd37ga+rq8UZQnbkFYjOBNkRGXyY2P0mPzNIerkeLqlhZ aXxMbNoBdZZTlmQY2ynNjS72u36EldP6ZfUYg= X-Received: by 2002:a17:90b:38c5:b0:36d:6339:4aa6 with SMTP id 98e67ed59e1d1-36d63394c2fmr8472030a91.27.1780288500934; Sun, 31 May 2026 21:35:00 -0700 (PDT) Received: from localhost ([2405:201:4027:a919:e2b2:8560:26ea:4d1]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36bc65e760dsm11001465a91.2.2026.05.31.21.34.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 31 May 2026 21:35:00 -0700 (PDT) Date: Mon, 1 Jun 2026 10:04:58 +0530 From: Naveen Kumar Chaudhary To: jstultz@google.com, tglx@kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] time: Fix off-by-one in settimeofday() usec validation Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The validation check uses '>' instead of '>=3D' when comparing tv_usec against USEC_PER_SEC, allowing the value 1000000 through. After conversion to nanoseconds (*=3D 1000), this produces tv_nsec =3D=3D NSEC_PER_SEC, violating the timespec invariant that tv_nsec must be less than NSEC_PER_SEC. Use '>=3D' to reject tv_usec values that are not in the valid range of 0 to 999999. Signed-off-by: Naveen Kumar Chaudhary Acked-by: John Stultz --- kernel/time/time.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/time/time.c b/kernel/time/time.c index 0d832317d576..771cef87ad3b 100644 --- a/kernel/time/time.c +++ b/kernel/time/time.c @@ -207,7 +207,7 @@ SYSCALL_DEFINE2(settimeofday, struct __kernel_old_timev= al __user *, tv, get_user(new_ts.tv_nsec, &tv->tv_usec)) return -EFAULT; =20 - if (new_ts.tv_nsec > USEC_PER_SEC || new_ts.tv_nsec < 0) + if (new_ts.tv_nsec >=3D USEC_PER_SEC || new_ts.tv_nsec < 0) return -EINVAL; =20 new_ts.tv_nsec *=3D NSEC_PER_USEC; --=20 2.43.0