From nobody Mon Apr 13 04:24:36 2026 Received: from mx1.secunet.com (mx1.secunet.com [62.96.220.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3839019067C; Sun, 12 Apr 2026 11:13:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=62.96.220.36 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775992438; cv=none; b=myjhudreM05jpv8xnePeEIUbdHYdkQobLJ/csfsVp8RUAO8ftkHuvQUAzDtPPfNF1LYJsojx8bTvb7ZIv0w2W2nFbeZwC2xWYUG6MHVluJUmQqh146iHfYOClrys1E5imbqxVN1LGKQj8c7HGx0XqQ0TjYQdkjRHalYu4IYe1qo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775992438; c=relaxed/simple; bh=njpPzO0I4NINQuUd3TXRel4fUwi8HQxwuXkW+uQWdmw=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=SZVRgkHm4yBRPEEGH0Y4CSQvylrFXhCH2pdOViB2T/IwNX3eSPKmnazDzHQh2Iw+3cMCuGpFytYnjV8Dm8IRvvNqIrhDQJOZ33/TuuB9rjHDhU6JL68EGhLTw9Ih4Qfq144lEnZLOf79wfe9zkGWdKNE9sVH1NbiZ/eRlUqu24Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=secunet.com; spf=pass smtp.mailfrom=secunet.com; dkim=pass (2048-bit key) header.d=secunet.com header.i=@secunet.com header.b=0ErTPBcw; arc=none smtp.client-ip=62.96.220.36 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=secunet.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=secunet.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=secunet.com header.i=@secunet.com header.b="0ErTPBcw" Received: from localhost (localhost [127.0.0.1]) by mx1.secunet.com (Postfix) with ESMTP id 2769320799; Sun, 12 Apr 2026 13:13:54 +0200 (CEST) X-Virus-Scanned: by secunet Received: from mx1.secunet.com ([127.0.0.1]) by localhost (mx1.secunet.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oeHULxhk0E0v; Sun, 12 Apr 2026 13:13:53 +0200 (CEST) Received: from EXCH-02.secunet.de (rl2.secunet.de [10.32.0.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.secunet.com (Postfix) with ESMTPS id 6ED412084B; Sun, 12 Apr 2026 13:13:53 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.secunet.com 6ED412084B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=secunet.com; s=202301; t=1775992433; bh=6rlJRpiY9QKBK7+Qr9FGrYyMXsvCl5MBxOaLAwh5Ptc=; h=From:To:CC:Subject:Date:In-Reply-To:References:From; b=0ErTPBcwNXl+dbptndupjkB6b69ATU3XdhM7O6GcfTnttJkWwTszTSdgvrhCTMg/1 srGjbrEf9xwHiN3NGYhIhK5Vbwa/yVUxWofI6s3zr4RK10srqZyDeNXAb709PltE7B kgi6Dfk4xHL6rUoHHhxKgsi09022UZliNBa6XtFXzdfBub7deLFvoBDQDByKFwsOZT 4H+uJyvzZBG26Zh9jqDU64TufwE5Cm1yYxlutC9xtDpzUk4CwOxFOFG9JMPaXhWwLz 0G/6VXTDscEngyTJi9iQoA6xRqvYIvdL2aEzAqVSCcZPK9xHtoIWPuMkHMGC5YYIcw lG7p47+b0PaBg== Received: from moon.secunet.de (172.18.149.1) by EXCH-02.secunet.de (10.32.0.172) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Sun, 12 Apr 2026 13:13:51 +0200 From: Antony Antony To: Antony Antony , Steffen Klassert , Herbert Xu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , David Ahern , Masahide NAKAMURA , Paul Moore , Stephen Smalley , Ondrej Mosnacek , Jonathan Corbet , Shuah Khan CC: , , , , Chiachang Wang , Yan Yan , Subject: [PATCH ipsec-next v7 01/14] xfrm: remove redundant assignments Date: Sun, 12 Apr 2026 13:13:41 +0200 Message-ID: X-Mailer: git-send-email 2.39.5 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Mailer: b4 0.15-dev Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: EXCH-03.secunet.de (10.32.0.183) To EXCH-02.secunet.de (10.32.0.172) These assignments are overwritten within the same function further down commit e8961c50ee9cc ("xfrm: Refactor migration setup during the cloning process") x->props.family =3D m->new_family; Which actually moved it in the commit e03c3bba351f9 ("xfrm: Fix xfrm migrate issues when address family ch= anges") And the initial commit 80c9abaabf428 ("[XFRM]: Extension for dynamic update of endpoint add= ress(es)") added x->props.saddr =3D orig->props.saddr; and memcpy(&xc->props.saddr, &m->new_saddr, sizeof(xc->props.saddr)); Signed-off-by: Antony Antony --- v1->v2: remove extra saddr copy, previous line --- net/xfrm/xfrm_state.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/xfrm/xfrm_state.c b/net/xfrm/xfrm_state.c index 98b362d51836..3ee92f93dbd2 100644 --- a/net/xfrm/xfrm_state.c +++ b/net/xfrm/xfrm_state.c @@ -1980,8 +1980,6 @@ static struct xfrm_state *xfrm_state_clone_and_setup(= struct xfrm_state *orig, x->props.mode =3D orig->props.mode; x->props.replay_window =3D orig->props.replay_window; x->props.reqid =3D orig->props.reqid; - x->props.family =3D orig->props.family; - x->props.saddr =3D orig->props.saddr; =20 if (orig->aalg) { x->aalg =3D xfrm_algo_auth_clone(orig->aalg); --=20 2.47.3