From nobody Mon Jun 8 08:43:54 2026 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 472D53E1D16 for ; Wed, 3 Jun 2026 16:26:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780503995; cv=none; b=VnHhfRE/rHnKv9g0AJNTVQIebYr0i5Laz15hzwO4XhQ2LYNYMNTZYUxhCRlstfmMQpzU5S0aniMHettZ5B3Zbrn6JlsOXFqVwr5/RtEgn8nPMg/wJNyE0g9mQ4c991o+hYqdxQdnpcK7a4chtLwjD1iXemou0sQ4KNYb80uNHgc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780503995; c=relaxed/simple; bh=qGenFoylJV66LbGsmsumCYEudxMB3PzzVDerNZQ714o=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=GvNyVBDoG1WC8FP51gGkSosdc7j6kL4l3sUymHUCZUjHUcb0O2MVXQ/7RLNP1ie0Tdb3ft1mMAilP7zjyktxOVnu2K7mRW99u0cL+BJ3fS6bfWaJRf/ITlR7PY1an2AKXH2WyMo3qE/lR+3RTlHgeqWym4Ys7dVk2oBJa43ShE8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jhE33sBt; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jhE33sBt" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2c0bd02d97eso46946495ad.2 for ; Wed, 03 Jun 2026 09:26:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780503993; x=1781108793; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=SmTn+OsjpTOYZ6r16QcX+2FZCk8ofoJdYq2HApRJAyg=; b=jhE33sBt5ADWjaP4+4L72/sq+40YoktVfO0Im5ZQaNoJfbuwv7WB0dfQ2crkhQ96Un bCLn47OW/YeeyM6evf933RLxW7zoCPXCy2OqLdAdg1Q3q8AgFMkRM4X0KLaiVJJoWATf h9UzV+TvZGYfJ+Ksf9VoLpy12/NIF2FOETvY/H9rPRqCBpCtB/0VWX8a3ZmeMLNo6cma 6cP9ZFP4CvPkJzK8v0aimLS6QITiFyvcqX5A8qbvQpQvJpXsfVIoaiZQXzRCGG56SkRf phvwxiJCjRKYkOxCpU1SThUhg4+HS1PA95yqPiS3CLLdzKP/W+gewtN1Un5AK3I6gm56 bLXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780503993; x=1781108793; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SmTn+OsjpTOYZ6r16QcX+2FZCk8ofoJdYq2HApRJAyg=; b=sI1RHgXmePb/3kx+xD+2ovU7fdVZaQvCRXOJdSNhFOJHdcjlXv86Xy6JA6NybkNe+N GZI/9fF/jqquBaZozqWmNycmdBgBE7o81K4YJ2yxFYLE3BTTVqjHBYLiS+oYwqpHMKe3 y+3KYakVq858CovFB9BGjHsaEdbcKSZHQvXSyMT4D1S3U87UAhKZylbpPkqqwh56Fy31 AKlvV2yjFqvMuXi7Z927qyRlilzX5sQt38F5YzV9z52+QKEnTTrJJItdhZdbEKHMoHBY ZuCJDepzjBhV1dxLHpstbYn56QZVIaAJh/3ugoB2mjmVpbn/pQQXCtqTVC3TGSZoEjM/ hvSQ== X-Forwarded-Encrypted: i=1; AFNElJ9G62xG5FlskzycNX2O7iSh5hMgcKGL4q4brm4qNZEKselaBG7NlAtTzbVmAFi3R2ZjxLnnF0if4wdfTzo=@vger.kernel.org X-Gm-Message-State: AOJu0YxKeuKorMnXOnToWV/ROF/5yc0v9q+QZ9qfwcMWvQEuh7jKYvbn MzV5FVwMREAtEWnDeGtO3gMcFrXKlVH2RKQXWljZ9wKTSRTvaeWao3uy X-Gm-Gg: Acq92OFnGSJEJNUxRDuse88UNI/7UnEc+TtsPbekJOFtBgQuVrIPCp/Q5C960sK8y0/ SCNzoyraGIXEDsh5UtFKamV2YPR9bWBRg13Z/N42LQ8B1afxuXIVzUj1qY7R8xACCbPkxhFDHD3 IXYBaz4Vc+BKMNSyzoDuD9O5K1e4G7NKOEVLoQFsz9DE113G7k2Drt9JdEHW5pGbORYWuXctiUb TseHOFArgOSF6ytNpTAmIS5go50Y3wwyx9pFT1M/X/97bBMD6YR9Q6ZxNJ0XULkT3Exrt4Jjlza KGwHOsCYomOm+ZleR5SGvpWSUbl/UDoKN7yI49TDahYHQlzV3fjrxt+urY5lmC1KJSX2og6qqLc dA0udz+HW+50WeU37AzZ5oNpmbtHkIxAUcftAevOYVC1YJbr1Nu4uperCYHxeGAelnyMDt3khTT lfnjwkpGZatAaR2paUY/MWfU4aRHbKNfswFFQ= X-Received: by 2002:a17:902:e5ce:b0:2c1:5135:39f3 with SMTP id d9443c01a7336-2c163a43ff3mr45661725ad.11.1780503993515; Wed, 03 Jun 2026 09:26:33 -0700 (PDT) Received: from localhost ([2405:201:4027:a919:e2b2:8560:26ea:4d1]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c1664a67b0sm30613855ad.80.2026.06.03.09.26.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jun 2026 09:26:33 -0700 (PDT) Date: Wed, 3 Jun 2026 21:56:31 +0530 From: Naveen Kumar Chaudhary To: mcgrof@kernel.org, petr.pavlu@suse.com, da.gomez@kernel.org, samitolvanen@google.com Cc: atomlin@atomlin.com, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] module: stats: use strscpy() to copy failed module name Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" try_add_failed_module() uses memcpy() with strlen(name) as the length to copy a module name into mod_fail->name, a fixed-size buffer of MODULE_NAME_LEN bytes. This is an issue as it does no bounds check. Current callers always pass names originating from mod->name (char[MODULE_NAME_LEN]), so this is not exploitable today. However the function accepts a plain const char * with no documented length contract, making it a latent buffer overflow if a future caller passes a longer string. Replace memcpy() with strscpy(), which bounds the copy to MODULE_NAME_LEN and always NUL-terminates. Signed-off-by: Naveen Kumar Chaudhary --- kernel/module/stats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/module/stats.c b/kernel/module/stats.c index 3a9672f93a8e..08724baca773 100644 --- a/kernel/module/stats.c +++ b/kernel/module/stats.c @@ -253,7 +253,7 @@ int try_add_failed_module(const char *name, enum fail_d= up_mod_reason reason) mod_fail =3D kzalloc_obj(*mod_fail); if (!mod_fail) return -ENOMEM; - memcpy(mod_fail->name, name, strlen(name)); + strscpy(mod_fail->name, name, MODULE_NAME_LEN); __set_bit(reason, &mod_fail->dup_fail_mask); atomic_long_inc(&mod_fail->count); list_add_rcu(&mod_fail->list, &dup_failed_modules); --=20 2.43.0