From nobody Fri Jun 19 18:18:01 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CBEFC433EF for ; Thu, 31 Mar 2022 06:39:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231290AbiCaGks (ORCPT ); Thu, 31 Mar 2022 02:40:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55902 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231271AbiCaGkn (ORCPT ); Thu, 31 Mar 2022 02:40:43 -0400 Received: from alexa-out.qualcomm.com (alexa-out.qualcomm.com [129.46.98.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A72B51ED070 for ; Wed, 30 Mar 2022 23:38:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1648708736; x=1680244736; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=mHeEyGBnZF6p3AO3x4ap5fHK4uid7cBRJDPfLGdSF3o=; b=hTp8qJw1kB2wjREC8liu2tOtSRNR6tQUaHUPp1VC8UEBI+5yZwgdt7C3 mQR4nvxuQHY7XDWDeODu0Tw956u/m6QeUF0gg7sQcBtVnWC+b8H8cvxuI JdvdlYkgQeXSG9FiZPj1bQ2JPbD7pXKjfno9CEDrtWyNPYgoAtrfHJ6QA A=; Received: from ironmsg07-lv.qualcomm.com ([10.47.202.151]) by alexa-out.qualcomm.com with ESMTP; 30 Mar 2022 23:38:56 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg07-lv.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Mar 2022 23:38:56 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Wed, 30 Mar 2022 23:38:55 -0700 Received: from hu-charante-hyd.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Wed, 30 Mar 2022 23:38:51 -0700 From: Charan Teja Kalla To: , , , , , , CC: , , Charan Teja Reddy Subject: [PATCH RESEND V5,1/2] mm: fadvise: move 'endbyte' calculations to helper function Date: Thu, 31 Mar 2022 12:08:20 +0530 Message-ID: X-Mailer: git-send-email 2.7.4 In-Reply-To: References: MIME-Version: 1.0 X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Charan Teja Reddy Move the 'endbyte' calculations that determines last byte that fadvise can to a helper function. This is a preparatory change made for shmem_fadvise() functionality in the next patch. No functional changes in this patch. Signed-off-by: Charan Teja Reddy --- Changes in V5: -- Moved the 'endbyte' calculation to a helper function. -- This patch is newly raised in V5 thus no change exists from v1 to v4. mm/fadvise.c | 11 +---------- mm/internal.h | 21 +++++++++++++++++++++ 2 files changed, 22 insertions(+), 10 deletions(-) diff --git a/mm/fadvise.c b/mm/fadvise.c index 338f160..0c82be2 100644 --- a/mm/fadvise.c +++ b/mm/fadvise.c @@ -65,16 +65,7 @@ int generic_fadvise(struct file *file, loff_t offset, lo= ff_t len, int advice) return 0; } =20 - /* - * Careful about overflows. Len =3D=3D 0 means "as much as possible". Use - * unsigned math because signed overflows are undefined and UBSan - * complains. - */ - endbyte =3D (u64)offset + (u64)len; - if (!len || endbyte < len) - endbyte =3D -1; - else - endbyte--; /* inclusive */ + endbyte =3D fadvise_calc_endbyte(offset, len); =20 switch (advice) { case POSIX_FADV_NORMAL: diff --git a/mm/internal.h b/mm/internal.h index 58dc6ad..b02f07e 100644 --- a/mm/internal.h +++ b/mm/internal.h @@ -546,6 +546,27 @@ static inline void vunmap_range_noflush(unsigned long = start, unsigned long end) #endif /* !CONFIG_MMU */ =20 /* + * Helper function to get the endbyte of a file that fadvise can operate o= n. + */ +static inline loff_t fadvise_calc_endbyte(loff_t offset, loff_t len) +{ + loff_t endbyte; + + /* + * Careful about overflows. Len =3D=3D 0 means "as much as possible". Use + * unsigned math because signed overflows are undefined and UBSan + * complains. + */ + endbyte =3D (u64)offset + (u64)len; + if (!len || endbyte < len) + endbyte =3D -1; + else + endbyte--; /* inclusive */ + + return endbyte; +} + +/* * Return the mem_map entry representing the 'offset' subpage within * the maximally aligned gigantic page 'base'. Handle any discontiguity * in the mem_map at MAX_ORDER_NR_PAGES boundaries. --=20 2.7.4