From nobody Tue Dec 30 09:34:03 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51A92C197A0 for ; Fri, 17 Nov 2023 02:54:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345649AbjKQCyH convert rfc822-to-8bit (ORCPT ); Thu, 16 Nov 2023 21:54:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60472 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229437AbjKQCyG (ORCPT ); Thu, 16 Nov 2023 21:54:06 -0500 Received: from rtits2.realtek.com.tw (rtits2.realtek.com [211.75.126.72]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B2E061A8; Thu, 16 Nov 2023 18:54:02 -0800 (PST) X-SpamFilter-By: ArmorX SpamTrap 5.78 with qID 3AH2rrHyB2827004, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (rtexh36506.realtek.com.tw[172.21.6.27]) by rtits2.realtek.com.tw (8.15.2/2.95/5.92) with ESMTPS id 3AH2rrHyB2827004 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 17 Nov 2023 10:53:53 +0800 Received: from RTEXDAG02.realtek.com.tw (172.21.6.101) by RTEXH36506.realtek.com.tw (172.21.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.17; Fri, 17 Nov 2023 10:53:53 +0800 Received: from RTEXMBS04.realtek.com.tw (172.21.6.97) by RTEXDAG02.realtek.com.tw (172.21.6.101) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.7; Fri, 17 Nov 2023 10:53:52 +0800 Received: from RTEXMBS04.realtek.com.tw ([fe80::40c2:6c24:2df4:e6c7]) by RTEXMBS04.realtek.com.tw ([fe80::40c2:6c24:2df4:e6c7%5]) with mapi id 15.01.2375.007; Fri, 17 Nov 2023 10:53:52 +0800 From: Ping-Ke Shih To: Su Hui , "Jes.Sorensen@gmail.com" CC: "kvalo@kernel.org" , "linux-wireless@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "kernel-janitors@vger.kernel.org" Subject: RE: [PATCH v2] wifi: rtl8xxxu: correct the error value of 'timeout' Thread-Topic: [PATCH v2] wifi: rtl8xxxu: correct the error value of 'timeout' Thread-Index: AQHaF4Do9v4vXgLKQEi53aoMdH/MCbB90spQ Date: Fri, 17 Nov 2023 02:53:52 +0000 Message-ID: References: <20231115050123.951862-1-suhui@nfschina.com> In-Reply-To: <20231115050123.951862-1-suhui@nfschina.com> Accept-Language: en-US, zh-TW Content-Language: zh-TW x-originating-ip: [172.21.69.94] x-kse-serverinfo: RTEXDAG02.realtek.com.tw, 9 x-kse-antispam-interceptor-info: fallback x-kse-antivirus-interceptor-info: fallback Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-KSE-AntiSpam-Interceptor-Info: fallback Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" > -----Original Message----- > From: Su Hui > Sent: Wednesday, November 15, 2023 1:01 PM > To: Ping-Ke Shih ; Jes.Sorensen@gmail.com > Cc: Su Hui ; kvalo@kernel.org; linux-wireless@vger.ke= rnel.org; > linux-kernel@vger.kernel.org; kernel-janitors@vger.kernel.org > Subject: [PATCH v2] wifi: rtl8xxxu: correct the error value of 'timeout' >=20 > When 'rtl8xxxu_dma_agg_pages <=3D page_thresh', 'timeout' should equal to > 'page_thresh' rather than '4'. Change the code order to fix this problem. >=20 > Fixes: fd83f1227826 ("rtl8xxxu: gen1: Add module parameters to adjust DMA= aggregation parameters") > Signed-off-by: Su Hui > --- Checking logic of agg_pages and agg_timeout, I think we should correct it by below changes. So, NACK this patch.=20 diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c b/driver= s/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c index 43ee7592bc6e..c9e227aed685 100644 --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c @@ -4760,7 +4760,7 @@ void rtl8xxxu_gen1_init_aggregation(struct rtl8xxxu_p= riv *priv) page_thresh =3D (priv->fops->rx_agg_buf_size / 512); if (rtl8xxxu_dma_agg_pages >=3D 0) { if (rtl8xxxu_dma_agg_pages <=3D page_thresh) - timeout =3D page_thresh; + page_thresh =3D rtl8xxxu_dma_agg_pages; else if (rtl8xxxu_dma_agg_pages <=3D 6) dev_err(&priv->udev->dev, "%s: dma_agg_pages=3D%i too small, minimum = is 6\n",