From nobody Sat Dec 27 01:04:30 2025 Received: from mout.web.de (mout.web.de [212.227.17.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 871A44D10D; Tue, 26 Dec 2023 09:38:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=web.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b="Wy+H4r4G" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1703583504; x=1704188304; i=markus.elfring@web.de; bh=qqBCvkgxbSr3g6FTVllb7hWAQXmgVICHt5PVFl7CIWM=; h=X-UI-Sender-Class:Date:Subject:From:To:Cc:References: In-Reply-To; b=Wy+H4r4Gnaa7y8tBPP7pvGH9Vec+3s9dvNs1B7LVWc/iT6edD5t8cI3E4DBpOLTV qhyV+uMBT/XL3i89SdIhhxywBBUObocgZ32fJHx9VfYhBhdp5yNS5dwXdSMFAju51 FcIFnh4TBrEVloMrstRrQ2/XCqA8qfcN212+mEoUdDxvp1CsyWlkJ24VJns08R+lh eLZLEVJCnAStJAZ4UJ1byJUSaAEswW143Fk+ACvx1j0ZuXz/UZXhG/NhPlsm8VO9n bfT17tpHgSLnT96f0myHggbY8uY9a4EIfb+Y5BpxzEdSRzLJJDGr4QcXvzoZCoP/G BoYy0kHI3wnHNkMbuA== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.85.95]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MC0LH-1rQ3aP0NaP-00CKaS; Tue, 26 Dec 2023 10:38:24 +0100 Message-ID: <9b1e7330-f4f6-47f8-a568-eaea1624bb6f@web.de> Date: Tue, 26 Dec 2023 10:38:22 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 1/3] drm: property: One function call less in drm_property_create() after error detection Content-Language: en-GB From: Markus Elfring To: dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org, Daniel Vetter , David Airlie , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann Cc: LKML , cocci@inria.fr References: In-Reply-To: Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:iDixZmNvylQDuMt0skzUFKjo8Mh89iiU1EhN0o+/2elM/jOlggR 6muOk7JjgmGLlXj3ITzr5rhHM9PHeCLjkWxFXiVhflFrt6iRboOIWS7Dl5KJDHi1vkOUj71 pvU/i0C+PKKkNZ+eU5BzCX/eLI33iBrs+IvDwscaU8Vvv/c0iWdWouXu1c0vmuzAwXne416 rBGEr9tTaR33LkfrfkioA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:d/X1dljrE+A=;DqE9o4o4RjEHkhdE3U4ZQnuaFTY X7BtY+Blaevtp8Ogi98aTZqmzApKK5NoowuUnky/rLGUjzcuMNPkp3opQGYwAZCAaW+sUVGew x3QvEl96i7st7xV4gRQ7zLiGuqjBArZOkF7UBpLEnnPbPCH7Nea3zu9TstckRmC00FKy+G4W2 ENEbw+k1nTIADPLkzT3JBEDXFE5Va4fMIAAvo8KWdMhZAHbQ1C+S9rXgfVFpB45bj7ZlEiKJV S4TgV/IOkq0grOPVdAJvFmBPENGwPltYqeh70ZIa3A2Y2GGaQvglcni30hejMmGsJBezMEDqX crP+A5P18C9tiXaEHBUkwOhhp06LRvodzsoSVgt50mJm4xIrQM/3xochjkNmcITtL3P7pDB5O UUuIz6X43Trn1F6NVDAgNNlOSkN+69CkQeVwoZpc6Hq3DZihvs5EMifC4iIvvDFZYDl4hOxVG inDeWb1NdllB5EVpTDf5SUmsxPQrCPdb/LmVjSItrUDx7yp+F9hgxWP95aM7FCUZBc/56VAAc O2YQ3P3Ia+EDZJXJSw8EdqW9s0UMfP29uEjUvTjnB4UaPJhFn44xT5/BjkqM9zMc+o+9hMcGv KniLAhWq8b+ElonJTBF9sdYf0iD7xSLj7QYBgML8UqoBjulyCGylO7hkSQNFI7aJPIDU69p43 805KlV3/znVyiISBn9VkzwvaRpmCJhTVBeCOAkaIXdjz6kdSk5ApPWguqT3vFdIW4AhFAAvOy 3CCVqHLBjR4ChxO09YO13+z0JKyXk4QlEvry+VpBGoSqMnTCGG2GrjfI7ZGYrdrAIlvCMGTyK RWdH0HK1XOe5WjBF+7Hmgg2UpTWMMyZzdRTgDXvpCeEpUAezdkXKUL85RxmpXgVc9Gx9+eVug jym4+HsekxTWq/nCXtVazhUnSqOXK2Q0lvGjIS/YgjpnwPodLBrITXzXpeOxjY0FLJZ1JRJpz eaNQEQ== Content-Type: text/plain; charset="utf-8" From: Markus Elfring Date: Tue, 26 Dec 2023 08:44:37 +0100 The kfree() function was called in one case by the drm_property_create() function during error handling even if the passed data structure member contained a null pointer. This issue was detected by using the Coccinelle software. Thus use another label. Signed-off-by: Markus Elfring --- drivers/gpu/drm/drm_property.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_property.c b/drivers/gpu/drm/drm_property.c index 596272149a35..3440f4560e6e 100644 --- a/drivers/gpu/drm/drm_property.c +++ b/drivers/gpu/drm/drm_property.c @@ -117,7 +117,7 @@ struct drm_property *drm_property_create(struct drm_dev= ice *dev, property->values =3D kcalloc(num_values, sizeof(uint64_t), GFP_KERNEL); if (!property->values) - goto fail; + goto free_property; } ret =3D drm_mode_object_add(dev, &property->base, DRM_MODE_OBJECT_PROPERT= Y); @@ -135,6 +135,7 @@ struct drm_property *drm_property_create(struct drm_dev= ice *dev, return property; fail: kfree(property->values); +free_property: kfree(property); return NULL; } -- 2.43.0 From nobody Sat Dec 27 01:04:30 2025 Received: from mout.web.de (mout.web.de [212.227.17.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 683DB4D109; Tue, 26 Dec 2023 09:41:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=web.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b="TQpM5jWj" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1703583650; x=1704188450; i=markus.elfring@web.de; bh=QEIlNohXQKR5iUvYT2jHXT8Fr7MmOczXQbaPuHwZhWk=; h=X-UI-Sender-Class:Date:Subject:From:To:Cc:References: In-Reply-To; b=TQpM5jWjeEjOy3EjSwtf1SAHvSY3/EKkaMgeqyAojcHix+Ol95Df2AZHbxQ67cUY WEwVgigF7WIPC0+asLsREnOO3Yp9O8mo7fbqhW0GHNIw/gXSVHZOXlsuVQqlTw9m4 rIQU21eOoGO7JotN4tDcRbL5rol/Q+q74MjIAyl+OQ2sDH/LEH+HQ0tE7aDyhBu4d /7F3JsUBS+cN1gx7bkUxzWLpjk5I3ffK2UQTnnGyXtWxkrGZc/kJamCwra3L3JtDd 4IqvIRPs4mcehGPxF5OB/YFc+rPE0EtcYcua+Z14c4k7H54nu5H3SNxM3AlhUnKMS xUXXL6/2u3/nv38PLQ== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.85.95]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MIc7b-1rWeFb0x1B-00EoEL; Tue, 26 Dec 2023 10:40:50 +0100 Message-ID: <7c6a919c-3757-42af-aee4-3d48721d1959@web.de> Date: Tue, 26 Dec 2023 10:40:48 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 2/3] drm: property: Delete an unnecessary initialisation in drm_property_create() Content-Language: en-GB From: Markus Elfring To: dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org, Daniel Vetter , David Airlie , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann Cc: LKML , cocci@inria.fr References: In-Reply-To: Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:gHRM60fhbiROJai12btJyLRtTcOd7dO9E0nCoV0k4kI2NBX1xi4 7CaFJ2MqRCS3EHB4tsGMJ4lf3o0qYjBCYPC9yunWXgxZ3RwuHNqmmHStQSXiziC5JQgrldI ntssKn3BLAuw3gvZFt3VmkSKemER4GRqnCxY9LZAJ8nLgChA9FZg7Mxxa09u5/yszpHqJzr JakSRCxwcYASditzdkqtA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:BkjCJZF6hJY=;YAGeEr5yQNWL/I6B32iev/AXTMY K70iLvRHsrFwc94MoYkBd111HXgaWlwQbe7Maud0HScN0G8gRhYzuflF7rGfJIrgdBmn+XpC1 wJzhCuMZ+euroE94eqQYF5mNcoYbto0ATvt/fMg1HOl8UtIlCT1AOMEzeoCjHaO83ecnJjmuT yIkILu/nISKhnNR6TxzHeuqDTABwBTx+HbHRj4JWHcH59hcX18wGmdXTnemGEodCsb2aMedxC O2RfXbT7FJX87MtivoxNg6oaLr+O/8FvB2XNcIOfDgwU+l3ocDrZe3miH8+ManMOddsyI05eF SEwMpOt1r1kW9sVuMDaTGHx8b0RMPbeQzteLJTodTRFfuCgYzr8EDdLpCPvhNP5Gu5pKJCEVW Z98J6+x4WuHGpTDxLQWrtSFuP63X+MtpxCB9hV0WrkaWaVHedwANc0uYB2GC0QWWE1IySScxY +qFFiGbn4RW+Eq0hAMXqSr6OJbOwoAZu67AZfHyY2B/mf4EBvdG07ff/JS1s9vpKK2WkuiZo5 veF9ZS29RoNMXGLyYsC6LfSUgiu8NT7O8UYmGMnnV8K2ADAJ9C3WL+ysCw2HIA2Z0ZuAKuB3X fCdlZxJfw5o25nqFaIbhAIMpzDHjR8HcYc3wyxHi7J7YKufp5kP6Fx/lWdH6LDeLPfz6B3I5s OAh41DanF4BYpDVmoyUlSf/+aRjY/2sJVJ6V7uoBTq5rHje7fJlJSK9bFL/F0+hM2uIN68Fun uxjotAQKT0AmdZ1NxzmF83m5H1pjTNEtogtCicNDMbOkXOPX+qBQanFcK+STR82JfOnz1dcaF 0sddd3RBHB9yHk6NvGIbajTzmJGG+0cQ0DvnTgUMkUTQRbDfxflmH3zt8pg9TEspM+ugVv78b 9MTXXdiyv6iCyJiIAAuZtPqUREbZolL5vQlITAgXv82mHaVAnodo4ZCBNEKJcA/zpDuwne3Bg qiEUGA== Content-Type: text/plain; charset="utf-8" From: Markus Elfring Date: Tue, 26 Dec 2023 08:46:12 +0100 The variable =E2=80=9Cproperty=E2=80=9D will eventually be set to an approp= riate pointer a bit later. Thus omit the explicit initialisation at the beginning. Signed-off-by: Markus Elfring --- drivers/gpu/drm/drm_property.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_property.c b/drivers/gpu/drm/drm_property.c index 3440f4560e6e..ea365f00e890 100644 --- a/drivers/gpu/drm/drm_property.c +++ b/drivers/gpu/drm/drm_property.c @@ -98,7 +98,7 @@ struct drm_property *drm_property_create(struct drm_devic= e *dev, u32 flags, const char *name, int num_values) { - struct drm_property *property =3D NULL; + struct drm_property *property; int ret; if (WARN_ON(!drm_property_flags_valid(flags))) -- 2.43.0 From nobody Sat Dec 27 01:04:30 2025 Received: from mout.web.de (mout.web.de [217.72.192.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 344774D5A9; Tue, 26 Dec 2023 09:43:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=web.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b="OzQvbFqf" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1703583764; x=1704188564; i=markus.elfring@web.de; bh=qxz2rsOrCokjtYz9AWLg6FevZKjSyqvDp8Ajz81lcQs=; h=X-UI-Sender-Class:Date:Subject:From:To:Cc:References: In-Reply-To; b=OzQvbFqfkPHkOWRMv/EG0gkcLXqfIXHRdzuZ2803xwm6b85qoIJRuW4P38jCU9yE nJVlEGfwpEBB/BvMU6OawTDqjHZHELozWwwemMbGB3epvfn2Ww0F91jCIcA2gyOFz QVRZ+aKNuTThU943oDclEMyhG1mszpnwOQPx4tAr717TgFhiWH3wo3nWgXKLeHpeQ nrbcHMMttUNWOMxE30h6MoH9/Jj1rgbtevr3+L0I+faicqfkz2KPrMCH0zkueQ6r8 FRzEfzsfrWgfkOb2/CPfXOf4fdwkWwEtf0zqaKyQZrCmOO7XHau9exlcMwKRsaLfw unVe3aSpbl7NYH+nlA== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.85.95]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MV2Ka-1rj3J42GTm-00SCDN; Tue, 26 Dec 2023 10:42:44 +0100 Message-ID: <29dea8dc-5a57-4c07-a857-e2c6a86c5c06@web.de> Date: Tue, 26 Dec 2023 10:42:43 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 3/3] drm: property: Improve four size determinations Content-Language: en-GB From: Markus Elfring To: dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org, Daniel Vetter , David Airlie , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann Cc: LKML , cocci@inria.fr References: In-Reply-To: Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:GtcwZYw63MR0A1EIcUKicxaHVuhNQ4NE2Q9F/CqwM34DRchuZXK wywcZKRJt5lRazac4orphzD6v1YnJl5Gx2no5F6WAVx45dhemxyyqsYntn2KZiH2GapZof/ rz9FtnZZOwYoRSdqlAdEQnPyvIQkxlIr7n5EUsOyN2JY5bbKkRuliS02Cz2PrFDYJPaIGTj HrCoUKRthmVVmEulu76/g== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:G1vrPI0Rpdc=;QUXJ+QZ+PIoZLCYlOQPoWMR5Dbz MbO8uw4uHL36EBNxtaXznGxy7eVhCzGeE5BMH0EbkN98T0dqynLf/J4H/bTNWtAlg2TtLmrA7 A/j30oKy4utgzAgPcxQ/mFFijR2O7NQ/AGscO4ty9Lg3L4FdDXFC+yL2lVMpKBymawiZdlAcd Ygo3GRy0SKU2Nk1jFx+WKymy1Yoo62hQnbqhp/8sLEuev2iNQ67n4lUYkq8XRtohoeVKaZ/2J i6JfJLxXGaovzJzV5oO7xiYvvWfxAshZjlgydx7x2RQLGej1pskudoeHOiDfJXR6G0YTUkEfq dmt+iqlr9v4mRYnwgFLlbbesABN8Abvxre5po9TmwWCwmovyNUj3XJT0fm64PFvBtVEWAqZc4 8xkRQddwlUIDl2glGubJ6gxbxngkPLzLxf5Odds0h3a7cMxAgqxds84bYqanqZK24glTHiejA WqJHBcUxyNekzXi9WjDg0WlrJ1sGFjBEby25o+32xf0ZBsojsIcbaBnZGqFyu3LAtHQSk6E/q duMKPAcShludIo40ghuNhXucU1B6a+OC8SApJNVWDh1pg5TK7uPxbwM3o7AYTYh1m4VWdHl3I PYVG2ffwOxX1E7e+bk1E36Lz9oEiPxyYz/F3AMFEHOYYM4bA0/W5RczRMmbRXyxM5rwyiMgmn nLxBvvPzmMhB3BsEZ/K5Gr2d42VV9MOUUuZ2irWm3QDqymyu6LcCOjDIUJzqyUHUD5nF+aMAD 5svckq7c9exjPooVFIzHI5MBBnoy5Nr6rSQJCQ3y7LbybNJDz07Sja3K3KjMFKxYSt3weyhWU XIDfJxh+SCVlw/eIgHQxKyHpq7ozUNfggCxiB72c/vbUHjfQaW6VSeEUg2OwrUsCzX4+vmufg tevY79rvFjCvZJ4NpYwsUI6Idvoyv1L8S//wk1APpDCoMosiwncme3u7SgG+vMOzdJ4zn2167 7x5Vjw== Content-Type: text/plain; charset="utf-8" From: Markus Elfring Date: Tue, 26 Dec 2023 09:45:36 +0100 Replace the specification of data structures by pointer dereferences as the parameter for the operator =E2=80=9Csizeof=E2=80=9D to make the corr= esponding size determination a bit safer according to the Linux coding style convention. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Reviewed-by: Simon Ser --- drivers/gpu/drm/drm_property.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_property.c b/drivers/gpu/drm/drm_property.c index ea365f00e890..1fe54cbf1c83 100644 --- a/drivers/gpu/drm/drm_property.c +++ b/drivers/gpu/drm/drm_property.c @@ -107,7 +107,7 @@ struct drm_property *drm_property_create(struct drm_dev= ice *dev, if (WARN_ON(strlen(name) >=3D DRM_PROP_NAME_LEN)) return NULL; - property =3D kzalloc(sizeof(struct drm_property), GFP_KERNEL); + property =3D kzalloc(sizeof(*property), GFP_KERNEL); if (!property) return NULL; @@ -418,7 +418,7 @@ int drm_property_add_enum(struct drm_property *property, if (WARN_ON(index >=3D property->num_values)) return -EINVAL; - prop_enum =3D kzalloc(sizeof(struct drm_property_enum), GFP_KERNEL); + prop_enum =3D kzalloc(sizeof(*prop_enum), GFP_KERNEL); if (!prop_enum) return -ENOMEM; @@ -560,10 +560,10 @@ drm_property_create_blob(struct drm_device *dev, size= _t length, struct drm_property_blob *blob; int ret; - if (!length || length > INT_MAX - sizeof(struct drm_property_blob)) + if (!length || length > INT_MAX - sizeof(*blob)) return ERR_PTR(-EINVAL); - blob =3D kvzalloc(sizeof(struct drm_property_blob)+length, GFP_KERNEL); + blob =3D kvzalloc(sizeof(*blob) + length, GFP_KERNEL); if (!blob) return ERR_PTR(-ENOMEM); -- 2.43.0