From nobody Sat Apr 18 22:43:53 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0BD0C43334 for ; Fri, 8 Jul 2022 19:37:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239481AbiGHThn (ORCPT ); Fri, 8 Jul 2022 15:37:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239863AbiGHTha (ORCPT ); Fri, 8 Jul 2022 15:37:30 -0400 Received: from smtp.smtpout.orange.fr (smtp04.smtpout.orange.fr [80.12.242.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A79956D543 for ; Fri, 8 Jul 2022 12:37:29 -0700 (PDT) Received: from pop-os.home ([90.11.190.129]) by smtp.orange.fr with ESMTPA id 9tn4oHtmUEhCQ9tn4okZcQ; Fri, 08 Jul 2022 21:37:28 +0200 X-ME-Helo: pop-os.home X-ME-Auth: YWZlNiIxYWMyZDliZWIzOTcwYTEyYzlhMmU3ZiQ1M2U2MzfzZDfyZTMxZTBkMTYyNDBjNDJlZmQ3ZQ== X-ME-Date: Fri, 08 Jul 2022 21:37:28 +0200 X-ME-IP: 90.11.190.129 From: Christophe JAILLET To: Emma Anholt , Maxime Ripard , David Airlie , Daniel Vetter Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET , dri-devel@lists.freedesktop.org Subject: [PATCH] drm/vc4: Use the bitmap API to allocate bitmaps Date: Fri, 8 Jul 2022 21:37:25 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Use bitmap_zalloc()/bitmap_free() instead of hand-writing them. It is less verbose and it improves the semantic. Signed-off-by: Christophe JAILLET --- drivers/gpu/drm/vc4/vc4_validate_shaders.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_validate_shaders.c b/drivers/gpu/drm/v= c4/vc4_validate_shaders.c index e315aeb5fef5..d074d2014be4 100644 --- a/drivers/gpu/drm/vc4/vc4_validate_shaders.c +++ b/drivers/gpu/drm/vc4/vc4_validate_shaders.c @@ -795,9 +795,8 @@ vc4_validate_shader(struct drm_gem_cma_object *shader_o= bj) =20 reset_validation_state(&validation_state); =20 - validation_state.branch_targets =3D - kcalloc(BITS_TO_LONGS(validation_state.max_ip), - sizeof(unsigned long), GFP_KERNEL); + validation_state.branch_targets =3D bitmap_zalloc(validation_state.max_ip, + GFP_KERNEL); if (!validation_state.branch_targets) goto fail; =20 @@ -939,12 +938,12 @@ vc4_validate_shader(struct drm_gem_cma_object *shader= _obj) (validated_shader->uniforms_size + 4 * validated_shader->num_texture_samples); =20 - kfree(validation_state.branch_targets); + bitmap_free(validation_state.branch_targets); =20 return validated_shader; =20 fail: - kfree(validation_state.branch_targets); + bitmap_free(validation_state.branch_targets); if (validated_shader) { kfree(validated_shader->uniform_addr_offsets); kfree(validated_shader->texture_samples); --=20 2.34.1