From nobody Tue Dec 16 08:51:44 2025 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0096C32A3DA for ; Mon, 15 Dec 2025 08:00:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765785604; cv=none; b=diUOKaVaf09QN5yDgLQRYC459XQ9X2ck6RGRjHDMDWWSzH9t4KPNHWJ6d7BIBeYrQXa9oiEo2tW+ZRn4FkvIDBxkMjxfvFExbx5nOoDAknDgruS8O2oSfU7bvoxkHPR/pgc6O9fanQE+4vyiKUvxOyM/VvG8JvmQXe0/Hq15t3I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765785604; c=relaxed/simple; bh=S+QajaHzhMvLS2JRipW3P7MVgnRieoXf1lQPjPIplP4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UjUov/BYe5bFmmdr4am9vubhpvX7+28N8NUEQ9mADbvm4iEdkLsZDuuMrHKQmJcEtr4TwsAVEI4ZVUNNfHiEotSNr8cJykZtj/2bdmD3rBFM1w8NVlT9SP8Gq2r1wgUtJWYDp8cdMWOCBp39X4Q9P5cAnWWiJ6/rDAANQ/8o9dk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=daqdv/HL; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="daqdv/HL" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2a0834769f0so18663715ad.2 for ; Mon, 15 Dec 2025 00:00:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765785601; x=1766390401; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TVq5X5G8+PFfQeBURVXYlaXATVvipW+nlg+9mMKRKDI=; b=daqdv/HLak7WnGPVjzZR6Nf+fzRvhNxq0Eq/nDAKLJL95Zjr2l8DGeeW9zdF5opnJi Hsy8HDTiEb0o4idj4Fo/l7Da4DilITDIi89gtzPk/OJD4VK6EUrOjlAGIifERuy4QbjV 54gppbVVs3XNUzxeQpNnekTz2yKZxZuZuLDkWMafguFOIW+8sodNCffQaGaSxELQk05S XDB463wk+yhJyGcBVwh4IoBpuPqrh3WGH6PNQFI1yW9XWiRyEn2+3/RFiEFobNdqHxUu GWWnY3RCbw8mQAtPOoxTfJnEQIdM6SMw1hzvpML8s4HdNMk0F/eh20/Rt4jQZQtcbMv6 r2sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765785601; x=1766390401; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=TVq5X5G8+PFfQeBURVXYlaXATVvipW+nlg+9mMKRKDI=; b=sG0SGeufrxUKvlrzk87mY7Ou46W0dEGcXW2jaWXkddRIGtmWB0S551SNMbolnJNVnH CgKrfKGopTLBWCUMVoRnX+oC3Yy628KxVw9bETYNqOK6zfPBHRGO7kNXlg4UN0cW211z k9ciY28+ZC2ZIyP+RVdIUtGj0uFo/hWOU0uPcDbXTjqRKCWzyA2SD7TtTqc3q4YJPyce 3IMr5KY8JR/Gb9BoCcn2tASeDB6zFeAhQCer3JFGKZHPkSmWRLXoTYOHDePcd4DSIlkH 7xTW50DzqCyiPmrmcEBSA3FhftjCc4XTSn33vL9QXmPGU7CbSP4ZgP4Ppw2lsTXC1elr llEA== X-Forwarded-Encrypted: i=1; AJvYcCVw7k2IDFeqw6CH+KMYw27PQQewnEFLfz63g6SZBPk3M10MRrUfKflLB247jcpsbRziuhbWcN9bKSCUN/E=@vger.kernel.org X-Gm-Message-State: AOJu0Yxqjy3GcgMGIYDk/5PK36VXqa7WUTDxbwFUi/E0z0NlAWD+ffK9 2SHPvSRj6qXZcXN7PMHt99OcvgKyEsJ62oNMcenAFAg7tiBzrmGESivu X-Gm-Gg: AY/fxX45Yl1nqTEuxbPdfaJj60iWSbuLcYVZxDNXuOLGLkWLZzO1koUuHN1CPR7X64a EL9hIH1+OXJ0OJCNPgwozYEP6nZMTblnDIMUfyqYglAwUq8x2tj/Dic3W/fHivEqUYyd+dhWHKx oIqbjlSOWaq1Bt+g+3WnKw+J9WChnRxqsbxUPkTa6fzyuy2JFGbPEkRfYEjvfzg86WXmENO/8lC 4vuM3nAQRz7XSk0wU/lOhEURw1vxN7FoCRMFZXAMljDWxjEKUqxjZU0tnWlr+1VMNT743eY6h1q a0yFzLUv2d31IzlLVluoFBLFjCmh1gqjz4U7H3Z7Qyq/8JqJA/oW3lciZgUI+M2Wmv63MNR3gZv mRiazmTO/b7CrKtZwH/mN2j8ZS0USFiWfg4gShIlDwcpZd8o93/AYpd2YhJ0S6RrnRFM2qJCDRU Pu/ldplE42mjY= X-Google-Smtp-Source: AGHT+IH0Z8IA6f60bMQEwqioNDR+p6dck/IMqlctISvchHLxc7gnD0PN55794kLTN3d7b9unB3b+lw== X-Received: by 2002:a05:7022:7f07:b0:119:e56b:91ec with SMTP id a92af1059eb24-11f34bf7bf5mr5063327c88.29.1765785601105; Mon, 15 Dec 2025 00:00:01 -0800 (PST) Received: from fedora ([172.59.162.202]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-11f2e2ff624sm43637473c88.12.2025.12.14.23.59.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Dec 2025 00:00:00 -0800 (PST) From: Alex Tran To: Mauro Carvalho Chehab Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Pavel Machek , Sakari Ailus , Laurent Pinchart , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Alex Tran Subject: [PATCH v2 1/4] media: i2c: et8ek8: et8ek8_driver: add support for crc configuration via device tree Date: Sun, 14 Dec 2025 23:58:32 -0800 Message-ID: X-Mailer: git-send-email 2.51.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Retrieve the configuration for CRC from the device tree instead using the hard coded USE_CRC macro. If there is an issue retrieving the endpoint node or the CRC property then the default of 1 is used and the driver does not fail to maintain backward compatibility. Signed-off-by: Alex Tran --- drivers/media/i2c/et8ek8/et8ek8_driver.c | 49 +++++++++++++++++++----- 1 file changed, 39 insertions(+), 10 deletions(-) diff --git a/drivers/media/i2c/et8ek8/et8ek8_driver.c b/drivers/media/i2c/e= t8ek8/et8ek8_driver.c index 2cb7b7187..4ef92359c 100644 --- a/drivers/media/i2c/et8ek8/et8ek8_driver.c +++ b/drivers/media/i2c/et8ek8/et8ek8_driver.c @@ -29,6 +29,7 @@ #include #include #include +#include #include =20 #include "et8ek8_reg.h" @@ -45,6 +46,7 @@ struct et8ek8_sensor { struct regulator *vana; struct clk *ext_clk; u32 xclk_freq; + u32 use_crc; =20 u16 version; =20 @@ -130,8 +132,6 @@ static struct et8ek8_gain { =20 #define ET8EK8_I2C_DELAY 3 /* msec delay b/w accesses */ =20 -#define USE_CRC 1 - /* * Register access helpers * @@ -844,20 +844,16 @@ static int et8ek8_power_on(struct et8ek8_sensor *sens= or) if (rval) goto out; =20 -#ifdef USE_CRC rval =3D et8ek8_i2c_read_reg(client, ET8EK8_REG_8BIT, 0x1263, &val); if (rval) goto out; -#if USE_CRC /* TODO get crc setting from DT */ - val |=3D BIT(4); -#else - val &=3D ~BIT(4); -#endif + if (sensor->use_crc) + val |=3D BIT(4); + else + val &=3D ~BIT(4); rval =3D et8ek8_i2c_write_reg(client, ET8EK8_REG_8BIT, 0x1263, val); if (rval) goto out; -#endif - out: if (rval) et8ek8_power_off(sensor); @@ -1396,6 +1392,34 @@ static int __maybe_unused et8ek8_resume(struct devic= e *dev) return __et8ek8_set_power(sensor, true); } =20 +static int et8ek8_parse_fwnode(struct device *dev, struct et8ek8_sensor *s= ensor) +{ + struct v4l2_fwnode_endpoint bus_cfg =3D { + .bus_type =3D V4L2_MBUS_CCP2, + }; + struct fwnode_handle *ep; + int ret; + + ep =3D fwnode_graph_get_endpoint_by_id(dev_fwnode(dev), 0, 0, + FWNODE_GRAPH_ENDPOINT_NEXT); + if (!ep) { + dev_warn(dev, "could not get endpoint node\n"); + return -EINVAL; + } + + ret =3D v4l2_fwnode_endpoint_alloc_parse(ep, &bus_cfg); + if (ret) { + dev_warn(dev, "parsing endpoint node failed\n"); + goto done; + } + + fwnode_property_read_u32(ep, "crc", &sensor->use_crc); +done: + v4l2_fwnode_endpoint_free(&bus_cfg); + fwnode_handle_put(ep); + return ret; +} + static int et8ek8_probe(struct i2c_client *client) { struct et8ek8_sensor *sensor; @@ -1406,6 +1430,11 @@ static int et8ek8_probe(struct i2c_client *client) if (!sensor) return -ENOMEM; =20 + sensor->use_crc =3D 1; + ret =3D et8ek8_parse_fwnode(dev, sensor); + if (ret) + dev_warn(dev, "parsing endpoint failed\n"); + sensor->reset =3D devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW); if (IS_ERR(sensor->reset)) { dev_dbg(&client->dev, "could not request reset gpio\n"); --=20 2.51.0