From nobody Mon Feb 9 10:51:53 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EFA01221DB6; Fri, 14 Nov 2025 10:48:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763117291; cv=none; b=SU7yzTBJE6poSSpxtB6tWKwAdQ1GLdOh4l8bNSkHS0Ivezer+Rgu8GlH7m6faxsu05LgwBVcFBjmCm/ImhTaGEsumBozbL6kty10+lSB5EfLTo7mmXgOPc9i3YuGuMaN6mWMpU8v+lckwA/uFa/uo/aVvPyTyGLYbCILhyOzPhc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763117291; c=relaxed/simple; bh=EZwz1bB3XcTruiRfg9BCLAPMvF7j9341FUFoWrsny94=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=txyRjmUFxAWFYdLMzwNzgxsX9kePRjKFMzZn/0kETMsDr6Iu9OHVAejJIuPJ9N1THrwfJJ8k9c3pzp8kCzYqj/XnSosE+v+w/1ZRxteCY+nFoWyaFEPEYpbRDxuxYOh9TF8JPnEGj5LaNpFaoTdl+J1w+9nJOq0uzGZI6JXZILE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id EE180C16AAE; Fri, 14 Nov 2025 10:48:03 +0000 (UTC) From: Geert Uytterhoeven To: Rob Herring , Saravana Kannan , Krzysztof Kozlowski , Conor Dooley Cc: Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Samuel Holland , Marc Zyngier , Lad Prabhakar , Magnus Damm , devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH v2] of/irq: Ignore interrupt parent for nodes without interrupts Date: Fri, 14 Nov 2025 11:47:54 +0100 Message-ID: X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The Devicetree Specification states: The root of the interrupt tree is determined when traversal of the interrupt tree reaches an interrupt controller node without an interrupts property and thus no explicit interrupt parent. However, of_irq_init() gratuitously assumes that a node without interrupts has an actual interrupt parent if it finds an interrupt-parent property higher up in the device tree. Hence when such a property is present (e.g. in the root node), the root interrupt controller may not be detected as such, causing a panic: OF: of_irq_init: children remain, but no parents Kernel panic - not syncing: No interrupt controller found. Commit e91033621d56e055 ("of/irq: Use interrupts-extended to find parent") already fixed a first part, by checking for the presence of an interrupts-extended property. Fix the second part by only calling of_irq_find_parent() when an interrupts property is present. Signed-off-by: Geert Uytterhoeven --- v2: - Split off from series "[PATCH/RFC 0/2] of/irq: Fix root interrupt controller handling"[1] to relax dependencies, - Drop RFC. [1] https://lore.kernel.org/all/cover.1759485668.git.geert+renesas@glider.be --- drivers/of/irq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/of/irq.c b/drivers/of/irq.c index b174ec29648955c6..5cb1ca89c1d8725d 100644 --- a/drivers/of/irq.c +++ b/drivers/of/irq.c @@ -613,7 +613,7 @@ void __init of_irq_init(const struct of_device_id *matc= hes) * are the same distance away from the root irq controller. */ desc->interrupt_parent =3D of_parse_phandle(np, "interrupts-extended", 0= ); - if (!desc->interrupt_parent) + if (!desc->interrupt_parent && of_property_present(np, "interrupts")) desc->interrupt_parent =3D of_irq_find_parent(np); if (desc->interrupt_parent =3D=3D np) { of_node_put(desc->interrupt_parent); --=20 2.43.0