From nobody Sun Feb 8 04:34:42 2026 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A65F23AA1A8 for ; Thu, 15 Jan 2026 17:12:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768497161; cv=none; b=koYLzttVpXwCqUOa3KXpAshDoHKNz1C6fvQanyppwME4DzMSAb82AnWXMGssfQvnbjFDzNIRLjI+grtz7aP3EmBwgnUnxIZ+p700jFfURlrAT4hnNqTGMbbkhOzRwncTNQplnI+amd/dKIBkUVEAx93xcjhs+l3VyQNK75c0xlY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768497161; c=relaxed/simple; bh=w63yj/3XJuKjz144FSyN9g/slARmBLRuU9i9NwK0eJA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kOUYKhA6LTjNy9RObhjX3GCtG4bcjCkD2DgCs0k3K77m7P7+joFb3Xo2cxrG9qfi2BYqEzdqMeVDxF7FYobO6JV9x/WAJWayllN2iLEeSTDEC5UySVFwOgRwXDGZLZ68n/ACpmyflSNPB2Q+woEA9XgjUo9tUMxg8J/ABgugoIQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hiqesj0s; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hiqesj0s" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-47ee807a4c5so8728255e9.2 for ; Thu, 15 Jan 2026 09:12:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768497157; x=1769101957; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wPBVfrUasjXxxiO4appWlnagZh47/ZZDY5dXmpSB7pw=; b=hiqesj0sxvc+us67WpybM7ve5RTeOigkcN84tPQ+/U0teBVX0m7xui94H0JLZGFi4n 05aUqCF8kiifBwtlSAi1Y14KMaS6m/IhIKN0heY4p7YC/p9PfjxuW7zwK9XFjBVq95Jk 1Bx8gnpUkW3Y2LwnMfLV88qE6z8z/cvLdW0CEDHnA7K0cl4EINwQ/SVzSyo9vxDJ71fx 2eDO1p6ELeowzo04obADm80hZNKf+rYUx87oo0JCilwKZbD1tIQnkORMb3413r59oKlb y0B4VB04NeXk9IkwEGEQy+FD1IlCqkKqD1KaOl+vVir+B8hfLD3Hrqu5xxCXqJhYdjQo 2NPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768497157; x=1769101957; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=wPBVfrUasjXxxiO4appWlnagZh47/ZZDY5dXmpSB7pw=; b=aK2VpQFtKuY8VBsOMZgOotbiftzRlyL5YVhv62CXLLZ1m4CUk1KWb3Lvjt7MkTZSjT WWI77GXA1L7AvR5FstQRydwBfhYkTYtnoYprQko/IpIhO8I6qeCyLhxVsVhR+f/905hE gOcXNxMYJ7yyy+YWF8075mKlEMMxjKy0GxWPKwI9B8HTE8ocA6kVQ/XbX4NH9qwT/Gw3 6ip7zXrKUbpY7/s75I5X3ig4vek/LkSRil2ke+y1O3I0bTNrST+yAhtFHjYG0uHIYWye tj2e6O9C1og0gHoRrUzArYbQm5nAwYvd2KspDA3GWskRY6jHIJfgmViaje/6DlCA6rAt Gjkw== X-Forwarded-Encrypted: i=1; AJvYcCXH4cFwOZRYd1SyQYnKyUouh71cg95PNEwXJymjq9HJVh8kDhHHYfQ8KKAiwXs6hjhBx2+EoNOSwQPeRb8=@vger.kernel.org X-Gm-Message-State: AOJu0YwYUmMBkK5YNQQVyfvJMfanMH5dmn/htk5UuOI5Y1Uara9IAPMV YvppX3xsZL2Vk6L1YqxGkGO1qoLyHpVFBFxIH7ny/38jB3ENDG5615Zf X-Gm-Gg: AY/fxX4LUhJqtqiE5r3EuDt+taXAjabYDy5X+NCI16H9aHzQ7WaOHdgJFCVQVCDKjQC c17HSpJsTWVrmz9jsNbKxjPF+cK6QunbldKMwruGW0QV+wF2PkF54iq8AiNeykXYwyHsQvQYxQc IcKWP8tEHrjbFerO72F0Ha9k7+Fbd8YMwAzWNAI4Ol84xw47iLiVq/mWN5Vxc3+UTOe0c71ognh /nR6Jcyr9O0noIG3ab6hmNGqQzcCsGd1Fyyu1EqdWD6GtKXpVTlEeuirhMbpsbLLcHAOzEcy6Hh Ps68s8SsM0pyWcPKXkctyBwGVw/PZRdyl8UTGL+Lmre8VF7bww1bQSTT7UWPHmgwT1VnSUliLnX CE7g4rZA65bC68qa9+PvhLYRAFf+6z6iK+ZDsVr4s8evItFLpCHw1Hx/aBmi5uE9iNNOQ8FJMyB 7InbkzYZ5dZzGZF5PYzTrj5O6xRNewnodkzyUTpCnjrpAi1uf+aBYJAeNYW502I8zhhLEz+vkIm u61YhP1NuTicboZhA== X-Received: by 2002:a05:600c:c08e:b0:477:9b4a:a82 with SMTP id 5b1f17b1804b1-4801e4a38c8mr2774705e9.35.1768497156723; Thu, 15 Jan 2026 09:12:36 -0800 (PST) Received: from 127.mynet ([2a01:4b00:bd21:4f00:7cc6:d3ca:494:116c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47f429071a2sm54741645e9.11.2026.01.15.09.12.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jan 2026 09:12:35 -0800 (PST) From: Pavel Begunkov To: netdev@vger.kernel.org Cc: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jonathan Corbet , Michael Chan , Pavan Chebbi , Andrew Lunn , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Joshua Washington , Harshitha Ramamurthy , Saeed Mahameed , Tariq Toukan , Mark Bloch , Leon Romanovsky , Alexander Duyck , Ilias Apalodimas , Shuah Khan , Willem de Bruijn , Ankit Garg , Tim Hostetler , Alok Tiwari , Ziwei Xiao , John Fraker , Praveen Kaligineedi , Mohsin Bashir , Joe Damato , Mina Almasry , Dimitri Daskalakis , Stanislav Fomichev , Kuniyuki Iwashima , Samiullah Khawaja , Alexander Lobakin , Pavel Begunkov , David Wei , Yue Haibing , Haiyue Wang , Jens Axboe , Simon Horman , Vishwanath Seshagiri , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kselftest@vger.kernel.org, dtatulea@nvidia.com, kernel-team@meta.com, io-uring@vger.kernel.org Subject: [PATCH net-next v9 7/9] eth: bnxt: support qcfg provided rx page size Date: Thu, 15 Jan 2026 17:12:00 +0000 Message-ID: X-Mailer: git-send-email 2.52.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Implement support for qcfg provided rx page sizes. For that, implement the ndo_default_qcfg callback and validate the config on restart. Also, use the current config's value in bnxt_init_ring_struct to retain the correct size across resets. Signed-off-by: Pavel Begunkov --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 36 ++++++++++++++++++++++- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 1 + 2 files changed, 36 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethern= et/broadcom/bnxt/bnxt.c index f011cf792abe..f4f265a25a4a 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -4331,6 +4331,7 @@ static void bnxt_init_ring_struct(struct bnxt *bp) struct bnxt_rx_ring_info *rxr; struct bnxt_tx_ring_info *txr; struct bnxt_ring_struct *ring; + struct netdev_rx_queue *rxq; =20 if (!bnapi) continue; @@ -4348,7 +4349,8 @@ static void bnxt_init_ring_struct(struct bnxt *bp) if (!rxr) goto skip_rx; =20 - rxr->rx_page_size =3D BNXT_RX_PAGE_SIZE; + rxq =3D __netif_get_rx_queue(bp->dev, i); + rxr->rx_page_size =3D rxq->qcfg.rx_page_size; =20 ring =3D &rxr->rx_ring_struct; rmem =3D &ring->ring_mem; @@ -15938,6 +15940,29 @@ static const struct netdev_stat_ops bnxt_stat_ops = =3D { .get_base_stats =3D bnxt_get_base_stats, }; =20 +static void bnxt_queue_default_qcfg(struct net_device *dev, + struct netdev_queue_config *qcfg) +{ + qcfg->rx_page_size =3D BNXT_RX_PAGE_SIZE; +} + +static int bnxt_validate_qcfg(struct bnxt *bp, struct netdev_queue_config = *qcfg) +{ + /* Older chips need MSS calc so rx_page_size is not supported */ + if (!(bp->flags & BNXT_FLAG_CHIP_P5_PLUS) && + qcfg->rx_page_size !=3D BNXT_RX_PAGE_SIZE) + return -EINVAL; + + if (!is_power_of_2(qcfg->rx_page_size)) + return -ERANGE; + + if (qcfg->rx_page_size < BNXT_RX_PAGE_SIZE || + qcfg->rx_page_size > BNXT_MAX_RX_PAGE_SIZE) + return -ERANGE; + + return 0; +} + static int bnxt_queue_mem_alloc(struct net_device *dev, struct netdev_queue_config *qcfg, void *qmem, int idx) @@ -15950,6 +15975,10 @@ static int bnxt_queue_mem_alloc(struct net_device = *dev, if (!bp->rx_ring) return -ENETDOWN; =20 + rc =3D bnxt_validate_qcfg(bp, qcfg); + if (rc < 0) + return rc; + rxr =3D &bp->rx_ring[idx]; clone =3D qmem; memcpy(clone, rxr, sizeof(*rxr)); @@ -15961,6 +15990,7 @@ static int bnxt_queue_mem_alloc(struct net_device *= dev, clone->rx_sw_agg_prod =3D 0; clone->rx_next_cons =3D 0; clone->need_head_pool =3D false; + clone->rx_page_size =3D qcfg->rx_page_size; =20 rc =3D bnxt_alloc_rx_page_pool(bp, clone, rxr->page_pool->p.nid); if (rc) @@ -16087,6 +16117,8 @@ static void bnxt_copy_rx_ring(struct bnxt *bp, src_ring =3D &src->rx_agg_ring_struct; src_rmem =3D &src_ring->ring_mem; =20 + dst->rx_page_size =3D src->rx_page_size; + WARN_ON(dst_rmem->nr_pages !=3D src_rmem->nr_pages); WARN_ON(dst_rmem->page_size !=3D src_rmem->page_size); WARN_ON(dst_rmem->flags !=3D src_rmem->flags); @@ -16241,6 +16273,8 @@ static const struct netdev_queue_mgmt_ops bnxt_queu= e_mgmt_ops =3D { .ndo_queue_mem_free =3D bnxt_queue_mem_free, .ndo_queue_start =3D bnxt_queue_start, .ndo_queue_stop =3D bnxt_queue_stop, + .ndo_default_qcfg =3D bnxt_queue_default_qcfg, + .supported_params =3D QCFG_RX_PAGE_SIZE, }; =20 static void bnxt_remove_one(struct pci_dev *pdev) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.h b/drivers/net/ethern= et/broadcom/bnxt/bnxt.h index 9eaef6d7c150..dc7227a69b7b 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.h +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.h @@ -760,6 +760,7 @@ struct nqe_cn { #endif =20 #define BNXT_RX_PAGE_SIZE (1 << BNXT_RX_PAGE_SHIFT) +#define BNXT_MAX_RX_PAGE_SIZE BIT(15) =20 #define BNXT_MAX_MTU 9500 =20 --=20 2.52.0