From nobody Fri Dec 19 19:20:25 2025 Received: from out-172.mta0.migadu.com (out-172.mta0.migadu.com [91.218.175.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EAEC4335BBE for ; Wed, 17 Dec 2025 07:28:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765956528; cv=none; b=ZwRs9V/UW7Knazcp8nux1SoFAMCwB6fMAFoYlIt4K0jOd73oTCv0kHv6N3g+cv2EWeMN7NOfzX9FVVSpUy8ECREQHnMOkqg4wZPGd4niBDibGUo667wJwMp2qA1pZ5tnvWg6P1hGt54ttHIjJro4X1hXXllpj7f5+shrzvXkmvo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765956528; c=relaxed/simple; bh=Y0Tx92gw19P0/LOqlsVOLK3dXPTBECuL7Q52++0vsHc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YEoErGyG4OFaEnRu72XjQOQdSdRBa4HjLUhG2kCCEwp6OW7Hvrvc3m2kSaQyPqy/jxSDMP/g47WyPnybfW2Q/WUwqgr4DPvGqGlhcza61qcUp8UyOy2fXNnIzkrx2WvWLM3IjdtL2BP/sWtIF/cggfdOAwb0VwfAD/4yQs6QxBI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=qFETWJ3/; arc=none smtp.client-ip=91.218.175.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="qFETWJ3/" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1765956517; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PzAKpbiIZxa6n28+BpnjQ9tXWvyZHSCscw68X1Foo9A=; b=qFETWJ3/QbdSXlWUUX5sj/GLxv/uSjNALIuZ6SkUIGRjkqLuFad+gZwNeXXCVqqGKcwF8m Ph4pcxZJZGxxofIQxCgpMmaoeumjFkDPE/0ZabisZiaJrL0RllkrAspiKspyj++VDnh8vH ee7Bw8gYmx4i0tjC6dQoLoP21p+2XUk= From: Qi Zheng To: hannes@cmpxchg.org, hughd@google.com, mhocko@suse.com, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, david@kernel.org, lorenzo.stoakes@oracle.com, ziy@nvidia.com, harry.yoo@oracle.com, imran.f.khan@oracle.com, kamalesh.babulal@oracle.com, axelrasmussen@google.com, yuanchu@google.com, weixugc@google.com, chenridong@huaweicloud.com, mkoutny@suse.com, akpm@linux-foundation.org, hamzamahfooz@linux.microsoft.com, apais@linux.microsoft.com, lance.yang@linux.dev Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, Muchun Song , Qi Zheng , Chen Ridong Subject: [PATCH v2 01/28] mm: memcontrol: remove dead code of checking parent memory cgroup Date: Wed, 17 Dec 2025 15:27:25 +0800 Message-ID: In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" From: Muchun Song Since the no-hierarchy mode has been deprecated after the commit: commit bef8620cd8e0 ("mm: memcg: deprecate the non-hierarchical mode"). As a result, parent_mem_cgroup() will not return NULL except when passing the root memcg, and the root memcg cannot be offline. Hence, it's safe to remove the check on the returned value of parent_mem_cgroup(). Remove the corresponding dead code. Signed-off-by: Muchun Song Acked-by: Roman Gushchin Acked-by: Johannes Weiner Signed-off-by: Qi Zheng Reviewed-by: Harry Yoo Reviewed-by: Chen Ridong Acked-by: Shakeel Butt --- mm/memcontrol.c | 5 ----- mm/shrinker.c | 6 +----- 2 files changed, 1 insertion(+), 10 deletions(-) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index e2e49f4ec9e0e..ae234518d023c 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -3331,9 +3331,6 @@ static void memcg_offline_kmem(struct mem_cgroup *mem= cg) return; =20 parent =3D parent_mem_cgroup(memcg); - if (!parent) - parent =3D root_mem_cgroup; - memcg_reparent_list_lrus(memcg, parent); =20 /* @@ -3624,8 +3621,6 @@ struct mem_cgroup *mem_cgroup_id_get_online(struct me= m_cgroup *memcg) break; } memcg =3D parent_mem_cgroup(memcg); - if (!memcg) - memcg =3D root_mem_cgroup; } return memcg; } diff --git a/mm/shrinker.c b/mm/shrinker.c index 4a93fd433689a..e8e092a2f7f41 100644 --- a/mm/shrinker.c +++ b/mm/shrinker.c @@ -286,14 +286,10 @@ void reparent_shrinker_deferred(struct mem_cgroup *me= mcg) { int nid, index, offset; long nr; - struct mem_cgroup *parent; + struct mem_cgroup *parent =3D parent_mem_cgroup(memcg); struct shrinker_info *child_info, *parent_info; struct shrinker_info_unit *child_unit, *parent_unit; =20 - parent =3D parent_mem_cgroup(memcg); - if (!parent) - parent =3D root_mem_cgroup; - /* Prevent from concurrent shrinker_info expand */ mutex_lock(&shrinker_mutex); for_each_node(nid) { --=20 2.20.1