From nobody Tue Dec 2 01:50:44 2025 Received: from pidgin.makrotopia.org (pidgin.makrotopia.org [185.142.180.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1EA8296BBB; Thu, 20 Nov 2025 14:17:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.142.180.65 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763648255; cv=none; b=rWxVT2Jf5XCpeNVEZi111QOSEEPxvUSk/y0a5n3yVnQsVtOZkz5GUiWsiZmsuyT03SkS55NVc8xTC5hWo7a3fEinVQSqkXT+uEsTNHVVdJfZgKFSU0rrD9i36F2PiRmEtYlh2UevMaBA1RsgAZfCqrY1alT8tWhqwtwhRQHPMD0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763648255; c=relaxed/simple; bh=8LKrdJ4ZKkAEZnN8+Iyb26NauZMgTMJmm4GgPPiy9FE=; h=Date:From:To:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=tFpO4F3ddkcINotloTMh7wjIO0PCOF9hD9aiKP91NHgIGPGJJRWCs2YmmBSMtCev2KkQJ/AS4EeQAQG8CgxbdD5Wxl+NVNqipJRXKWb3nbY0OVVr2VGU001WvScE6On1jEiLnnkLcBbox3sFakqrnA8Zq153Dojkp5sLvKB86iI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=makrotopia.org; spf=pass smtp.mailfrom=makrotopia.org; arc=none smtp.client-ip=185.142.180.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=makrotopia.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=makrotopia.org Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.98.2) (envelope-from ) id 1vM5TI-000000007eW-27IJ; Thu, 20 Nov 2025 14:17:16 +0000 Date: Thu, 20 Nov 2025 14:17:13 +0000 From: Daniel Golle To: Xu Liang , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Raju Lakkaraju , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net] net: phy: mxl-gpy: fix bogus error on USXGMII and integrated PHY Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" As the interface mode doesn't need to be updated on PHYs connected with USXGMII and integrated PHYs, gpy_update_interface() should just return 0 in these cases rather than -EINVAL which has wrongly been introduced by commit 7a495dde27ebc ("net: phy: mxl-gpy: Change gpy_update_interface() function return type"), as this breaks support for those PHYs. Fixes: 7a495dde27ebc ("net: phy: mxl-gpy: Change gpy_update_interface() fun= ction return type") Signed-off-by: Daniel Golle Reviewed-by: Maxime Chevallier Reviewed-by: Russell King (Oracle) --- drivers/net/phy/mxl-gpy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/phy/mxl-gpy.c b/drivers/net/phy/mxl-gpy.c index 0daf0e86844a0..0058284b08f3b 100644 --- a/drivers/net/phy/mxl-gpy.c +++ b/drivers/net/phy/mxl-gpy.c @@ -541,7 +541,7 @@ static int gpy_update_interface(struct phy_device *phyd= ev) /* Interface mode is fixed for USXGMII and integrated PHY */ if (phydev->interface =3D=3D PHY_INTERFACE_MODE_USXGMII || phydev->interface =3D=3D PHY_INTERFACE_MODE_INTERNAL) - return -EINVAL; + return 0; =20 /* Automatically switch SERDES interface between SGMII and 2500-BaseX * according to speed. Disable ANEG in 2500-BaseX mode. --=20 2.51.2