From nobody Tue Dec 16 19:44:32 2025 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E4393255E3C for ; Fri, 28 Feb 2025 09:36:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740735409; cv=none; b=VxfX58JILIQ4sWWizCfbik9Qh1Mn5C6vD5YTLEJX/+9ekY5XZwXcdPyoCUlsmLgITk/tkw9HuG/IrbYphLdJSMG1H8cumFHZzc31Px5b46az4k5Y9i8YuWq0PBGINDCE4IWNHJP0HhDp7dFkjT2VLVMnNDEKnHWq63mfkohlpAk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740735409; c=relaxed/simple; bh=7OAvh2FzEJjI/bPOiRm69JhriGa3UZoS0poO7GliqrA=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=F94+7XtDS0Dra2cQcIpvdABi0fd6uWKjulDyMF5jJ/5PUGwoIO/B0opxKc8PLXbhqPMu53OJRisqja5ork/qcyOR5I/FVAgYO7B3BBff0V8FgBsgGHJr/AjlxtA1hP/2OkOlODOl0UXcoglggWhx8L43dp0zZ3PBqSa8BkpbOo0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=jbx/IKtM; arc=none smtp.client-ip=209.85.208.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="jbx/IKtM" Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-5dccaaca646so3571721a12.0 for ; Fri, 28 Feb 2025 01:36:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740735406; x=1741340206; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=Ai/hJtxYnguTomii4SP20m0cifXXwklqa40fjptgdsQ=; b=jbx/IKtMNwFb0YjMoUsqedagbGbpoZEJ+WOfrS3YCsBaxPB/SsBo7W5KgliICxLZ3Y 2S0HVkBgyMUnhcWh/tciWvTO5BPhU2gSeODj22nnO0BJ+gmmZyBETxEmuNwGtNcEbEMs yov/fhSNdYh+fKhh6K9HolZC1D2ij2/JXpTcUWRJm6+ilzSia4ZcgWJYJuTLPCDZIQ8z DnFG62suXh5s3vgEpWbXQcVGvIXrGHyr2t5KIMhMpQUHPWNGzf0qrUCKRW75+kNUMOiX A0mIlPeRGuArWPQVNFaIO/hiKDRwu3ekH1GJ0rje9384yNFiDciMfnZfZC8VPHEh/MKp uFtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740735406; x=1741340206; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ai/hJtxYnguTomii4SP20m0cifXXwklqa40fjptgdsQ=; b=WkD4SDgyEqS3eQ9r6rpV7P01odbiY9G6L9xji1dGFWDIe56OAQNInC0fpOU8aKmX89 W4EymtLCnsgjKMztLtCrjCFlvmFUsp7Nb/734QTUclwb6mpxWUavZf+hRB1qT5P0jbPd Zt0BRe5C4Ej/TuNvymnLhYRxq9IKwrrwHLkz9VVkDQlZXHv2/HIkYxp5925pdZj+EE/y 1ffnjG44WwkFh9kpivenLyeYt5EpaIKYSmh2jjr0feyb6l9/rZh5Txtyj66j7NNPEh3l gaQ5b5o2HdfwV9IpKqUn9sC7TwpmJhEs+YbLvGS1WS3u+M2nZ2VzlgY36x/j7xhPCz/h 1kOA== X-Forwarded-Encrypted: i=1; AJvYcCULcU3ZmNGLk8KZhKVKgsjZCXTJ/BEXisAO79bFP2llDokXtfpgAOdXH2cuLjXBIL34n0Ls+yvrx1ruRMM=@vger.kernel.org X-Gm-Message-State: AOJu0YznJpNk4Htz87eJiI6ir1AobqkbF1Z10n74r0tUVuj7zqyL6NXF GwI0Wx5NkiEanXpcW/YEh0VDG4zTqPAG48uTqcpg61wf+Jh4nWAOMTm5DGbKFb0= X-Gm-Gg: ASbGncuiO3KnXUm4EsIeHB7QG+kiHK8ODm0GMXYOKlIbtS/nehwQTKTIFSc9Rx4e6Rz T7wK/5WjAdrYGH60PDjDEaqOdEQWB7f7TxwVG4jSGZxClbnNfGsi7u8SeTeKOP+XZeu0LvbL+Cp 04fKgBh7WupCso9N0tPGFgeacF5QfKR0PKu8tHXnhBJROYf6CSGWb9ICh7+7/4A9kjPiENT8n6U OUzSSWG+2rLssY9EKxRRgLOhYW/bvDxyBoIDl+FhWgK1rjtzd9Zcefdmeyh0TRY343lhYaDTVNP f2ElSTf/OB+cNY3yVZQd3X7g+WK3Ecs= X-Google-Smtp-Source: AGHT+IGm7vDtQOlmQzD7ukOLgUjBw4xij3s9uP3Fz/LVXmcLAJBxgStvGxHWCueyPd6neqkamka0Xw== X-Received: by 2002:a05:6402:280a:b0:5e4:d6aa:82ed with SMTP id 4fb4d7f45d1cf-5e4d6aa8563mr2073071a12.12.1740735406137; Fri, 28 Feb 2025 01:36:46 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id 4fb4d7f45d1cf-5e4c3bb7386sm2278113a12.43.2025.02.28.01.36.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 01:36:45 -0800 (PST) Date: Fri, 28 Feb 2025 12:36:42 +0300 From: Dan Carpenter To: Antoniu Miclaus Cc: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH next] iio: adc: ad4851: Fix signedness bug in ad4851_calibrate() Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The "c" variable is used to store error codes from ad4851_find_opt() so it has to be signed for the error handling to work. Change it to type int. Fixes: 6250803fe2ec ("iio: adc: ad4851: add ad485x driver") Signed-off-by: Dan Carpenter Reviewed-by: Nuno S=C3=A1 --- Btw, in ad4851_write_raw() there are some checks for negative but the multiplication could still wrap and turn negative so we might want to add an upper bounds as well: drivers/iio/adc/ad4851.c:826 ad4851_write_raw() warn: potential integer overflow from user 'val * st->osr' drivers/iio/adc/ad4851.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/adc/ad4851.c b/drivers/iio/adc/ad4851.c index 1ad37084355e..98ebc853db79 100644 --- a/drivers/iio/adc/ad4851.c +++ b/drivers/iio/adc/ad4851.c @@ -492,11 +492,11 @@ static int ad4851_find_opt(const unsigned long *field= , unsigned int start, static int ad4851_calibrate(struct iio_dev *indio_dev) { struct ad4851_state *st =3D iio_priv(indio_dev); - unsigned int opt_delay, num_lanes, delay, i, s, c; + unsigned int opt_delay, num_lanes, delay, i, s; enum iio_backend_interface_type interface_type; DECLARE_BITMAP(pn_status, AD4851_MAX_LANES * AD4851_MAX_IODELAY); bool status; - int ret; + int c, ret; =20 ret =3D iio_backend_interface_type_get(st->back, &interface_type); if (ret) --=20 2.47.2