From nobody Mon Feb 9 01:45:25 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B323BEB64DD for ; Tue, 11 Jul 2023 05:55:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229468AbjGKFzi (ORCPT ); Tue, 11 Jul 2023 01:55:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229871AbjGKFz0 (ORCPT ); Tue, 11 Jul 2023 01:55:26 -0400 Received: from mail.208.org (unknown [183.242.55.162]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 70604E4D for ; Mon, 10 Jul 2023 22:55:04 -0700 (PDT) Received: from mail.208.org (email.208.org [127.0.0.1]) by mail.208.org (Postfix) with ESMTP id 4R0VSv4fc8zBHXhj for ; Tue, 11 Jul 2023 13:54:55 +0800 (CST) Authentication-Results: mail.208.org (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=208.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=208.org; h= content-transfer-encoding:content-type:message-id:user-agent :references:in-reply-to:subject:to:from:date:mime-version; s= dkim; t=1689054895; x=1691646896; bh=aOK/vrvHGfxYdmaAFZxDnwb5Czx 72k5Aa/iRkuEQeqU=; b=iTEWhZ6tMGIEqDb4mhgQ29Lun6USjSVBcIOwBvbgExI WvhUHZTQThMy1zg3m69nCieYDRJoRr0nyYvi0liW/gxApwjhhidQ7y/UMgybYiJ4 vHqIYWA2HmDm/XzxqdQLRgBvJJOzrHH+I8WujuVurblPT7FiqioNE0TD0GPhGB78 r68MkmmEswb9oErbwnxooA9B8fr1RHEGQLPZwfhkxZB66696Ik1rHeoOTrBTL8gR cFrAoPZVRvplcIkX7KM5bqDPRohUtWcPmBZNdH7teLy/S5SY0uvi9RXsRHkaaWlt IE68cihlAti/VaGVhHxcHoZgiQqx4onSeMEQSrcuJ1w== X-Virus-Scanned: amavisd-new at mail.208.org Received: from mail.208.org ([127.0.0.1]) by mail.208.org (mail.208.org [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id flqgRdcjKQ4y for ; Tue, 11 Jul 2023 13:54:55 +0800 (CST) Received: from localhost (email.208.org [127.0.0.1]) by mail.208.org (Postfix) with ESMTPSA id 4R0VSv1lnQzBHXgj; Tue, 11 Jul 2023 13:54:55 +0800 (CST) MIME-Version: 1.0 Date: Tue, 11 Jul 2023 13:54:55 +0800 From: sunran001@208suo.com To: airlied@gmail.com, daniel@ffwll.ch Cc: dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/nouveau/flcn/cmdq: Move assignment outside if condition In-Reply-To: <20230711055304.79441-1-xujianghui@cdjrlc.com> References: <20230711055304.79441-1-xujianghui@cdjrlc.com> User-Agent: Roundcube Webmail Message-ID: X-Sender: sunran001@208suo.com Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8"; format="flowed" Fixes the following checkpatch errors: ERROR: do not use assignment in if condition Signed-off-by: Ran Sun --- drivers/gpu/drm/nouveau/nvkm/falcon/cmdq.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/falcon/cmdq.c=20 b/drivers/gpu/drm/nouveau/nvkm/falcon/cmdq.c index 211ebe7afac6..a8beb55097a6 100644 --- a/drivers/gpu/drm/nouveau/nvkm/falcon/cmdq.c +++ b/drivers/gpu/drm/nouveau/nvkm/falcon/cmdq.c @@ -203,7 +203,8 @@ nvkm_falcon_cmdq_new(struct nvkm_falcon_qmgr *qmgr,=20 const char *name, { struct nvkm_falcon_cmdq *cmdq =3D *pcmdq; - if (!(cmdq =3D *pcmdq =3D kzalloc(sizeof(*cmdq), GFP_KERNEL))) + cmdq =3D *pcmdq =3D kzalloc(sizeof(*cmdq), GFP_KERNEL); + if (!cmdq) return -ENOMEM; cmdq->qmgr =3D qmgr;