From nobody Wed Apr 8 12:13:05 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6141FECAAA1 for ; Sun, 11 Sep 2022 10:46:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230207AbiIKKp5 (ORCPT ); Sun, 11 Sep 2022 06:45:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56780 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230204AbiIKKpt (ORCPT ); Sun, 11 Sep 2022 06:45:49 -0400 Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5F787220EA for ; Sun, 11 Sep 2022 03:45:46 -0700 (PDT) Received: by mail-ed1-x533.google.com with SMTP id z21so8907480edi.1 for ; Sun, 11 Sep 2022 03:45:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date; bh=BiDnhWQR6g6Mj6136/H/ZREAE6myEKa/wQMFwuUDLyQ=; b=eRATwTDb4tdZl8oa9NPKs8lcb0bCZCR2qPAK+hhwflqa+1bjo8vEqFT62P2dNrR91T VeG7EAcrDCeBLmtLmiVar8MHMUJM1ZNd2Pnocpo/BN52kAqshEQ2wyMYA40CPCpQ5Reo l9j6MvTe+woEFXtCuCeXES9JoWfzA2aNKsQ0E87nBzTPEzRp0d0GOPKMWkeTHLHhSXfo a/kzf3+FFNVamDb18sry+56J+4y7Z/SMBUGZtTAhDDtO3s1n+vhwyb701vygyeim9boG aUxHVthaozlWrdFHvZmMxap/ElLmqOXGpkXzff8Za7Bu6p3nnLk/649NKsggI9leQ0x9 mjfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=BiDnhWQR6g6Mj6136/H/ZREAE6myEKa/wQMFwuUDLyQ=; b=TTyUex1XrPWqu70NawE+0SvW412IkUwVuqrpr4xEs5bymw5JuK2IqmxwQHjhYp2pV8 Lu+CR0ts7OKe0WOmkx3qLCqkHRNFhPhQG2vgUWS5oWpCK1vBtAqW9taFmwR0WLJW6cmi yAPv2gfNr8b8s8i4/1jjQPVwYsuu2twbFv0Vpq9PBLCutDcosb8UJ/DY8Xghlv2zf8qw psCg0NU5/wT6aLOjFzdPsqPimNy5jREsB8LCtbEUGArtITPTuYnyiJvq1ga9KROiJRbG mU5ujF6dteWe5kR+frPKcLAu3RFRwdnqdFv52tvd+8DQnlaX8kQXhZhCtyVWzDTCdkq4 wciw== X-Gm-Message-State: ACgBeo2POCw9lucgFum1IKcmGphozexE/wOdMeOFpAP/uoKcdgNgciWw 0LkgxXZVh9rxeL4jqkFkEkmsiPzZ3so= X-Google-Smtp-Source: AA6agR7diDymzbq2G68+mWq3Lvc6HGGKCvrDd/8LzkIi42v4ywsAulBhrUOfN+7r9ZDHAVhpeGASXQ== X-Received: by 2002:a05:6402:254b:b0:451:2b1d:d82c with SMTP id l11-20020a056402254b00b004512b1dd82cmr8013158edb.343.1662893144040; Sun, 11 Sep 2022 03:45:44 -0700 (PDT) Received: from matrix-ESPRIMO-P710 (p57ba2cf5.dip0.t-ipconnect.de. [87.186.44.245]) by smtp.gmail.com with ESMTPSA id e7-20020a170906314700b007708130c287sm2840318eje.40.2022.09.11.03.45.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 03:45:43 -0700 (PDT) Date: Sun, 11 Sep 2022 12:45:42 +0200 From: Philipp Hortmann To: Forest Bond , Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 02/12] staging: vt6655: Cleanup and rename function MACvSaveContext Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename function MACvSaveContext to vt6655_mac_save_context to avoid CamelCase which is not accepted by checkpatch.pl. Remove unnecessary declaration of function and make function static. Change declaration of cxt_buf to shorten code. Signed-off-by: Philipp Hortmann --- drivers/staging/vt6655/mac.c | 6 +++--- drivers/staging/vt6655/mac.h | 1 - 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/vt6655/mac.c b/drivers/staging/vt6655/mac.c index 567bc38ecfa9..092b1fffcfa1 100644 --- a/drivers/staging/vt6655/mac.c +++ b/drivers/staging/vt6655/mac.c @@ -14,7 +14,7 @@ * vt6655_mac_set_short_retry_limit - Set 802.11 Short Retry limit * MACvSetLongRetryLimit - Set 802.11 Long Retry limit * vt6655_mac_set_loopback_mode - Set MAC Loopback Mode - * MACvSaveContext - Save Context of MAC Registers + * vt6655_mac_save_context - Save Context of MAC Registers * MACvRestoreContext - Restore Context of MAC Registers * MACbSoftwareReset - Software Reset MAC * MACbSafeRxOff - Turn Off MAC Rx @@ -181,7 +181,7 @@ static void vt6655_mac_set_loopback_mode(struct vnt_pri= vate *priv, u8 loopback_m * Return Value: none * */ -void MACvSaveContext(struct vnt_private *priv, unsigned char *cxt_buf) +static void vt6655_mac_save_context(struct vnt_private *priv, u8 *cxt_buf) { void __iomem *io_base =3D priv->port_offset; =20 @@ -303,7 +303,7 @@ bool MACbSafeSoftwareReset(struct vnt_private *priv) * reset, then restore register's value */ /* save MAC context */ - MACvSaveContext(priv, abyTmpRegData); + vt6655_mac_save_context(priv, abyTmpRegData); /* do reset */ bRetVal =3D MACbSoftwareReset(priv); /* restore MAC context, except CR0 */ diff --git a/drivers/staging/vt6655/mac.h b/drivers/staging/vt6655/mac.h index f7d00a251677..1752905d7df0 100644 --- a/drivers/staging/vt6655/mac.h +++ b/drivers/staging/vt6655/mac.h @@ -553,7 +553,6 @@ void vt6655_mac_set_short_retry_limit(struct vnt_privat= e *priv, unsigned char re =20 void MACvSetLongRetryLimit(struct vnt_private *priv, unsigned char byRetry= Limit); =20 -void MACvSaveContext(struct vnt_private *priv, unsigned char *cxt_buf); void MACvRestoreContext(struct vnt_private *priv, unsigned char *cxt_buf); =20 bool MACbSoftwareReset(struct vnt_private *priv); --=20 2.37.3