From nobody Wed Apr 8 12:36:39 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1863C6FA82 for ; Fri, 2 Sep 2022 21:40:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231279AbiIBVks (ORCPT ); Fri, 2 Sep 2022 17:40:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229716AbiIBVkb (ORCPT ); Fri, 2 Sep 2022 17:40:31 -0400 Received: from mail-qk1-x736.google.com (mail-qk1-x736.google.com [IPv6:2607:f8b0:4864:20::736]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B0BF43E744 for ; Fri, 2 Sep 2022 14:40:22 -0700 (PDT) Received: by mail-qk1-x736.google.com with SMTP id f14so2805681qkm.0 for ; Fri, 02 Sep 2022 14:40:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=a/6y1tnbijdXc5qSMdd4IK5j90OSsiP2sEjvKMKEBTI=; b=K6w/ph2YvbrAoqqGMdDTbzaJxkU/GCskA/gO5HYUyptfDzMuD/PCZN1AbjYE3Gz7kp 4qog5itKarci+dzN0DwAog50b8cVEWazuo1qmQbyjZzx4E7UdlnoZWRUB/dwB5pHj3v8 dqf50X1ggz6hSRBfL7zG0xJ6GyDhVmlADQKfkdiJUXCX4J4Wu51qxWaHi5XmELZEqF+3 KOdG549A38ufAzxL+PHq59/SFtS3W4i9tr9FaiKwl7dyXHUpYW7EXoBAoKMWyWLMRs0r X2dref2ucuJ9yK/mW1v3ZguZpL9hmvpWKa64EWt++3TyJTjV0/wCRB8Ef5MH1ai19vZh txcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=a/6y1tnbijdXc5qSMdd4IK5j90OSsiP2sEjvKMKEBTI=; b=7GMrfvqK0xwbCs0LP4VPFsodQTn9ECriqZR4xL+oaU+2uz1HRS1GVTctW5tgIBKNJl cOZKtu7TGXj1PXOJ64OXGESQO+lBN4gBhcsT2ysR9cqsz5AT6dxL65t8iqnW4iFOWCoX Wo/17K20BofpbgQjyQdCn3eLJb9ac/uDy/AzHwU38xe7rM1jNLIU7uZvGPuzXW7tt3jb tvLS6uHIRZyhHec1vYBJ7V7bIEGxN8oRwlQtSXiUHEhtvj5U/fRwd3r76iHcv3s57T4N /bfLImodFFoRnYn0Ygu2vesZrdFL53bxP8pFMHa5Zyq/ICHTmLRzIvd9T02s/DOAWrax V8VQ== X-Gm-Message-State: ACgBeo3r6J2f5pZ/G7iPqh7i7f6AD3U5s2iNBUIWEpAyUO4BIo4KFCgZ aASmQZv/0+Kvif1LmDYc3wR12A== X-Google-Smtp-Source: AA6agR6OyuWkqksbnk9o2odwFhmHjE3fR48VDFM11LQr6zwHpcQ+2cXpaK5b2lZ0sKIUAtzPPBNrgA== X-Received: by 2002:ae9:e841:0:b0:6b9:c69e:ac99 with SMTP id a62-20020ae9e841000000b006b9c69eac99mr24436570qkg.450.1662154821173; Fri, 02 Sep 2022 14:40:21 -0700 (PDT) Received: from fedora.attlocal.net (69-109-179-158.lightspeed.dybhfl.sbcglobal.net. [69.109.179.158]) by smtp.gmail.com with ESMTPSA id 15-20020ac84e8f000000b0031f0b43629dsm1819533qtp.23.2022.09.02.14.40.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Sep 2022 14:40:20 -0700 (PDT) From: William Breathitt Gray To: brgl@bgdev.pl, linus.walleij@linaro.org Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, William Breathitt Gray Subject: [PATCH 4/4] gpio: ws16c48: Make irq_chip immutable Date: Fri, 2 Sep 2022 13:45:26 -0400 Message-Id: X-Mailer: git-send-email 2.37.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Kernel warns about mutable irq_chips: "not an immutable chip, please consider fixing!" Make the struct irq_chip const, flag it as IRQCHIP_IMMUTABLE, add the new helper functions, and call the appropriate gpiolib functions. Signed-off-by: William Breathitt Gray --- drivers/gpio/gpio-ws16c48.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/gpio/gpio-ws16c48.c b/drivers/gpio/gpio-ws16c48.c index b098f2dc196b..59fb10641598 100644 --- a/drivers/gpio/gpio-ws16c48.c +++ b/drivers/gpio/gpio-ws16c48.c @@ -265,6 +265,7 @@ static void ws16c48_irq_mask(struct irq_data *data) raw_spin_lock_irqsave(&ws16c48gpio->lock, flags); =20 ws16c48gpio->irq_mask &=3D ~mask; + gpiochip_disable_irq(chip, offset); port_state =3D ws16c48gpio->irq_mask >> (8 * port); =20 /* Select Register Page 2; Unlock all I/O ports */ @@ -295,6 +296,7 @@ static void ws16c48_irq_unmask(struct irq_data *data) =20 raw_spin_lock_irqsave(&ws16c48gpio->lock, flags); =20 + gpiochip_enable_irq(chip, offset); ws16c48gpio->irq_mask |=3D mask; port_state =3D ws16c48gpio->irq_mask >> (8 * port); =20 @@ -356,12 +358,14 @@ static int ws16c48_irq_set_type(struct irq_data *data= , unsigned flow_type) return 0; } =20 -static struct irq_chip ws16c48_irqchip =3D { +static const struct irq_chip ws16c48_irqchip =3D { .name =3D "ws16c48", .irq_ack =3D ws16c48_irq_ack, .irq_mask =3D ws16c48_irq_mask, .irq_unmask =3D ws16c48_irq_unmask, - .irq_set_type =3D ws16c48_irq_set_type + .irq_set_type =3D ws16c48_irq_set_type, + .flags =3D IRQCHIP_IMMUTABLE, + GPIOCHIP_IRQ_RESOURCE_HELPERS, }; =20 static irqreturn_t ws16c48_irq_handler(int irq, void *dev_id) @@ -463,7 +467,7 @@ static int ws16c48_probe(struct device *dev, unsigned i= nt id) ws16c48gpio->chip.set_multiple =3D ws16c48_gpio_set_multiple; =20 girq =3D &ws16c48gpio->chip.irq; - girq->chip =3D &ws16c48_irqchip; + gpio_irq_chip_set_chip(girq, &ws16c48_irqchip); /* This will let us handle the parent IRQ in the driver */ girq->parent_handler =3D NULL; girq->num_parents =3D 0; --=20 2.37.2