From nobody Mon Feb 9 20:36:58 2026 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BFA962BE7D6 for ; Thu, 22 Jan 2026 13:02:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.165.32 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769086979; cv=fail; b=jklWA/k1F/ZzEGfKncpNOemJVjDvWWaGDSTvc1K/T+j/sEm+yS0k2J9k5dA66v0Q/7rBGheEptLzEe23sn3lwCRmYXmgB0tWDpfA845kFR5b3jrdasOq6LvU94wK3GR+c9s2oTQST276Tn4l1yyRlLlmLHKMIRpiToXddO/CxBE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769086979; c=relaxed/simple; bh=hlNrNdCg/kgMjPHZkZBJ4wW9F0fGLAy1pA4egMZm0/g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=TbdPdogjMTLZm0dIelyogK4W/ZKBDCaq+TjmUmaQp4RqYVHCe9HBVHjG4tNE5SqwxJwyZVsKu6Al+9VrmHSG/dCzze8zJxtMDQOiUcLnAQV4XO8BGdPlliue7jEyyQtTo6gVi3rSnfW5zC9sa8LUrFTC1/BG4ztEWhISbtQ6qXE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=oq62KpqZ; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b=RMEIkI4s; arc=fail smtp.client-ip=205.220.165.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="oq62KpqZ"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="RMEIkI4s" Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60LNL0OJ3266582; Thu, 22 Jan 2026 13:02:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= corp-2025-04-25; bh=0omcCeG05KRpcGsbKGwuo55GUCBvKXjddLZ8sGvO8sA=; b= oq62KpqZJw0f9nPd4jlOpB+G7gBipqb2OUxrabBfd8KWf/XQeIDcjXjaZ885ZARR TOpE3QP+Tr1w+EHLVC8zdvczJZ/qXBQcB3NLDvwv5xz5KzcJrDxhJzxaMXcyWdVQ mJfhzh2Ewdy/IeZsRo6/udtuXe7KJVsSBRxeaeVYWk0Pi8vAoAYMJz9RYkFfaxSi w7W+nmvv/KS5xgr53Isapiu0T+7AyXoN+tB47zCKQQ+rxU6ikQa6AiiDwXAhu6GK BCgXkes7Rl8mhpZNSSDRU13WYE7KAn0519euJcp+1nS/Dc0gweCkyc+i94+9WsKb SnEvXah6VGx+KECoFogvow== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 4br1b8fp77-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 22 Jan 2026 13:02:18 +0000 (GMT) Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 60MCSauv015510; Thu, 22 Jan 2026 13:02:17 GMT Received: from ch4pr04cu002.outbound.protection.outlook.com (mail-northcentralusazon11013060.outbound.protection.outlook.com [40.107.201.60]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 4br0vct7gd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 22 Jan 2026 13:02:17 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=byjo0qBhHVz0Z4B6l/o+0KoO/ZQEW5LoTq0YSm6w0uQ4uHC46lYm+ux7kErDz00kW42U9niuApoVAHAuRMM4nTmNr2Z3AYgwXWVgfGZdUhd4/Dk87zNU7sueRWc1lsyHqsMNek3lf035z+2WNTVgzsY3mLgYb84LBUX4FetHi0udVs3aPdtAYEDTLxuGTb0FTnKHA2Sjjod3Z/dPpu6S2Yy5tPpn0ajiYFIVHEmGTr9sQgAKTbb08f6Ry4pnCJyA5V4WM+pPXuDvWrV6oFFNs7mamuJmeGIfpESyRO/8DghNq2HcBWFNa2ioAzRyREq504eAfHfVdmjKJW1HM1012A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0omcCeG05KRpcGsbKGwuo55GUCBvKXjddLZ8sGvO8sA=; b=wMmfA2Hm40fRB4oU9hEHRuliE7tmmVhkbWITkNGy4ENUL2xnkhAx8V6IZJck30UZnr1e+Rr8/Dx5vCFg3R9WjPIvZoBjmI0IIxEeKtKoWJOVAjLwwVDkiJri9odsMPJWnnAYXoUCNPEbGay+BolftR1fAfIdGPsvdhLmH1hT3uuDe4nHS8vaLBfZmp1Hj4oxgWg9TF7I1DrLi9PsvFG8VoPg3cvWbq01Y+BXbogfsMp8EFTMnhfW2SgdYvCiWrrYJuXfsDG/zg/LUa9ISx7jDkP4K0WhRpxa6VjQRHu4E/56gJTENzr9IPbtT0foQDN3rd0oAMvKn/JnoIR6jQObAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0omcCeG05KRpcGsbKGwuo55GUCBvKXjddLZ8sGvO8sA=; b=RMEIkI4smHSrwkBQ92OnEjImZKMFKcEMWysP5GJn+BPbesITS1NDjNyX/93OQPKnWDBYSIpXBo8iPfDdzOgZb7XD5xoaGfGAdSBJFno0sp7enUDfXMkBFmI2zwvt51L4KBBk2KAC4dWcUFcQ3REvXpT3o3AFpJqG9cYUkE6KCLw= Received: from BL4PR10MB8229.namprd10.prod.outlook.com (2603:10b6:208:4e6::14) by DS0PR10MB8198.namprd10.prod.outlook.com (2603:10b6:8:1f4::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9542.9; Thu, 22 Jan 2026 13:02:14 +0000 Received: from BL4PR10MB8229.namprd10.prod.outlook.com ([fe80::552b:16d2:af:c582]) by BL4PR10MB8229.namprd10.prod.outlook.com ([fe80::552b:16d2:af:c582%6]) with mapi id 15.20.9520.005; Thu, 22 Jan 2026 13:02:14 +0000 From: Lorenzo Stoakes To: Andrew Morton Cc: David Hildenbrand , "Liam R . Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Shakeel Butt , Jann Horn , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-rt-devel@lists.linux.dev, Peter Zijlstra , Ingo Molnar , Will Deacon , Boqun Feng , Waiman Long , Sebastian Andrzej Siewior , Clark Williams , Steven Rostedt Subject: [PATCH v3 06/10] mm/vma: clean up __vma_enter/exit_locked() Date: Thu, 22 Jan 2026 13:01:58 +0000 Message-ID: X-Mailer: git-send-email 2.52.0 In-Reply-To: References: Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: LO2P265CA0021.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:62::33) To BL4PR10MB8229.namprd10.prod.outlook.com (2603:10b6:208:4e6::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL4PR10MB8229:EE_|DS0PR10MB8198:EE_ X-MS-Office365-Filtering-Correlation-Id: 7a0d77a7-d92c-4346-6c1b-08de59b6767b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?RkV/fdWtGZQ38lSrfpL73fRiEVKOHIisE7RX//owUGG4y1amWhf6ZeV3STj9?= =?us-ascii?Q?ycbJDTax/PQY9h5TsEIVkpEx9uo6ToLqBLm2hTtFj28ETd/oqh8vOzTXU9HE?= =?us-ascii?Q?0q89/e+6noYYjRlV9WJUJOGMsN57GqPzlWHOdmXNExtGu8ip5LfiTOFyPHd0?= =?us-ascii?Q?UmvEcvKfDRr8AzGECKPzC6Ot5byYLbjPkBl6OQ+oTrNQkHGL1jNyIeHFWhDf?= =?us-ascii?Q?djMk46zFKJhjT1dWBZClZHhEknnl7X+Qx+TOOPMzoguxK7ZIWo9ib1HW78F8?= =?us-ascii?Q?1iTuc2XbeRKKw3ltiYS7l73jn6yWCeYvO+HoHuPY/SWgpY4no8OU2y1cLDnm?= =?us-ascii?Q?XM8P7xPAq5wcaddJRX70HXHDmwVXaQAyqG36qy0GdmvaXZ0aeKuKZbZrx1EC?= =?us-ascii?Q?wl4aVC7sS7KKbMgfHbABwWguMQvY/vX8GP/zep0o0FIn9jgglBYqw37ZnhO+?= =?us-ascii?Q?qbLYwt8hzvXLoMbiDcBpOdlIDKldeQRKbACGbI4vVoaNbnSnYx0sxd5k+q4/?= =?us-ascii?Q?j1zgy1C63/xZn5KuBCrnJFtdebxDiOfNUpbgCB4I1QGKXI+Gc3RK3lNOBBeh?= =?us-ascii?Q?5cdc3qC4/rly9BESJ04a052PhTd2mN9z6GDVAA2YyfqEt4wF8IDoatd5Vup1?= =?us-ascii?Q?rOeyJkE+8gxwPivwdZO1+Ab/SZ9WCTLy+kKR9F/gsCQcT5xzjqSM4y8Y8ZGk?= =?us-ascii?Q?TAK9ReamNWl4uWJt1lLRsljTTrF9rhv2t6alci+Enya9oK4x4aHHAwkynZ86?= =?us-ascii?Q?h3VgOHAp1/o0OeDQE1nfZrLtzv9eqIyHwWe4aTEt+uDVIukKADGXnDLDYvmI?= =?us-ascii?Q?R4ljOM142Z9npV/eflPGw2jW36f3MGvo297Tlw1mnmB2+JkxzYGuq2PM1rb9?= =?us-ascii?Q?1vCs4xnRvfZBnNwAnRLf/GyH8ZCwxKRIygrEz8J+Bs2shAS1UdKP7ciTxEtF?= =?us-ascii?Q?l7tW1HDAcpRX0hkD+9T1iTEnS6UOiMnL1iMfoOivyaUzBFBwinHbhepI1P+8?= =?us-ascii?Q?Bs4/pma2IlreTWeuyjyUWmTYhxJIVgb5G23JOmyWlX0BeJZ84NsfEdtQLcNl?= =?us-ascii?Q?iyWfAQSVqEXN7M4YKJPu13r2i6yo4nZX6otpuQ01ETkLGPnIg7NbOsjGIzFJ?= =?us-ascii?Q?h3LVpcIt8kQCQDonhPTqWjYBa+ktpM3F/oIkTRGiv4yB/F9M/JhQxdSjs5hH?= =?us-ascii?Q?Y1ARhgYt32QKjO43gvxg+qPdopI+N/hXMqf9beuvJ5QVAC5vllOytcdltY8O?= =?us-ascii?Q?3qgbaFRDqoALLsaP/peNko91BP4S06d1TBZRlRGC+HSfAYwpwL0McqvNm3T3?= =?us-ascii?Q?sYSptcrVJ9xiZfH3nxOZk3WSjPv57HUSQa1OYsYgaIO9Bvm86fQR5dxEzXBV?= =?us-ascii?Q?qIyvswUbTTm8tzl32paIKbh2t2SxtXxVOmX3/XUO5EJIDLhw9YPH/1Z0DBWS?= =?us-ascii?Q?/AOGdYRSu4XFqVeIV9O4VOR+j1vct1iomCgWEoCCCO6JXSDAL9/MJvPtUB2A?= =?us-ascii?Q?TD60C0847VeLRhUs+6bNSw9TJW1o8+qA1QLaC8bR0YHLG25OZh421flo4+NV?= =?us-ascii?Q?C+KLp14x0gQ+hrGiwVk=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL4PR10MB8229.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(1800799024)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?z7dtLJPXIaZbg8QBKIOptRPOatIHgI15YAgnCgGlebrDse+ZwioQ3VTR13CZ?= =?us-ascii?Q?nS30d2bxb/Rtd2bJ6qqaYlFOOyNszYY8Nlspw+7DjJU8QB/Mizzng+lNt2a7?= =?us-ascii?Q?tOXpHoaG+lO+oV7d6RHZWOgJ9nPLEyxOEc3Kh71PCyXtpgIa6hatw/N9g84x?= =?us-ascii?Q?+/6FP+DtPyeqcBInV6JNkzXBxyxnRv00kpEVvCskApkO04h2zweyPjrwkUk2?= =?us-ascii?Q?778WQ6g7H7iLVRqbbW4DuBuOSUd4njOYkBfH4srLnC9eDJw8Wn0LEt6xsGir?= =?us-ascii?Q?rCmqbSrjYjsEne6olpfgTgHE8uz7zlVZVtPMLB4j2NRGDAyLrjMAVLRoSli5?= =?us-ascii?Q?r0x40IlKs9jeVlCdw6QPVzkiEYd+7TaRxfYaJ7ngggg/tZBarJUc6vsNFtfJ?= =?us-ascii?Q?VZn4dOuE2ysP9TYL/CU2lAWjFYG6HFd/My3WPMnHkC57KSvCT7MK5Fk5u15k?= =?us-ascii?Q?Co0QIUXxTUYBcl7lbeMGyi0QBpbncGrIEMHORkWg4OtQX8syzOpzwLXOnoXJ?= =?us-ascii?Q?dgJ8iGSMSk1hlXN+17tizEb8xzsbOpPjZH/xXjCvq9Hz0mWxfNprUqZc1ZBO?= =?us-ascii?Q?R5iTG1djD19rXkrPpRbCexkM+sbwD8ntOrsFgOxQQjmmHDMm6lMb2Wlq+YL5?= =?us-ascii?Q?hdrUWUQ2iNoV/ZVOa55rkj4cNTOkbkoSVkMZzE+ICSFKM7birCCUiRNTE0xy?= =?us-ascii?Q?wy6jNl4ntSe0IeMpd4d7ecbMbC7kvkEeb9e6AZbsZm87xbfzph6i1T3I68RX?= =?us-ascii?Q?pbil6reOyWKER+cjqmQ43lx0QbrgxIODdJ2Y6/GOupfkIdxrqluXN8vb2X9k?= =?us-ascii?Q?QvadEyPrBSfbzUdxjjUIsfmPM7nd7CxLbvJHzf/agk+WTf/mes2wk46U72Dz?= =?us-ascii?Q?F4fAaw3UnT3NIOnAbXQNB9zeYpD3v9yIMm3+sl6glcW4y/C9D77ljZzUSFSB?= =?us-ascii?Q?yL/tTxacxe/FGF78bNz7Q0Gh/xSGUOYAwL8yCjMuwi6saml+3tPUwUZ9cvNt?= =?us-ascii?Q?zzNB3VGTpMjlmkkE2EobLAOLsbSjLn/eZRZ6220Ph427fNpX3IeWEz7fsxyH?= =?us-ascii?Q?e+iDhI8MPkk9pm5yP48xIZl5bxiuLFhgaZuGhiVGuIUXFR9i0I4BJ3575Dxq?= =?us-ascii?Q?9U4K5z0TiRdduMlugVVCNBzKaj5nVoCkfusoDSsEMrdBn1zHYtQyc5L70GyS?= =?us-ascii?Q?Ews8B28RGwOkXaKhcPX7/KNkXYUgeaHTV8H2fLdnHskcCU5InX1EcmBPO/sF?= =?us-ascii?Q?HyI1V77X3PkPb2XW4b74SAYxzDlmd4VgWXDa8u996Khc/1OizESz6RH37uog?= =?us-ascii?Q?XRkA527gJJ5N7eLUYxwBjnOhV+uQclrJtXO/92eOQt3/NKD5smjuEe5ZxS/7?= =?us-ascii?Q?AXt2eMHcAVp7GsvaqQb3s6n0a2Eea/Wp61aq7Enca3uDJxKPZ/U+vN8U9sxv?= =?us-ascii?Q?svvi2aivJ51dUK94ycnJ0VpiDWwQj6v2MGK2bumIYY3unSkHD8jAj2sEVf+2?= =?us-ascii?Q?zsh5kX51/XQmZlLuY3NI4LyRByJdyZcwLfCJEj3qS94k2Bcgzomvr8S4fhAv?= =?us-ascii?Q?u2QtUQe1EGWDCK7yv1+47HE1n15SND206FHiOvLjdMPoVd6zQP/7UIoPKi5G?= =?us-ascii?Q?Pah5EgWbm07fbIAM6vp0dbaiDLqHGRVWvliehuIVkj8MOuTkxBwUB15kVhzS?= =?us-ascii?Q?gYa8o5IwFNY6bIMNJKCZYJbCXeUqJuzJ9mKU/JFv+BtaSj+PDVWgWOZPi7ji?= =?us-ascii?Q?xO6fjU7x3AS03L2PXkIAApdd1aPxTd4=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: ISjdyzEmHEF9l4yRM2i6UGAugMryhs2YlrjHPvLU3v49GFUq0c3xoeX7smGqLSLxBkGKgqixFwIVaNFumFGg8U0iVLhnOzRGmsVBg3DnI9hN0mfGR201kwglnOwoUuFsHgCCUmXQJ17MbZq2unsmkUX0FV2tCTMD+WIybEdr3BJC+KkosBMoMBeIa4NxzvHFI1FyiWrXKMve6De7XDyhhlX/nD0vUko0famMyiiRB5LcALoLZEG2nHSTDiMWvhlfuwDFuAzwjKpzryVV0KaHNO97prwSmQsE45Vy5Frd6NGAq1orWHeGuTwPwXW5Y7fCQPv+5vfSj4kBPW7dt6teH0KB9wgjsw6V7THEKGNQY5YH6QUuoJUPLx4COBVFXNLkVNdOrOA83kNVXNajgDNJTin/byLj4AZkiFzwgGw7l0h14fxHRwfz02QEay+bGvPW2SFKK0ugoQ97tmpOJgRizFKD3/qRCVrsdxz1eNdeMrKR41s9NE8+zSkkf4xH+QpAkpPwdQbbUzB+PmrLCbjxJEXq9dzTZpkyF8QG3GelJRfXdQqiLNtXbj/Qd+g2LvYZ/QLZkaASRkM93LjtEy7O2QOu4qNQ9MWTUUylFV9/NDE= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7a0d77a7-d92c-4346-6c1b-08de59b6767b X-MS-Exchange-CrossTenant-AuthSource: BL4PR10MB8229.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jan 2026 13:02:14.1007 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Ynjn0alwasoiKJl6G2ncOwRydvoIhwoOhOtWia/DCkN0mk5o9qiII+x55iiVH9fXo4LKbgO1bdd1ZU8aBWamc23dnTyzbIegMyNvCxdyGG0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB8198 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.20,FMLib:17.12.100.49 definitions=2026-01-22_01,2026-01-22_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0 adultscore=0 phishscore=0 suspectscore=0 spamscore=0 mlxlogscore=999 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2601150000 definitions=main-2601220097 X-Authority-Analysis: v=2.4 cv=WbcBqkhX c=1 sm=1 tr=0 ts=69721fda cx=c_pps a=XiAAW1AwiKB2Y8Wsi+sD2Q==:117 a=XiAAW1AwiKB2Y8Wsi+sD2Q==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=vUbySO9Y5rIA:10 a=GoEa3M9JfhUA:10 a=VkNPw1HP01LnGYTKEx00:22 a=yPCof4ZbAAAA:8 a=Qfc5p1S1sjZ_rCI9KBYA:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTIyMDA5NiBTYWx0ZWRfX4HuLlOoG0Bpc Sr+7W5d4OMhBxFyc5FN7NRO8emLdNEdTq1gMjCYej7u/24+zLgkT1krWx68KgHukrrvSDTMMw3I mTXQTncSclyS960hj81ggV0D3/uoAxn7O15vxL+6IwR/n/Z9+PcrY9DkhPlwy+9QunDks3GVv/L CloPUkmt45oGHDB+yeddYX8nF/Q2ok5CgnwsctsMgKEtGN4jepiB+S7KjoghWDOGywQho9BTtp6 ef4qL8bz8mcyic3v5KVHyc6sw9kYnEjbv5JPxFp9wqo8ry2A0oiZy1lF+vNOJ3A1HRCaWlrn1Ez y3tFMrCcKMdBN/fmyzW6kR6bdswiQ0abVb8WlrNSwXIqeR5EImu7nCRcC/MBEpqysLt/D7rHOWf H4ra/CoXSJKFjwpWGbmiAigJs2eN7I/nwXTWHnFerimgWNmrrXit8X9eKMwpKkM81RQ1t1Nd/f8 82cmCLwRlEE4/NVlCfA== X-Proofpoint-ORIG-GUID: GBhTocysMjmLMakwYqRZQvWz40n60i_6 X-Proofpoint-GUID: GBhTocysMjmLMakwYqRZQvWz40n60i_6 Content-Type: text/plain; charset="utf-8" These functions are very confusing indeed. 'Entering' a lock could be interpreted as acquiring it, but this is not what these functions are interacting with. Equally they don't indicate at all what kind of lock we are 'entering' or 'exiting'. Finally they are misleading as we invoke these functions when we already hold a write lock to detach a VMA. These functions are explicitly simply 'entering' and 'exiting' a state in which we hold the EXCLUSIVE lock in order that we can either mark the VMA as being write-locked, or mark the VMA detached. Rename the functions accordingly, and also update __vma_exit_exclusive_locked() to return detached state with a __must_check directive, as it is simply clumsy to pass an output pointer here to detached state and inconsistent vs. __vma_enter_exclusive_locked(). Finally, remove the unnecessary 'inline' directives. No functional change intended. Signed-off-by: Lorenzo Stoakes --- include/linux/mmap_lock.h | 4 +-- mm/mmap_lock.c | 60 +++++++++++++++++++++++++-------------- 2 files changed, 41 insertions(+), 23 deletions(-) diff --git a/include/linux/mmap_lock.h b/include/linux/mmap_lock.h index da63b1be6ec0..873bc5f3c97c 100644 --- a/include/linux/mmap_lock.h +++ b/include/linux/mmap_lock.h @@ -209,8 +209,8 @@ static inline void vma_refcount_put(struct vm_area_stru= ct *vma) __vma_lockdep_release_read(vma); detached =3D __vma_refcount_put(vma, &refcnt); /* - * __vma_enter_locked() may be sleeping waiting for readers to drop - * their reference count, so wake it up if we were the last reader + * __vma_enter_exclusive_locked() may be sleeping waiting for readers to + * drop their reference count, so wake it up if we were the last reader * blocking it from being acquired. */ if (!detached && are_readers_excluded(refcnt)) diff --git a/mm/mmap_lock.c b/mm/mmap_lock.c index 7a0361cff6db..f73221174a8b 100644 --- a/mm/mmap_lock.c +++ b/mm/mmap_lock.c @@ -46,19 +46,43 @@ EXPORT_SYMBOL(__mmap_lock_do_trace_released); #ifdef CONFIG_MMU #ifdef CONFIG_PER_VMA_LOCK =20 -static inline void __vma_exit_locked(struct vm_area_struct *vma, bool *det= ached) +/* + * Now that all readers have been evicted, mark the VMA as being out of the + * 'exclude readers' state. + * + * Returns true if the VMA is now detached, otherwise false. + */ +static bool __must_check __vma_exit_exclusive_locked(struct vm_area_struct= *vma) { - *detached =3D refcount_sub_and_test(VM_REFCNT_EXCLUDE_READERS_FLAG, - &vma->vm_refcnt); + bool detached; + + detached =3D refcount_sub_and_test(VM_REFCNT_EXCLUDE_READERS_FLAG, + &vma->vm_refcnt); __vma_lockdep_release_exclusive(vma); + return detached; } =20 /* - * __vma_enter_locked() returns 0 immediately if the vma is not - * attached, otherwise it waits for any current readers to finish and - * returns 1. Returns -EINTR if a signal is received while waiting. + * Mark the VMA as being in a state of excluding readers, check to see if = any + * VMA read locks are indeed held, and if so wait for them to be released. + * + * Note that this function pairs with vma_refcount_put() which will wake u= p this + * thread when it detects that the last reader has released its lock. + * + * The state parameter ought to be set to TASK_UNINTERRUPTIBLE in cases wh= ere we + * wish the thread to sleep uninterruptibly or TASK_KILLABLE if a fatal si= gnal + * is permitted to kill it. + * + * The function will return 0 immediately if the VMA is detached, and 1 on= ce the + * VMA has evicted all readers, leaving the VMA exclusively locked. + * + * If the function returns 1, the caller is required to invoke + * __vma_exit_exclusive_locked() once the exclusive state is no longer req= uired. + * + * If state is set to something other than TASK_UNINTERRUPTIBLE, the funct= ion + * may also return -EINTR to indicate a fatal signal was received while wa= iting. */ -static inline int __vma_enter_locked(struct vm_area_struct *vma, +static int __vma_enter_exclusive_locked(struct vm_area_struct *vma, bool detaching, int state) { int err; @@ -85,13 +109,10 @@ static inline int __vma_enter_locked(struct vm_area_st= ruct *vma, refcount_read(&vma->vm_refcnt) =3D=3D tgt_refcnt, state); if (err) { - bool detached; - - __vma_exit_locked(vma, &detached); - if (detached) { + if (__vma_exit_exclusive_locked(vma)) { /* * The wait failed, but the last reader went away - * as well. Tell the caller the VMA is detached. + * as well. Tell the caller the VMA is detached. */ WARN_ON_ONCE(!detaching); err =3D 0; @@ -108,7 +129,7 @@ int __vma_start_write(struct vm_area_struct *vma, unsig= ned int mm_lock_seq, { int locked; =20 - locked =3D __vma_enter_locked(vma, false, state); + locked =3D __vma_enter_exclusive_locked(vma, false, state); if (locked < 0) return locked; =20 @@ -120,12 +141,9 @@ int __vma_start_write(struct vm_area_struct *vma, unsi= gned int mm_lock_seq, */ WRITE_ONCE(vma->vm_lock_seq, mm_lock_seq); =20 - if (locked) { - bool detached; - - __vma_exit_locked(vma, &detached); - WARN_ON_ONCE(detached); /* vma should remain attached */ - } + /* vma should remain attached. */ + if (locked) + WARN_ON_ONCE(__vma_exit_exclusive_locked(vma)); =20 return 0; } @@ -145,12 +163,12 @@ void vma_mark_detached(struct vm_area_struct *vma) detached =3D __vma_refcount_put(vma, NULL); if (unlikely(!detached)) { /* Wait until vma is detached with no readers. */ - if (__vma_enter_locked(vma, true, TASK_UNINTERRUPTIBLE)) { + if (__vma_enter_exclusive_locked(vma, true, TASK_UNINTERRUPTIBLE)) { /* * Once this is complete, no readers can increment the * reference count, and the VMA is marked detached. */ - __vma_exit_locked(vma, &detached); + detached =3D __vma_exit_exclusive_locked(vma); WARN_ON_ONCE(!detached); } } --=20 2.52.0