From nobody Wed Sep 10 03:14:28 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C966AC64EC7 for ; Sat, 25 Feb 2023 18:20:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229613AbjBYSU4 (ORCPT ); Sat, 25 Feb 2023 13:20:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57658 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229610AbjBYSUy (ORCPT ); Sat, 25 Feb 2023 13:20:54 -0500 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 26F701026E for ; Sat, 25 Feb 2023 10:20:47 -0800 (PST) Received: by mail-wr1-x42b.google.com with SMTP id h14so2316976wru.4 for ; Sat, 25 Feb 2023 10:20:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1677349245; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=YAkY5lWd2mIuBvpl4SjoFin1YMe8Z/rLiJhwo7Z2OPc=; b=B1eiWnexElXDHgwxS0+ddCOgB6pVW1iCzuLqe9IQsIaawvDHDf8sQCGPGOdeDgkRzk GHWiYS2TQRx5xKZYU/3gTF2EfdvT/yHtxUsOdpr/h7ITgmWiwZn0Rd9ucpHZREuSFl/C DpYD8hkPzGGD4FljPbw8/iIpvWt7bRikJjEyPp0h8g0iw+BBDQHFYlfcGR3Q78+YkOJh 2Uye0zwyDE2XZUuz9G4ApxzV6uz5Q5Y6ktdb/mNzEM0upTiT2JRJYqqJ/veKMJl79sAS nnOSN1ADN4jONNGrdc8UGbXVZROK4pfTj4977Co/PoAxWHvQ+byLxawvNMFJrR4XfxXu RrSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677349245; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YAkY5lWd2mIuBvpl4SjoFin1YMe8Z/rLiJhwo7Z2OPc=; b=HKntwYK93HK4f5KA4XXJPPcld2YaONz2M3q2vLYSVmvDu7oFJEcsFdX/NoQtYkghCi +VgNj1600MDVODtcnWzrLs7DRJXYbpzsVe0MDsjFWy5SOJAZnB4W1Z15zbUVXf/87mnq hDq9rD/3aRK4uLL8wf9uN8g4LFAxzzr5t+dHb8EPpEApIOYjNAe37aM8/RYe6fw7Q6qF 1A/oog6Il3wQIkQ0x6OdglK077Phot5ymo5UavCGJLKe4wuqyt25cKK39mt7v24k6a61 zBJG47jHWLZMQcg0r6EQEdqS4xUsKSQ8Ozt9eMIEkf7eCYJAwWeS7V9aCzN19odkuiC5 mAcA== X-Gm-Message-State: AO0yUKU+7sXYJpCD6EeMe6nmji76yWr8Gh3oTyCrpTb6kx/JHXkUZfk+ fY1KLlMeD2c8OEyPvEMf8nc= X-Google-Smtp-Source: AK7set/7mZeQBjNSPHLMZWfPKrfwHMZh8Wlq1RFqWrNIjqW9Y5gq/FQTC9gR7uzFPbfo7xTYdmUtRA== X-Received: by 2002:a5d:6a8e:0:b0:2c7:1c72:69ac with SMTP id s14-20020a5d6a8e000000b002c71c7269acmr3880175wru.2.1677349245596; Sat, 25 Feb 2023 10:20:45 -0800 (PST) Received: from matrix-ESPRIMO-P710 (p57935146.dip0.t-ipconnect.de. [87.147.81.70]) by smtp.gmail.com with ESMTPSA id f12-20020adffccc000000b002c705058773sm2352715wrs.74.2023.02.25.10.20.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Feb 2023 10:20:45 -0800 (PST) Date: Sat, 25 Feb 2023 19:20:41 +0100 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 3/4] staging: rtl8192e: Remove checks of pointer to stop_send.. and rtllib_.. Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Function pointers of stop_send_beacons and rtllib_ips_leave_wq is set while executing the probe function. Therefore a NULL pointer check is not required. Remove checks as it is dead code. Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtllib_softmac.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rt= l8192e/rtllib_softmac.c index b06baf5ff6d4..7b73c5df5e2a 100644 --- a/drivers/staging/rtl8192e/rtllib_softmac.c +++ b/drivers/staging/rtl8192e/rtllib_softmac.c @@ -659,8 +659,7 @@ static void rtllib_beacons_stop(struct rtllib_device *i= eee) =20 void rtllib_stop_send_beacons(struct rtllib_device *ieee) { - if (ieee->stop_send_beacons) - ieee->stop_send_beacons(ieee->dev); + ieee->stop_send_beacons(ieee->dev); if (ieee->softmac_features & IEEE_SOFTMAC_BEACONS) rtllib_beacons_stop(ieee); } @@ -728,8 +727,7 @@ EXPORT_SYMBOL(rtllib_act_scanning); /* called with ieee->lock held */ static void rtllib_start_scan(struct rtllib_device *ieee) { - if (ieee->rtllib_ips_leave_wq !=3D NULL) - ieee->rtllib_ips_leave_wq(ieee->dev); + ieee->rtllib_ips_leave_wq(ieee->dev); =20 if (IS_DOT11D_ENABLE(ieee)) { if (IS_COUNTRY_IE_VALID(ieee)) @@ -1584,8 +1582,7 @@ static void rtllib_associate_procedure_wq(void *data) rtllib_stop_scan(ieee); HTSetConnectBwMode(ieee, HT_CHANNEL_WIDTH_20, HT_EXTCHNL_OFFSET_NO_EXT); if (ieee->rf_power_state =3D=3D rf_off) { - if (ieee->rtllib_ips_leave_wq !=3D NULL) - ieee->rtllib_ips_leave_wq(ieee->dev); + ieee->rtllib_ips_leave_wq(ieee->dev); mutex_unlock(&ieee->wx_mutex); return; } --=20 2.39.2