From nobody Sat Apr 18 10:52:22 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8D76C43334 for ; Thu, 14 Jul 2022 16:46:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240448AbiGNQqJ (ORCPT ); Thu, 14 Jul 2022 12:46:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42850 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240467AbiGNQps (ORCPT ); Thu, 14 Jul 2022 12:45:48 -0400 Received: from mail3.swissbit.com (mail3.swissbit.com [176.95.1.57]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F5EC6871D; Thu, 14 Jul 2022 09:44:20 -0700 (PDT) Received: from mail3.swissbit.com (localhost [127.0.0.1]) by DDEI (Postfix) with ESMTP id 98A2A462034; Thu, 14 Jul 2022 18:44:09 +0200 (CEST) Received: from mail3.swissbit.com (localhost [127.0.0.1]) by DDEI (Postfix) with ESMTP id 7C95D46166E; Thu, 14 Jul 2022 18:44:09 +0200 (CEST) X-TM-AS-ERS: 10.149.2.84-127.5.254.253 X-TM-AS-SMTP: 1.0 ZXguc3dpc3NiaXQuY29t Y2xvZWhsZUBoeXBlcnN0b25lLmNvbQ== X-DDEI-TLS-USAGE: Used Received: from ex.swissbit.com (SBDEEX02.sbitdom.lan [10.149.2.84]) by mail3.swissbit.com (Postfix) with ESMTPS; Thu, 14 Jul 2022 18:44:09 +0200 (CEST) Received: from sbdeex02.sbitdom.lan (10.149.2.84) by sbdeex02.sbitdom.lan (10.149.2.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.9; Thu, 14 Jul 2022 18:44:08 +0200 Received: from sbdeex02.sbitdom.lan ([fe80::e0eb:ade8:2d90:1f74]) by sbdeex02.sbitdom.lan ([fe80::e0eb:ade8:2d90:1f74%8]) with mapi id 15.02.1118.009; Thu, 14 Jul 2022 18:44:08 +0200 From: Christian Loehle To: =?utf-8?B?Q2hyaXN0aWFuIEtvaGxzY2jDvHR0ZXI=?= , Robin Murphy , Markus Reichl , =?utf-8?B?SGVpa28gU3TDvGJuZXI=?= , "linux-arm-kernel@lists.infradead.org" , "linux-rockchip@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Linux MMC List Subject: RE: [PATCH v2] arm64: dts: rockchip: Fix SD card init on rk3399-nanopi4 Thread-Topic: [PATCH v2] arm64: dts: rockchip: Fix SD card init on rk3399-nanopi4 Thread-Index: AQHYl56CKm68niEykEeE+sqK07QWzK1+EKag Date: Thu, 14 Jul 2022 16:44:08 +0000 Message-ID: References: <12878108.O9o76ZdvQC@diego> <103b714c-b07c-f016-1062-84bd94786b22@arm.com> <9AF1E75F-5947-49B0-887D-82C426527B99@kohlschutter.com> <590f7a08-a6ca-be54-4254-363343642a52@arm.com> In-Reply-To: Accept-Language: en-US, de-DE Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.153.3.44] Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-TMASE-Version: DDEI-5.1-9.0.1002-27016.001 X-TMASE-Result: 10--3.063700-10.000000 X-TMASE-MatchedRID: QfHZjzml1E/RbDQWs/vjTP7FEhWgo0y89u0so3sONfgSgmfkOsgfKrCN 7xgFqHGJ7DBK8KB1N1/CABvr2i15oWjb3BwZs8hXrMZ+BqQt2NrUtXfJ7mutAbV5fSMRD1zquxW P7AlD8NMORPqUJpjuj+NSIM1P3ba035n3zfl6vmuyAEyENeP8ZafV6VlwBmU0tU0lCTMMyfCJzv yP4u0tgCqq0O5S3DJ8YASlu1An0J4v+0FNnM7lDQPZZctd3P4BrOCEGIPhtwiYb2HRMAdbi4uVC Dz2gMcK4vM1YF6AJbY9l7H+TFQgdY2j49Ftap9EOwBXM346/+yeBqJ8tFEKajjrYa78T5wg3BzY WenF8C5oZumtA5oTaFO4kVfDSJaF X-TMASE-SNAP-Result: 1.821001.0001-0-1-22:0,33:0,34:0-0 X-TMASE-INERTIA: 0-0;;;; X-TMASE-XGENCLOUD: 30397a4e-fd32-4b05-8ccc-83571dca0cc6-0-0-200-0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" I only briefly skimmed the discussion, but does this mean that a soft-reset= (CMD0) of a UHS (post-voltage-switch) will not work? (As the card/spec requires a power-cycle by the host which will not come, r= ight?) Can you try this real quick? I can give you a mmc-utils snippet if you have= trouble issuing one. If that does indeed not work I think the general approach is to disable uhs= in the dts or at least document that. Regards, Christian -----Original Message----- From: Christian Kohlsch=C3=BCtter =20 Sent: Donnerstag, 14. Juli 2022 18:27 To: Robin Murphy ; Markus Reichl ; Heiko St=C3=BCbner ; linux-arm-kernel@lists.infradea= d.org; linux-rockchip@lists.infradead.org; linux-kernel@vger.kernel.org; Li= nux MMC List Subject: [PATCH v2] arm64: dts: rockchip: Fix SD card init on rk3399-nanopi4 mmc/SD-card initialization may fail on NanoPi r4s with "mmc1: problem reading SD Status register" / "mmc1: error -110 whilst initialising SD card" Moreover, rebooting would also sometimes hang. This is caused by the gpio entry for the vcc3v0-sd regulator; even though it appears to be the correct GPIO pin, the presence of the binding causes these errors. Fix the regulator to drop the gpio binding and add a comment to prevent accidental reintroduction of that entry. Signed-off-by: Christian Kohlsch=C3=BCtter --- arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi b/arch/arm64/= boot/dts/rockchip/rk3399-nanopi4.dtsi index 8c0ff6c96e03..d5f8a62e01be 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi @@ -67,7 +67,7 @@ vcc1v8_s3: vcc1v8-s3 { vcc3v0_sd: vcc3v0-sd { compatible =3D "regulator-fixed"; enable-active-high; - gpio =3D <&gpio0 RK_PA1 GPIO_ACTIVE_HIGH>; + // gpio =3D <&gpio0 RK_PA1 GPIO_ACTIVE_HIGH>; // breaks SDHC card support pinctrl-names =3D "default"; pinctrl-0 =3D <&sdmmc0_pwr_h>; regulator-always-on; --=20 2.36.1 Hyperstone GmbH | Reichenaustr. 39a | 78467 Konstanz Managing Director: Dr. Jan Peter Berns. Commercial register of local courts: Freiburg HRB381782