From nobody Mon Dec 1 22:02:20 2025 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6727730595D for ; Thu, 27 Nov 2025 19:43:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764272601; cv=none; b=GEndeEQ+hkOMGpE9MKA4p9IDs4td2ErsPaEyf7RkEs3n6VofGDJQVkAFKcObNt2VjXZ+U7eznQRG5gUvhMvSaw/YzYaKhnPPokVx4bIwrJcMnO7lE6Oe1kEIrfEDBMJ/HBS1PSzBj+lwAyPFEhNLZ/vpBYH+FgvuIFW4XH1/WHw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764272601; c=relaxed/simple; bh=fMPj8SNqMb29+rp5s+Tbolc5LKQcSwrYL0ChEEr0BTU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jZdjHTEglPjS6NaVht0sVwKPSSJLIfsY+niyaEQMCPIzpTyOGhwh+rJZ06u8xkule79uI0khVwLL+oULgQKBXh8fh6VIYmsFPEADQ4y4VkTod7WVgzoXFN3qPG6jvv/7mJ3marj6/4HQNpBpwkzbY4mLu8Rv6Oi5fCfRDNEBKT0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=chrisdown.name; spf=pass smtp.mailfrom=chrisdown.name; dkim=pass (1024-bit key) header.d=chrisdown.name header.i=@chrisdown.name header.b=hHLLU1x/; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=chrisdown.name Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chrisdown.name Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chrisdown.name header.i=@chrisdown.name header.b="hHLLU1x/" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-7a9c64dfa8aso940281b3a.3 for ; Thu, 27 Nov 2025 11:43:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisdown.name; s=google; t=1764272600; x=1764877400; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=62oszKtbMVcmPtjkpujwdwUrbNKTrHvNdAV+VDipINM=; b=hHLLU1x/WfLxx4m6ZJPpPnkj6nb1H/c5THDEzhhdHeEbencpj57GnMvM1AS9A4IjPz NhIToyEBu4hh1xTiD1o4+cET5BaRCgCA+JQ8+Z6QSUHwykprz5Fv3/sCTrQ4Z1s8/9Nc IkFYG8FPN50b5UWLX9rf4kcebs9Nwovr5VTb8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764272600; x=1764877400; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=62oszKtbMVcmPtjkpujwdwUrbNKTrHvNdAV+VDipINM=; b=heVlRZS/9VeSGu+nTuXdPdME7eT/8fCTzsMjtqSO9smsFqjp4d6USzNeIrMFcCha3L bd0GgK50lwlG6+JJuIgZWhZ/cDASknK7S3KURxwihPhdljOxfUOmF6KgSk656iUIqoTY K9s/CMcjB+txsurjP0mePCYeKyybxnfHf49QjZb2GThboj0Kdk/RrGHPt+knVqqirLCG fsTyAZJccGboY6vNIe3ONxYqDBDMKr2NxbIHSHVCjrHgXK5gAI+FhZmhnFPIVf/DpT5c BxBqJMc4LVd2DF0ch3FS5DPQ36aEGHjHPYHxMekpcrqAR2KDRdqBVUs/GO3AEN4fWJ1G hOjw== X-Gm-Message-State: AOJu0Yygp9JG1Pv8ZoYTcloTfUocKs4zvEAakVrJJPIlcxbPA7SpTaXc o/mvKXRbZMb/ezlxr5ffhgU6+h8M8VR6lnRCeeqDY/Yd2xBUViQbxq7879UW82Dca9o= X-Gm-Gg: ASbGnctkprukB28afP+RhGlmaiqB0bb1/x65IJazINzox+NM6xQedI+hQ2VUjwBDniG zp1LSUHzIlkC3SOYCoFHVaSeFCupCe07n6NPCpmzM5Rgzr3ywbzDt7mCv/forNS6q2gsrbojEV9 JcvSa7KkeRMB5ctVxwG3YdFiYCU8n9G93jBDZaSYUDKbRL/pHhhlqon+1+ieQxGB98WmZL9p81q 5CgBMYSsEu3nk4RZoGH62Tr2TE7CjxD7tRwpQS/DG2XRSzj7zW6YH5d6WLF/iLUN5+iswo22sz6 vElfslI8Q++JLMKB6MRglNrs2zxtGrJ/1cjX43KK7CS0TsXh4xws5+X5OUvM9NgRMSYbH4705mr NHYN2kcYMaRCIzngTwT7gdpq4ltvKSPN0Kv7DyoBAUJDXEaMvv4kheyWk/QON1Z7RFXeP4812ds 6fQC8ls/Po X-Google-Smtp-Source: AGHT+IE9XCEPWxrSii3LQtRDVcyobUev4q5tb31hhJVv+N48owP0Fls5Z3YxA1ipvH8YFXAStyC36w== X-Received: by 2002:a05:6a00:10d1:b0:7aa:57f0:31c8 with SMTP id d2e1a72fcca58-7ca8b597654mr12336229b3a.30.1764272599747; Thu, 27 Nov 2025 11:43:19 -0800 (PST) Received: from localhost ([116.86.198.140]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7d15fcfd0b6sm2669720b3a.64.2025.11.27.11.43.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Nov 2025 11:43:19 -0800 (PST) Date: Fri, 28 Nov 2025 03:43:16 +0800 From: Chris Down To: Petr Mladek Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Sergey Senozhatsky , Steven Rostedt , John Ogness , Geert Uytterhoeven , Tony Lindgren , kernel-team@fb.com Subject: [PATCH v8 02/21] printk: Avoid spuriously delaying messages not solicited by any console Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.2.15 (2b349c5e) (2025-10-02) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" printk_delay() may introduce delays even when no console wants to emit the message, which is unnecessary and may hold back messages we actually care about. Add a check in printk_delay() to determine if any console will print the message to avoid introducing unnecessary delays. This change aligns with the existing behaviour of boot-delayed printk messages, which already have a similar check. Reviewed-by: Petr Mladek Signed-off-by: Chris Down --- kernel/printk/printk.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c index f002744b9a90..a3072ea39e5e 100644 --- a/kernel/printk/printk.c +++ b/kernel/printk/printk.c @@ -1307,14 +1307,12 @@ static int __init boot_delay_setup(char *str) } early_param("boot_delay", boot_delay_setup); =20 -static void boot_delay_msec(int level) +static void boot_delay_msec(void) { unsigned long long k; unsigned long timeout; - bool suppress =3D !is_printk_force_console() && - suppress_message_printing(level); =20 - if ((boot_delay =3D=3D 0 || system_state >=3D SYSTEM_RUNNING) || suppress) + if (boot_delay =3D=3D 0 || system_state >=3D SYSTEM_RUNNING) return; =20 k =3D (unsigned long long)loops_per_msec * boot_delay; @@ -1334,7 +1332,7 @@ static void boot_delay_msec(int level) } } #else -static inline void boot_delay_msec(int level) +static inline void boot_delay_msec(void) { } #endif @@ -2116,7 +2114,11 @@ int printk_delay_msec __read_mostly; =20 static inline void printk_delay(int level) { - boot_delay_msec(level); + /* If the message is forced (e.g. panic), we must delay */ + if (!is_printk_force_console() && suppress_message_printing(level)) + return; + + boot_delay_msec(); =20 if (unlikely(printk_delay_msec)) { int m =3D printk_delay_msec; --=20 2.51.2