From nobody Fri Dec 19 19:19:14 2025 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68F8A1A0BED for ; Wed, 8 Jan 2025 09:13:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736327607; cv=none; b=lyZefZK4f6HY56H7MVps1q6kScmfdfuwSMswDy9KHmK5bQ8AuaJ/Ik7KwyhhtvhQYoP0QCyrt/pfrm5OjRYzA6I5JKSQSWK22uOTNM8oDSzFoh6Ri218S4xxBBrF0iCLv2qOLKkkj8WwC7peB0f8IdfJFP6EMGVI3J9jcw0V5mE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736327607; c=relaxed/simple; bh=apMMjVP+kwbKtHPFp/A5uUFdrg+Nshc3Olcebw/xj6g=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=qrAGfxv0ev/+8CDKvjvqb5hJKA6E71EkFPeughS8Q9Bmsdas5d2j+OBMppzVd1kifTW46Ac6a4FziSWcXmfhRc7nwNJFuvOTUWGAOuGBqvvPMojl7VJzdRAvenGb5NhLO2jKJ/ERT8+2AIKGaqID/1N9oj1+xrDuy+K/EEOhDJ4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Ti1XrRYd; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Ti1XrRYd" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-43618283dedso163410735e9.3 for ; Wed, 08 Jan 2025 01:13:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1736327604; x=1736932404; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=MzXs3KFyj+OlwwBWlXhhhHxWf9NDPhglowmb8OrsU0U=; b=Ti1XrRYdyiTi47alIQooE901LwT2vAi1RulVnOhgf2x96pAaITsC2TahHnJ2BHMx8G uVYXYGxLIolMagQlX1fbtfzEY3GfsJ/KUklZhf2utbzR6Mu3BRNHfrFqL/g3eJYoyfvQ 4Hej8aPgpv5oyU+2c1KUcxxqmKMewdxRFhUlcIknjhIhRcSohWNHDy30r2bUzoE8E8J2 BHrApnmBuUXMkFHUoJLuvXruVDUxt++x+1uHWzIkfkfTBNVd6iQc2MCvML/cx5kGxlgP kXZg619qd5FoIxB7+TeJUFj9rKM5iWw3mhequ+KVSF2QkEd01G+d3oPyXQulxOO607hn CXKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736327604; x=1736932404; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MzXs3KFyj+OlwwBWlXhhhHxWf9NDPhglowmb8OrsU0U=; b=sE2ok8+vjw4USpP9ta9ICcu0Hby4N8MhZUC18tjbaYc7fjdGnk+nA0FmAyLz4nNPD9 XGq7WUvCUAKcEKlgR5B7cyhvlQbnlzTSCksZLYSMB9g4ls6KTuLkOFeGmGHMQT0ilQMX I9/SMegy7/lxNmM2El5W4q9FRr/DLp/6is0NA6rRlZF7oND6yGeClgogMRanTMhYRdGy r2VcNME90PXIoLbSYTqkcJE+Rdr9KV4zhcDPwJGefvmCNB47IpPqO17YOnGghKAFIoDf 44SBxZgq7sbfG9C65cEwjHkaJrONRt6VNXXfR8XypMnsyX/icTcvI2WiyzvrsWW+Gouh SWrQ== X-Forwarded-Encrypted: i=1; AJvYcCVnaEDfQXE+R4UblGPgdfJ22Yi/YQBoaoTZphRhJMXyLMHbozrZQNvtTld4ZmPsLD5H+aY+QqMVfH/3d1Y=@vger.kernel.org X-Gm-Message-State: AOJu0YyLVjZbrolYbu879LqrhKTsUkdXS7PKNvYcXGn9hG5IBegm7HDd nAWpHvZq7FT4a86zfIrJ3ynuGJmjZRZQ9A/lQI4TfojOzFbKF3DuVv2WvGQDEDJdSzgS1fJNTXG T X-Gm-Gg: ASbGncuc1t5gBIzkFr+JLk7Ek5z2u2+b0ENJfWrvbU1kLXG7tKCoAxHanlKpa2oBCk/ 3QrY6W8GPQL6mxUFPy68HEsgE1iOd6LKcHa7yPdPJHEu7BTDFL53+S/6NaYk31wmMRG2/DUC/fG vMEh4azlI8uqUYXnnb78vyezF6hSB2fUTQR28+rTviqEoWsjJZi5H/4dj37xpE9jEQlkw76HIpC 9XB/smKTDTAwDQWcao0hdalJxMaavmflz5ZGXNZbtRVcAo1lp+G01wE6uQhoA== X-Google-Smtp-Source: AGHT+IHGv+AYtNiD8pZSgTeJJr69q8hxwaeSukDvA5nr1zKw8kvCDzL2/uyOHrj1po6Sh+MfWJg6+A== X-Received: by 2002:a05:600c:4f09:b0:42c:c28c:e477 with SMTP id 5b1f17b1804b1-436e2707f13mr11755805e9.23.1736327603629; Wed, 08 Jan 2025 01:13:23 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436e2da6401sm13964575e9.2.2025.01.08.01.13.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jan 2025 01:13:23 -0800 (PST) Date: Wed, 8 Jan 2025 12:13:20 +0300 From: Dan Carpenter To: Fenghua Yu Cc: Dave Jiang , Vinod Koul , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] dmaengine: idxd: Delete unnecessary NULL check Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The "saved_evl" pointer is a offset into the middle of a non-NULL struct. It can't be NULL and the check is slightly confusing. Delete the check. Signed-off-by: Dan Carpenter Reviewed-by: Fenghua Yu --- drivers/dma/idxd/init.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/dma/idxd/init.c b/drivers/dma/idxd/init.c index b946f78f85e1..fca1d2924999 100644 --- a/drivers/dma/idxd/init.c +++ b/drivers/dma/idxd/init.c @@ -912,8 +912,7 @@ static void idxd_device_config_restore(struct idxd_devi= ce *idxd, =20 idxd->rdbuf_limit =3D idxd_saved->saved_idxd.rdbuf_limit; =20 - if (saved_evl) - idxd->evl->size =3D saved_evl->size; + idxd->evl->size =3D saved_evl->size; =20 for (i =3D 0; i < idxd->max_groups; i++) { struct idxd_group *saved_group, *group; --=20 2.45.2