From nobody Fri Dec 26 19:32:48 2025 Received: from mout.web.de (mout.web.de [212.227.15.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A9A71844; Sun, 31 Dec 2023 08:41:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=web.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b="Yka56IxX" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1704012078; x=1704616878; i=markus.elfring@web.de; bh=ngcIJAm1Ej3Lwv2XTWs2kB+R0dxqdh3OvapK6fY30go=; h=X-UI-Sender-Class:Date:Subject:From:To:Cc:References: In-Reply-To; b=Yka56IxX65Vva7X8yOY2pHaQ572/pOCr1TZLW2keM5A9KcH7h5zZTgl1u7pjS2X7 /0COmjiHpRoO8mAvb25HFXC3MKPgkR//zD2HMwdAelhpbL6WEa1Z1lDk973vJBqlO jURWmb6XGy4N6WkgaDj39ynZwYRHLw1GcCrWYyLTRGGidJR6dSMklzHmhhNpvGu7X KOORuwWIEQutgfXnWO1igBqi69XzY1clT3OlGtmnfVmpHZffKlZtINK7zakOMHQzK SQSrVhs3x0yZl9ifgbK0tLZT8M3D1lnNvIhT1T3/epYOMu0ZaVzagz3P206Ey8JpC C0ohN7IfbKeICR0mIA== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.90.95]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1M6HKG-1rHfWg0WEq-0071hb; Sun, 31 Dec 2023 09:41:18 +0100 Message-ID: Date: Sun, 31 Dec 2023 09:41:17 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 1/3] gcov: Delete an error message for a failed memory allocation in new_node() Content-Language: en-GB From: Markus Elfring To: Peter Oberparleiter , kernel-janitors@vger.kernel.org Cc: LKML References: In-Reply-To: Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:kxxYdW4wymw7KpnJNNyv1l1NELGgaOlkuwGrmtORTO/0KZS+Jzj Mm65DPw7apHAZzNHOFZ5a4xHhBMsSDvrb66jXX8SxIdXrAtjRZe0Al86QpiqrvTgxMD5MLI is9RfZLN6aP9SJT/HRCMmxu1/4ogkvFNJ2RPKSJ1+g2CMKEr9RvkbCSEi5FYAI2lqkl89VM iR04gRxEohS4ap1gDwEdg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:+QbkL5WENas=;KEQg9KWpsJcI5qKxX12tTZfBLWs 6Y8nqZtw7OWpKjWCrQS1uG3mrIKHA5zyIpnrzQYkOJTyFUUxKCS1TL2I8AjmO0EPCnKjCJ/xv r0SW06DXfkM33CVFha3TllRaBalGm6yGrDNG8zKzh3IKrO+x2fc+ppBMixZCwU3hkFbH6nCH5 LhDkXsIkWpeFy3U4sldPneyDrzz5hP+HSQ4v/2bNgwr1oidVltcDkniwjTm9OZCblvVWVAqyU T0ma74LXZXdFkWecfa01v+IobhPk7/ZoyejPQ2Frh7cnRPGgGqqfFOOeAEg6EZ/r4/b4/HqTL 7H3LeSsAB7Vr15juzEqpgS6nMP0Q4WE02SqOD4t0+50jVjoVQ7+ArgIfUoTw147Ly1CKcx/rq vc7fnJLBPE4uH3zzhwPfvs19/8eQiqqLOkNLwmICwGbq1Pv442d9JgUCbr5gnI6/IC9UF9qGR IEdIVe/OqfUiPICPuPvYTvg0oRoY1FH+b10WuKQdjwl9JEYxbML5L9nCT25p/U3415NoPk9Lh p2GV/4VDKiGgU+cxZGIX17y7WQ+c9DqjOVY8JS/+4h++smiC8w9N9VFxVxUtEZqbpq6xbxQiC j/8+LOW0+usZszTsy8z74Msy4eIN6ZvLC5BJBaMNOjgega6EPa6e+iRUR/CwZCihEO9YThE99 EfjMuFVWErvdGvaL5DBn8z4dzhlPYfA/8/w2O1v31C/I1+VnjC0h70kbYL1TtmmjMRHHjlOoa TOh49F48WpSCckyzklxI01YUs1uRDqUDW+7herpNlKWDEPwlG/l1Ly7jg3M3mWUKl4gAbiWIE zEL0hCtTNvV+1cNwiONve4/ZEIozzmbsoKgOvVbLm4VzAfOuJ3SaTFwOI8x7tFjQkyE3vxynA Rw/f44WbSmcMUXsVYN/VOUhx2tOclGcrm+uaMdrGHYG3Rc3RNTt6H7BEAisIPt5LPtA5y4ur9 fA2Q2w== Content-Type: text/plain; charset="utf-8" From: Markus Elfring Date: Sun, 31 Dec 2023 09:09:25 +0100 Omit an extra message for a memory allocation failure in this function. Signed-off-by: Markus Elfring --- kernel/gcov/fs.c | 1 - 1 file changed, 1 deletion(-) diff --git a/kernel/gcov/fs.c b/kernel/gcov/fs.c index 01520689b57c..0fbfa444a388 100644 --- a/kernel/gcov/fs.c +++ b/kernel/gcov/fs.c @@ -566,7 +566,6 @@ static struct gcov_node *new_node(struct gcov_node *par= ent, err_nomem: kfree(node); - pr_warn("out of memory\n"); return NULL; } -- 2.43.0 From nobody Fri Dec 26 19:32:48 2025 Received: from mout.web.de (mout.web.de [212.227.15.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49469185D; Sun, 31 Dec 2023 08:42:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=web.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b="TJ6Xc3tu" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1704012145; x=1704616945; i=markus.elfring@web.de; bh=qhknSDGJ/5EFhUiXS84uiALl32Ogpu0VDaqNX9XNDOI=; h=X-UI-Sender-Class:Date:Subject:From:To:Cc:References: In-Reply-To; b=TJ6Xc3tuT5BWP7DrgY0OAklTPEiHTFgyaKlc0saWRF+9GEaaL4I6iR9aZo4nMM1W VhYyIvgN20v2dCTigXqEf2GsVP0KnA2e4sZFYbE1c6VpBbf1bhBCYHSCcrayRzkCS Gy4yS04lyKn9KBRTsIclrpcUyKDUXIeWkX0ymlWSPr7DXI99wRfdoJybb3MbpQp9+ w4zHvLUdB+Xy9w1hXLf41qQ26fR3+Gc9L3lASmJP8I1yDzzxpVaNYBSd2bVY8h4HO EFwZroV/shsOKIWEK7hVakLc7oy9Aobv87Hwkjh63Q2wBJ+xa9Lk6Vy2dj3zDIA7Z hPKC9Pc8mG7aaG6zrA== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.90.95]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MjxiW-1qvkz30as4-00kXSF; Sun, 31 Dec 2023 09:42:25 +0100 Message-ID: Date: Sun, 31 Dec 2023 09:42:24 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 2/3] gcov: Return directly after a failed kzalloc() in new_node() Content-Language: en-GB From: Markus Elfring To: Peter Oberparleiter , kernel-janitors@vger.kernel.org Cc: LKML References: In-Reply-To: Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:dblaX9Kqfi7kqmD1MmvGZyBFiMSa+A/t6npRduaddmwJki6rCCl RbORVETR70HNMnFupcJKIf+tvbFJMddVRwjCHvb7XJfq+vy22VtvmzOrj7TS+f2tdwpVng6 fU1+qKMU1APyCAzKNiiXSu3LKh8Glb48vNR94VexFdp8fpI2RIKz1Sypi6h2s1MB8w7BUZn lcHGwmZUY1dJcGhlbYf5A== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:2D6hG3Prbpo=;g3s2eWiHgFOxYVWeVF+VljwWxyq c2q3yr+ESxBV1E6YijOOzf/WfamPIUFTzkVOHekJwbeq+Gx+suDNhgcIy4gyY/GeL64v2Gxr4 UQDfFeVtADt0PC8hNwbysKoC1YPQ6R+ThGrzWMOvtYtD5a71J7L//IonyHzQVjkiQCA6j3C+b y7R94ObSvr312sCboO6HOoFQ+fTuzV4dK83jvIRMmWPbn3rj+GBl6/a6QWVwpPN/Llm4GUSq5 H4B2uqoeavUmws4DomnHW4atYwP/rKAMTkFziS4XuBrbwuiKwUb51GfXqcOKq2W7c6qJ7rqgH JrJ855f4+cNo1ZXcjYOcVx4vtrx8Xe4Gl29i6mgAeomcHC6gMSNoIo8kPF2uOJEckCf6V1krX ks3htFXFOeicSdxEWQR5iBk/d1yuXUKsU3i6a/PloeeRDMn5IOpEpzapgwXg3eI4hYShnmX0t 2xrX+qOxYTL30JPhFpqCr6uAekx4c7BY41N2+87QfpPk6Tci5NOQ4QCGsuhlSEtiRjivHHQcC 8Qfx/npNHfO6LwSoSUlfN7N3/vyQzQzGFe8u+uqC/Ut3JEfIoLVfz3FZp09W2glg7TBXxPoYO pxzIhhh+nphBEi/Y0Xk7cqf0X4jIPjOJC9JHHSnv6kFw/mDYScYIL0mk9JB5GYnq6kVEU9Ezn ZdjMvEDNl2VcTvdmfI0uORSkP2SRR0S/sk3WYkhrDXVP2TYC6BhliSydDoOOI4OlFbn59Rwwd ib+r1XvA8MXaU6uuzQDsIzs8tXKxgmkY49YdL6J4Yn/Eymp0LDAi6YhbLGPwjiTL6nJN6lCtK +zDQMUBaomVnr6/X1N/JV0MXIi+DNG/y4OYGZvU+BLxD+h5zpAgKflytDJnFqcuyxpB81vkr/ sw5GN0TqhT1lpFf6igBg/ckX6SsGrbBhEoLw1xoUlntcPV5TrcR7RysweNUwS4zlelgsgmJIC x/ExEw== Content-Type: text/plain; charset="utf-8" From: Markus Elfring Date: Sun, 31 Dec 2023 09:12:44 +0100 The kfree() function was called in one case by the new_node() function during error handling even if the passed variable contained a null pointer. This issue was detected by using the Coccinelle software. Thus return directly after a call of the function =E2=80=9Ckzalloc=E2=80=9D= failed at the beginning. Signed-off-by: Markus Elfring --- kernel/gcov/fs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kernel/gcov/fs.c b/kernel/gcov/fs.c index 0fbfa444a388..10916c70fad9 100644 --- a/kernel/gcov/fs.c +++ b/kernel/gcov/fs.c @@ -543,7 +543,8 @@ static struct gcov_node *new_node(struct gcov_node *par= ent, node =3D kzalloc(sizeof(struct gcov_node) + strlen(name) + 1, GFP_KERNEL); if (!node) - goto err_nomem; + return NULL; + if (info) { node->loaded_info =3D kcalloc(1, sizeof(struct gcov_info *), GFP_KERNEL); -- 2.43.0 From nobody Fri Dec 26 19:32:48 2025 Received: from mout.web.de (mout.web.de [212.227.15.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 261EE20F0; Sun, 31 Dec 2023 08:43:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=web.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b="DK3xL9UK" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1704012207; x=1704617007; i=markus.elfring@web.de; bh=Y0zWZgj6Y0K0bkgqyGjCt7nG5v2aUOSugrldJ+nSJyQ=; h=X-UI-Sender-Class:Date:Subject:From:To:Cc:References: In-Reply-To; b=DK3xL9UKgS34OjC/P921kKVslC2HvqyRcPR+9BfDMbZ5Z6puwnA7xAMvOKrcZjUH +C8xuK8wMgYkQCiX+hTlnGMa112CfKxbq+gMGdxAz4Ar/lPGD41W/WbARCYsAaRUX JXNeSsPPlciZ+HF1/Ko+UCBZCbQHCpSS9BE/DQkcwns1YPgKDmZfV3CEMrvboDVwc nJNrdUqHkbjYRRSoNjPx7Z7QBHnOi8bwJYqWrJNvUj5yDtaYy5vaTrRvh8zpSFxaX 5SFqRbG/Cc6K0BYEvpoi10jURm4Y97NcFxie3DoTxksquZfkwnNJqCT6vh3nGusVh aOOGU8zly6ODyX13iQ== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.90.95]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1M2Phi-1rNhxp31o6-004HsL; Sun, 31 Dec 2023 09:43:27 +0100 Message-ID: Date: Sun, 31 Dec 2023 09:43:27 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 3/3] gcov: Improve exception handling in add_links() Content-Language: en-GB From: Markus Elfring To: Peter Oberparleiter , kernel-janitors@vger.kernel.org Cc: LKML References: In-Reply-To: Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:266UXnCFnJs1UhXDnxzgQk0WSNxoTBvL4Ectx5t/OyYBkhFpbMz q9d7wTo/cpcFYxdrHeust6Bsm41z8foE9EaQlGsVN0OdKWvCEc2D6+Sb7uNr345poqRd/yU Zmsu/snErGDNozlYGprkJoMT04N49gL92i+3n3Nu4eXdMlJTB9vACJnVBsljKbHXHdNTawu 88qxBY0f3/BZxoGkVFRzQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:G+N9Oq2OJi8=;8Tm1thXBTbg3AdxG9He9+sInVuI U5TSfmRZFFYED0ouc5m+aBudgP5iqZRhx+SIMGbXP9Xfu4XTsg5WcbCjaIBBUff4ygFeRp+LT djCiOnSsmaDztE5Iqv4391AyrbXm/7w9w3KkUhDiEFqHtg84Eu41vBokLKFWoAk98HJFd/Iyc xNqySMm6/rUrkFVg56F8xLGWEgJLdNr3LA46+RNoP4BmlRKlDUNr9FVIILHxWetj9I9K6JiTP KKRquj0Z3VKB8m9MjI0nUFh6mADRFEFpg3grQIT8Y8NlX3F0t9ItT9rA4TLJios4qnVvxvvBJ bIj+o0sYi3aWphbnWFSQsgFNUsSHmO+OEEbtySseaLEQpeOFld44Ui2+nGeRBfFmy2JVBVyF3 hs76WaXssa/bJaoVTIY+7MSa/gL8Wu42YCVti5CAT9SUSPFu8RimICqK+s3WrK4VNB+LAqJ9Y XgmGH9+hY3/2hUaYehPjSeKSf6U6ecJKHiBbgIDvdOLPHk5rUSZAI/aDtCmQ0Gxo5zvgypnRo Qz0srOtS3R8vNRJ/7HP34uurPUyWeOytmg9fSpq1aTcO/pBO4RdvT9vU2q4YiOI41FCb7bCf4 5EOQlqlbF+MX7rGncjLn0dNlxZ7I/B4N9BnFR+qUMotfElLPbdYcx7uzf3DiyVtXpdLFB0aWB Zd56tmaaD5tNlc6sWAl7GDvLE0VKohNegHgXUL1X8MDmMV+2Oy/Wfth6uBgfoNpM49yMOJgzx TGDCMdsjxMeKITDi+B9nKU4H7CzKmN/7riiLV3VDvlqo2NOG0sZ8QxTGIeV4gRjh2W/yVekdA c1FTmScOVe6h/UX/skp7VAYKaW4zjRhLpFQng+AhTpV+3jzqk7tkrlGbCEPgTQ/E33Xjwq+0p roef4hExnbsISdt9Qbjv1WLwl7XP0F0jCYMRyGxRPUBU2QNBNWqLiMk7U4C3nt0YuvHzd6Vba z1SJfw== Content-Type: text/plain; charset="utf-8" From: Markus Elfring Date: Sun, 31 Dec 2023 09:23:50 +0100 The kfree() function was called in one case by the add_links() function during error handling even if the passed variable contained a null pointer. This issue was detected by using the Coccinelle software. Thus use another label. Signed-off-by: Markus Elfring --- kernel/gcov/fs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/kernel/gcov/fs.c b/kernel/gcov/fs.c index 10916c70fad9..80c221bb7f20 100644 --- a/kernel/gcov/fs.c +++ b/kernel/gcov/fs.c @@ -490,7 +490,8 @@ static void add_links(struct gcov_node *node, struct de= ntry *parent) gcov_info_filename(get_node_info(node)), &gcov_link[i]); if (!target) - goto out_err; + goto remove_links; + basename =3D kbasename(target); if (basename =3D=3D target) goto out_err; @@ -502,6 +503,7 @@ static void add_links(struct gcov_node *node, struct de= ntry *parent) return; out_err: kfree(target); +remove_links: while (i-- > 0) debugfs_remove(node->links[i]); kfree(node->links); -- 2.43.0