From nobody Thu Dec 18 00:48:27 2025 Received: from mail-ot1-f43.google.com (mail-ot1-f43.google.com [209.85.210.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3AA3F15B0FA for ; Wed, 24 Jul 2024 16:07:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721837221; cv=none; b=YotEdRhYhkAMZwHgQNxS0q10mag0TPCRRLJP6CfZhEEO4xiCl4oV8zoT5dBIVrsEDDPh/g6eZUhRNysvURMzJzCGPS8c8rfE8/3m3vzWr0pMZ/8oqprNCAUvXWWWhLDrLtlw1W3VtKA2oXJN5TGdMBXvhvdbwBx3+dFlIFMq62E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721837221; c=relaxed/simple; bh=CqGehawQopzO0+MqKtuM0KuKVC/NihG+re/9nwFvxcY=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=MgHJIrJaBnxe+x69gfnlxGZ30JqaOuhxPg5U6RgvSIJbim4XH4ilbISDCO6NmYWuB51+5MXdxR9gA+6xrI8+lMKP6QxoNMlIs5/L0WmfKlFcdHvZcKChuQf03R7Lm4LvGhUgN4Yp7891aM9bNkWzIYadOqnoOWn09CWdhPREi6w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=F6briLkj; arc=none smtp.client-ip=209.85.210.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="F6briLkj" Received: by mail-ot1-f43.google.com with SMTP id 46e09a7af769-70364e06dc6so3149461a34.0 for ; Wed, 24 Jul 2024 09:07:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1721837219; x=1722442019; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=WL00ffx6FZOS+gjuVcqsGTl485DZxHlIKJfADzNE310=; b=F6briLkj4+xU0WPPF0eVPTrUO1hW2W78TDAEOH0MYXBXg4ZvKWE/J8jWaC9JzTQnQj 1ffiUCbwm4ABKHe3CY1+pJxzfoKvPJrEy+9oM7dsnoFWm/LIlyVfidtpHRu9BoOliUj7 MkzNClEzM6kIDMsExSY9zZbPOMriYZNEH5cThK/Z1mhDPDH98Mqr0RJS+RQbhnfwCzm7 klxBJc7ye5C5Z22qqyRQxBTwwqPvx7u9/VtR+UBbFTcYVieLSWvdJTvDOWFNY0BhgTrk op4sphGUENu6UGKpG02NXsOt15hHlv5YRU6rHcHl6Xqy1G8ATqscb1GhCZXAbec/V448 DdcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721837219; x=1722442019; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WL00ffx6FZOS+gjuVcqsGTl485DZxHlIKJfADzNE310=; b=SOTD9N63s7qKr8R4Lzx0+eKCNZaOA3UyRFntX5ULQouYBtBhF3fi3zBhSGMqiwJfvk 8ICYbW3uYHAXjEH5kEkTuUWFO+7CtB12w/rI4XSi82Qz88tWAhOFeMoYbzqF4ERpLexw NCKqlkVL1qwyolQ3nN2Id2qo4/+X95Vg/pex0maVcOMO2xOYPIZPirk72pkVTHfaaxI7 OOZluq1Uxk+ZdA7sCYq9ddMtnsviMPsgSjqfH8+umQLgScEodV6Wx3Qt2TP4LEUfGtms zVE+slFCivT1MALUlg8tKNquRCmfBngPuCxWHFNFpayCsXA7bbBc5th32vZc9phXGCL8 O4jQ== X-Forwarded-Encrypted: i=1; AJvYcCWXUnAu1AyBJibbNfKLubcmq2YsIvd280zdbZS/xzZ668dAkBwwPYL8tGLwBWaxxYeWWVhKr9KttGRoQ/1GRomRvKXFzxqYl8b+t+gg X-Gm-Message-State: AOJu0YxhFW9F/hzOuSiL3piVAPZMwquI7aDPdBjVI7DzMNB8qYVMZRDm SJ8uDjLRks5+Ri0ATDQki8qBa/yWyW8R8h8ghVyaxTPyOt9j0DfFHWS8+3fpT04= X-Google-Smtp-Source: AGHT+IFHDoY0NxaVxYd0I7yvfDpL/US8mbo5c+Ln+MlZ4tHFOz+j/ptFK+39Sj3ax64JA9QORrKb+w== X-Received: by 2002:a05:6830:2782:b0:703:6341:5171 with SMTP id 46e09a7af769-7092e6f0700mr245391a34.15.1721837219146; Wed, 24 Jul 2024 09:06:59 -0700 (PDT) Received: from localhost ([2603:8080:b800:f700:23ae:46cb:84b6:1002]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-5d59ee0f336sm369821eaf.9.2024.07.24.09.06.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jul 2024 09:06:58 -0700 (PDT) Date: Wed, 24 Jul 2024 11:06:56 -0500 From: Dan Carpenter To: Stefan Chulski Cc: Marcin Wojtas , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH net] net: mvpp2: Don't re-use loop iterator Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This function has a nested loop. The problem is that both the inside and outside loop use the same variable as an iterator. I found this via static analysis so I'm not sure the impact. It could be that it loops forever or, more likely, the loop exits early. Fixes: 3a616b92a9d1 ("net: mvpp2: Add TX flow control support for jumbo fra= mes") Signed-off-by: Dan Carpenter Reviewed-by: Simon Horman --- drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/= ethernet/marvell/mvpp2/mvpp2_main.c index 8c45ad983abc..0d62a33afa80 100644 --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c @@ -953,13 +953,13 @@ static void mvpp2_bm_pool_update_fc(struct mvpp2_port= *port, static void mvpp2_bm_pool_update_priv_fc(struct mvpp2 *priv, bool en) { struct mvpp2_port *port; - int i; + int i, j; =20 for (i =3D 0; i < priv->port_count; i++) { port =3D priv->port_list[i]; if (port->priv->percpu_pools) { - for (i =3D 0; i < port->nrxqs; i++) - mvpp2_bm_pool_update_fc(port, &port->priv->bm_pools[i], + for (j =3D 0; j < port->nrxqs; j++) + mvpp2_bm_pool_update_fc(port, &port->priv->bm_pools[j], port->tx_fc & en); } else { mvpp2_bm_pool_update_fc(port, port->pool_long, port->tx_fc & en); --=20 2.43.0