From nobody Sat Jun 13 09:25:10 2026 Received: from out198-186.us.a.mail.aliyun.com (out198-186.us.a.mail.aliyun.com [47.90.198.186]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 22C4C3C2792 for ; Fri, 8 May 2026 09:59:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=47.90.198.186 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778234367; cv=none; b=Ns2jwNEUTsBDJwdfiQNWWBTlCeQMtkZD15KWoB3d9+vaDQDhxQqcNp/VqZLOwdmiC/hpG2dP3XSaS1jgUrLc+qUYwo50TdZn3idXAA11f7YKIMtZVBbalb721PJCUt4c3yy80RPw5c51GpeOSo6wzpAKrvnhizFKFlW8o85NNaQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778234367; c=relaxed/simple; bh=Jux8IYcZGYsH2XMrUoxeHVdHICtB6pKU37qu4AfMQ8I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=MHqdEDEfQQdFhTmcpq38o3x6WHziTUa/cfJJ9dt+y38TeaT7OLrfOL0ktad7f3smJu8uisAG98nYY0ZcLhb96E1B3Y7YyuhHE/ANz46a+4mOHFC+G0rgDfbKUhsO9uixkFsN1oEwuuhv9V0Ew0Oqh24fmbiVETxW4P1qIcLCZ6s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=alancui.cc; spf=pass smtp.mailfrom=alancui.cc; dkim=pass (2048-bit key) header.d=alancui.cc header.i=@alancui.cc header.b=bcrF7ZEY; arc=none smtp.client-ip=47.90.198.186 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=alancui.cc Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=alancui.cc Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=alancui.cc header.i=@alancui.cc header.b="bcrF7ZEY" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alancui.cc; s=default; t=1778234353; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type; bh=T8pR3Xi1w/njBbvukbsT0Kf6IsgNDSrXrPXmpJ4ZFVA=; b=bcrF7ZEY9qS1o0oMMgmdZ6hiw4k77wMrypVEGndro/ngap9lEYQYyOeaS46O8H8TXyLF+P0+9o8UH78ORv9TJS3wMN1ML9IVxOAHBLvVk2ltPwQ97i8EKGQ4MM5ba3SCPQI0VHY2WDJofnoFnb8BSlUEOSkmdUussFevZ+BL0AkIj6xoXH5Zv/G6FEdOWc0wWMtMwKa5xNOOoSPisj9gAzwQ0bgxstLDzq/z/s0E10Lo9TwxuWwjVJt4c/0N5D0suFL6AIzt+7dhLTWNylOIUtweFXveiTRzXxaGcdu9FXI4MaODytglhJKm6xRfyvcAsSiZiYdVOD2g1ecdEry9Ew== X-Alimail-AntiSpam: AC=CONTINUE;BC=0.9074157|0.1235179;CH=green;DM=|AD|false|;DS=CONTINUE|ham_alarm|0.0236421-0.000461084-0.975897;FP=964337513750189831|0|0|0|0|-1|-1|-1;HT=maildocker-contentspam033045220102;MF=me@alancui.cc;NM=1;PH=DS;RN=3;RT=3;SR=0;TI=SMTPD_---.hSQR4DY_1778234352; Received: from alanarchdesktop.localnet(mailfrom:me@alancui.cc fp:SMTPD_---.hSQR4DY_1778234352 cluster:ay29) by smtp.aliyun-inc.com; Fri, 08 May 2026 17:59:13 +0800 From: AlanCui4080 To: Keith Busch , linux-nvme@lists.infradead.org Cc: linux-kernel@vger.kernel.org Subject: [PATCH] Revert "nvme: add quirk NVME_QUIRK_IGNORE_DEV_SUBNQN for 144d:a808" Date: Fri, 08 May 2026 17:59:12 +0800 Message-ID: In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This reverts commit 7f991e3f9b8f044640bcb5fa8570350a68932843 ("nvme: add qu= irk NVME_QUIRK_IGNORE_DEV_SUBNQN for 144d:a808") The incorrect implementations of SUBNQN is a known issue in a massive numbe= r of NVMe units. However, the warning "nvme nvmex: missing or invalid SUBNQN fi= eld." is usually appropriate and will not affect performance or behavior etc. Th= at is because the support for SUBNQN is mandatory if the controller supports NVMe revision 1.2.1 or greater, and it reported itself without a SUBNQN field wh= ich breaks compliance with the specification. It should be not quirked by the L= inux Kernel. Signed-off-by: Alan Cui --- drivers/nvme/host/pci.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c index 9fd04cd7c5cb..2850fd55894b 100644 --- a/drivers/nvme/host/pci.c +++ b/drivers/nvme/host/pci.c @@ -4107,8 +4107,6 @@ static const struct pci_device_id nvme_id_table[] =3D= { .driver_data =3D NVME_QUIRK_DELAY_BEFORE_CHK_RDY, }, { PCI_DEVICE(0x1c5f, 0x0555), /* Memblaze Pblaze5 adapter */ .driver_data =3D NVME_QUIRK_NO_NS_DESC_LIST, }, - { PCI_DEVICE(0x144d, 0xa808), /* Samsung PM981/983 */ - .driver_data =3D NVME_QUIRK_IGNORE_DEV_SUBNQN, }, { PCI_DEVICE(0x144d, 0xa821), /* Samsung PM1725 */ .driver_data =3D NVME_QUIRK_DELAY_BEFORE_CHK_RDY, }, { PCI_DEVICE(0x144d, 0xa822), /* Samsung PM1725a */ --=20 2.54.0