From nobody Fri Sep 20 09:58:22 2024 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3F5746420 for ; Wed, 27 Dec 2023 16:26:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rIWjz-0005A4-Te; Wed, 27 Dec 2023 17:26:43 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rIWjy-001tZj-E6; Wed, 27 Dec 2023 17:26:43 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rIWjz-001WnF-1S; Wed, 27 Dec 2023 17:26:43 +0100 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Dinh Nguyen Cc: kernel@pengutronix.de, linux-kernel@vger.kernel.org Subject: [PATCH 09/11] firmware: stratix10-svc: Convert to platform remove callback returning void Date: Wed, 27 Dec 2023 17:26:33 +0100 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1913; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=+Yp1dgFMlCSzMuNAOCbuCl8YKa3LjfoSgbk3TSiz68M=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBljFA7vfChqYEofqwrz3YeDW1AnHg6WinguwSG1 /9J4dCFhhKJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZYxQOwAKCRCPgPtYfRL+ TuSRB/wO29Z+uGNK7yIFswymPxzBzPy/Z4n037X2YkjRXFiG9xxJbNe1VpNhCwd2OWIyxBs1+5M buXcL8F4FtbajrNFtUm42/UR/aUCI0d8gT2ISJVpzU39YarYpsYq3yXQMuR1Yqt4AUrBGsHq/BV aOhAV1+zQg4csv1YyVhO0ZmN1kWjShQd3uwz7cHmB2NPN4KD3X7OvhxMKx36Pgc3lC8kTN+bxJj Ex9RnteN/1b2ZAoA7D/sj9snV5GibE0Tw17FlC+BOKis6osHRUb+n7de+uqRnYGHVIvfyFCx3NX sOJ2To+9pfzDC3922sjuqSaf6t24I2I+DE8y0NLfubtAFO2A X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-K=C3=B6nig Acked-by: Dinh Nguyen --- drivers/firmware/stratix10-svc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/firmware/stratix10-svc.c b/drivers/firmware/stratix10-= svc.c index c693da60e9a9..528f37417aea 100644 --- a/drivers/firmware/stratix10-svc.c +++ b/drivers/firmware/stratix10-svc.c @@ -1251,7 +1251,7 @@ static int stratix10_svc_drv_probe(struct platform_de= vice *pdev) return ret; } =20 -static int stratix10_svc_drv_remove(struct platform_device *pdev) +static void stratix10_svc_drv_remove(struct platform_device *pdev) { struct stratix10_svc *svc =3D dev_get_drvdata(&pdev->dev); struct stratix10_svc_controller *ctrl =3D platform_get_drvdata(pdev); @@ -1267,13 +1267,11 @@ static int stratix10_svc_drv_remove(struct platform= _device *pdev) if (ctrl->genpool) gen_pool_destroy(ctrl->genpool); list_del(&ctrl->node); - - return 0; } =20 static struct platform_driver stratix10_svc_driver =3D { .probe =3D stratix10_svc_drv_probe, - .remove =3D stratix10_svc_drv_remove, + .remove_new =3D stratix10_svc_drv_remove, .driver =3D { .name =3D "stratix10-svc", .of_match_table =3D stratix10_svc_drv_match, --=20 2.43.0