From nobody Thu Apr 9 15:10:27 2026 Received: from pidgin.makrotopia.org (pidgin.makrotopia.org [185.142.180.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59E40248F57; Tue, 3 Mar 2026 03:17:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.142.180.65 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772507875; cv=none; b=KxiRCOmTPHK6WNYuclFPe7l6a6A2LKvqp2DL2rQhIGsso+5DEyyXHFhcz4YJPKHy6/r46aziyVRAvPZKHrT/xF7L2Z4/2GLXnf9oor4Hth9E2PwPe3AxjkaP6QA0aG0XqsRFyNz2ShvIFjBflmW2VKMhTvLEUDuCKwYZxPbW0mo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772507875; c=relaxed/simple; bh=aLwLV5D6RqPYowtE65kJT13yA6cxhhE5SMAi6T6SqkU=; h=Date:From:To:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=Y/GDsP6pThW4zNpRomns5/I+W6HOX19wTcjelcJ3M5NfOTtmgMXNMtSCvBLvjzZPboE48uWFjLM2nEl/6k3/y4BMWeGxLd1iwMHTkqeUV336YwIM32H5hZyUPtlM6v1hq6+OXDIcPs+8zPjioCL/FUWJCKMIa8UMnKFlNHR0Tpg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=makrotopia.org; spf=pass smtp.mailfrom=makrotopia.org; arc=none smtp.client-ip=185.142.180.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=makrotopia.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=makrotopia.org Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.99) (envelope-from ) id 1vxGGc-000000001hz-3S7h; Tue, 03 Mar 2026 03:17:50 +0000 Date: Tue, 3 Mar 2026 03:17:43 +0000 From: Daniel Golle To: Daniel Golle , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next] net: dsa: mxl862xx: rename MDIO op arguments Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The use of the 'port' argument name for functions implementing the MDIO bus operations is misleading as the port address isn't equal to the PHY address. Rename the MDIO operation argument name to match the prototypes of mdiobus_write, mdiobus_read, mdiobus_c45_read and mdiobus_c45_write. Suggested-by: Vladimir Oltean Signed-off-by: Daniel Golle Reviewed-by: Andrew Lunn --- drivers/net/dsa/mxl862xx/mxl862xx.c | 32 ++++++++++++++--------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/net/dsa/mxl862xx/mxl862xx.c b/drivers/net/dsa/mxl862xx= /mxl862xx.c index b1e2094b58165..8281c749967af 100644 --- a/drivers/net/dsa/mxl862xx/mxl862xx.c +++ b/drivers/net/dsa/mxl862xx/mxl862xx.c @@ -44,13 +44,13 @@ static enum dsa_tag_protocol mxl862xx_get_tag_protocol(= struct dsa_switch *ds, } =20 /* PHY access via firmware relay */ -static int mxl862xx_phy_read_mmd(struct mxl862xx_priv *priv, int port, - int devadd, int reg) +static int mxl862xx_phy_read_mmd(struct mxl862xx_priv *priv, int addr, + int devadd, int regnum) { struct mdio_relay_data param =3D { - .phy =3D port, + .phy =3D addr, .mmd =3D devadd, - .reg =3D cpu_to_le16(reg), + .reg =3D cpu_to_le16(regnum), }; int ret; =20 @@ -61,40 +61,40 @@ static int mxl862xx_phy_read_mmd(struct mxl862xx_priv *= priv, int port, return le16_to_cpu(param.data); } =20 -static int mxl862xx_phy_write_mmd(struct mxl862xx_priv *priv, int port, - int devadd, int reg, u16 data) +static int mxl862xx_phy_write_mmd(struct mxl862xx_priv *priv, int addr, + int devadd, int regnum, u16 data) { struct mdio_relay_data param =3D { - .phy =3D port, + .phy =3D addr, .mmd =3D devadd, - .reg =3D cpu_to_le16(reg), + .reg =3D cpu_to_le16(regnum), .data =3D cpu_to_le16(data), }; =20 return MXL862XX_API_WRITE(priv, INT_GPHY_WRITE, param); } =20 -static int mxl862xx_phy_read_mii_bus(struct mii_bus *bus, int port, int re= gnum) +static int mxl862xx_phy_read_mii_bus(struct mii_bus *bus, int addr, int re= gnum) { - return mxl862xx_phy_read_mmd(bus->priv, port, 0, regnum); + return mxl862xx_phy_read_mmd(bus->priv, addr, 0, regnum); } =20 -static int mxl862xx_phy_write_mii_bus(struct mii_bus *bus, int port, +static int mxl862xx_phy_write_mii_bus(struct mii_bus *bus, int addr, int regnum, u16 val) { - return mxl862xx_phy_write_mmd(bus->priv, port, 0, regnum, val); + return mxl862xx_phy_write_mmd(bus->priv, addr, 0, regnum, val); } =20 -static int mxl862xx_phy_read_c45_mii_bus(struct mii_bus *bus, int port, +static int mxl862xx_phy_read_c45_mii_bus(struct mii_bus *bus, int addr, int devadd, int regnum) { - return mxl862xx_phy_read_mmd(bus->priv, port, devadd, regnum); + return mxl862xx_phy_read_mmd(bus->priv, addr, devadd, regnum); } =20 -static int mxl862xx_phy_write_c45_mii_bus(struct mii_bus *bus, int port, +static int mxl862xx_phy_write_c45_mii_bus(struct mii_bus *bus, int addr, int devadd, int regnum, u16 val) { - return mxl862xx_phy_write_mmd(bus->priv, port, devadd, regnum, val); + return mxl862xx_phy_write_mmd(bus->priv, addr, devadd, regnum, val); } =20 static int mxl862xx_wait_ready(struct dsa_switch *ds) --=20 2.53.0