From nobody Wed Feb 11 05:14:37 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78DB1C77B7A for ; Sat, 13 May 2023 18:10:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237550AbjEMSKU (ORCPT ); Sat, 13 May 2023 14:10:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49694 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237240AbjEMSJ4 (ORCPT ); Sat, 13 May 2023 14:09:56 -0400 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE57A3596 for ; Sat, 13 May 2023 11:09:28 -0700 (PDT) Received: by mail-ej1-x635.google.com with SMTP id a640c23a62f3a-9659dee48edso302733066b.0 for ; Sat, 13 May 2023 11:09:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684001365; x=1686593365; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=CmA/3ovmaGe5dWQW+NLjn0vPr5rS/Ohpr12MEunuBaM=; b=LBz3jPLeKCK6RJpCX7HTpolOd1zS12HKWhl39VsPHtyhjWYdQ4NtKJtJLg5lo57BmK 8U5yJbvSju/pmenELtNqU3bW8iIK8dCDyjb0HR9EfHvVcyuKeGPEnEooxV8EXWokFrhj AYSLV/JAFO3qx4vqivyPXkMlO9wTKFsrNogJIUzuyJ5xuRUbmwJwqLXxakD3oORCKuUV k6bmVizf8OeP4fzVapBaauMilJetkyvcueGndWtbgmY42E49swdJeyIPaN5BiSRdLq7j 9+adubpVtiyA2XYdMXFMSC3WTzplX/KfwRhtDB4ipQbUiE68FxuehSBJe2gW9eHHS43U 1JfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684001365; x=1686593365; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=CmA/3ovmaGe5dWQW+NLjn0vPr5rS/Ohpr12MEunuBaM=; b=GCLecUe6gcBqB69UhC/D8b+3fRbxOS70eLW3rQVVeMRNUOCf9rZLeAgmL0//N5WKIE vUofSDdDjfdH/RXIa3s6gfhf+e8hDBsYejtzXI2XIOwyZ8hPRfWAb5E41NtnkrPBgqbN Gyvxuo6Nvq9ON9aidQ3KpdX5FviVauNhqGhegLprdah6X8d2T2IykhNq35zk3w6y8Huo q4D4NekFUIwLaOy6kG/K2+vXUc8nv1bQF+oUDSgWAEXOJEpBIQJsoDMJsGJTj9KF2px0 sz3KKHHYDRvAXR+b5t+MowJGziGWDpJEYbZYrrckR5OrhDzZJ0/xuUeimWO0/cXjRi5w QBAg== X-Gm-Message-State: AC+VfDz05LGiHrKDBU4mCxx4VW/aQu+gq4gYFNVOOW4dYkX/1kEtdQFv XUKAADKza9zMhVyhrky8L0Ozjhqkj84= X-Google-Smtp-Source: ACHHUZ6xg1n4MHIZ0/r7v9eCEhrd0yFtS1SRMjCiO1k+HvzW50ns4eSb6I48NXe48zTcv0hSdQEpzA== X-Received: by 2002:a17:906:7a50:b0:94a:5f0d:d9d6 with SMTP id i16-20020a1709067a5000b0094a5f0dd9d6mr23905006ejo.4.1684001365267; Sat, 13 May 2023 11:09:25 -0700 (PDT) Received: from matrix-ESPRIMO-P710 (p57935e01.dip0.t-ipconnect.de. [87.147.94.1]) by smtp.gmail.com with ESMTPSA id e26-20020a170906845a00b00965cd15c9bbsm7086908ejy.62.2023.05.13.11.09.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 13 May 2023 11:09:24 -0700 (PDT) Date: Sat, 13 May 2023 20:09:23 +0200 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 7/9] staging: rtl8192e: Remove undefined function SetFwCmdHandler Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove function SetFwCmdHandler as it is not defined. Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 1 - drivers/staging/rtl8192e/rtl8192e/rtl_ps.c | 13 +++---------- drivers/staging/rtl8192e/rtllib.h | 2 -- 3 files changed, 3 insertions(+), 13 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging= /rtl8192e/rtl8192e/rtl_core.c index b58a30d68f2f..3f8a58e32930 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c @@ -734,7 +734,6 @@ static void _rtl92e_init_priv_handler(struct net_device= *dev) =20 priv->rtllib->SetHwRegHandler =3D rtl92e_set_reg; priv->rtllib->AllowAllDestAddrHandler =3D rtl92e_set_monitor_mode; - priv->rtllib->SetFwCmdHandler =3D NULL; priv->rtllib->InitialGainHandler =3D rtl92e_init_gain; priv->rtllib->rtllib_ips_leave_wq =3D rtl92e_rtllib_ips_leave_wq; priv->rtllib->rtllib_ips_leave =3D rtl92e_rtllib_ips_leave; diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_ps.c b/drivers/staging/r= tl8192e/rtl8192e/rtl_ps.c index 5a1cd22f5e25..54a21c14cc75 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_ps.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_ps.c @@ -217,12 +217,8 @@ void rtl92e_leisure_ps_enter(struct net_device *dev) if (psc->bLeisurePs) { if (psc->LpsIdleCount >=3D RT_CHECK_FOR_HANG_PERIOD) { =20 - if (priv->rtllib->ps =3D=3D RTLLIB_PS_DISABLED) { - if (priv->rtllib->SetFwCmdHandler) - priv->rtllib->SetFwCmdHandler(dev, FW_CMD_LPS_ENTER); - _rtl92e_ps_set_mode(dev, RTLLIB_PS_MBCAST | - RTLLIB_PS_UNICAST); - } + if (priv->rtllib->ps =3D=3D RTLLIB_PS_DISABLED) + _rtl92e_ps_set_mode(dev, RTLLIB_PS_MBCAST | RTLLIB_PS_UNICAST); } else psc->LpsIdleCount++; } @@ -235,10 +231,7 @@ void rtl92e_leisure_ps_leave(struct net_device *dev) &priv->rtllib->pwr_save_ctrl; =20 if (psc->bLeisurePs) { - if (priv->rtllib->ps !=3D RTLLIB_PS_DISABLED) { + if (priv->rtllib->ps !=3D RTLLIB_PS_DISABLED) _rtl92e_ps_set_mode(dev, RTLLIB_PS_DISABLED); - if (priv->rtllib->SetFwCmdHandler) - priv->rtllib->SetFwCmdHandler(dev, FW_CMD_LPS_LEAVE); - } } } diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index cc1ce106678c..6c1f56324bd6 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -1714,8 +1714,6 @@ struct rtllib_device { bool (*GetHalfNmodeSupportByAPsHandler)(struct net_device *dev); u8 (*rtllib_ap_sec_type)(struct rtllib_device *ieee); void (*InitialGainHandler)(struct net_device *dev, u8 Operation); - bool (*SetFwCmdHandler)(struct net_device *dev, - enum fw_cmd_io_type FwCmdIO); void (*UpdateBeaconInterruptHandler)(struct net_device *dev, bool start); void (*ScanOperationBackupHandler)(struct net_device *dev, --=20 2.40.1