From nobody Fri Dec 19 11:12:01 2025 Received: from mout.web.de (mout.web.de [212.227.17.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E20F41CA80; Tue, 19 Dec 2023 15:33:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=web.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b="rReFhxAz" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1702999969; x=1703604769; i=markus.elfring@web.de; bh=tn6Ij30L4nzJk1aQGY/PqCDgEqVZBUaPZ1LpxACXJwM=; h=X-UI-Sender-Class:Date:Subject:From:To:Cc:References: In-Reply-To; b=rReFhxAzgTkMWDA0DJzIQ8OD+hMHBfwo7o9LSN3BWD16842g6PnD6VDyASqxtAOX kzxI+w0WfT+kRlp6JgVmzizSUH2rPDEt/xg8/5f+6Sv0yUI2WJa+gHjnhafE5T4f9 jkWttkRDCxS4qw6nuYjonHnrYuyfAn7TUPaSvWJgDWRd/UvjZutQv0hV4DEp6O1Am wkAD8NrJx9w4b3NUp7AvH6/Bder6I7rcHPHhgu64zurZgACNf9Gu2SCSJh8mCghEi l56fXmmGw5X6AVz8gJzX1QpQHxdOjPx8mCTwyBnG9xFE3SI15i0GbzUC6XtHj4vk8 HZo20+PBIlJ4Vmr2Yg== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.85.95]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MKMA1-1rarCZ3qhj-00LtdG; Tue, 19 Dec 2023 16:32:48 +0100 Message-ID: <6d7d0b33-6c9e-4941-af5f-678137d2a00e@web.de> Date: Tue, 19 Dec 2023 16:32:48 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 1/3] kobject: Add a jump label in kobject_uevent_env() Content-Language: en-GB From: Markus Elfring To: kernel-janitors@vger.kernel.org, Andrew Morton , Greg Kroah-Hartman , "Rafael J. Wysocki" Cc: LKML , cocci@inria.fr References: In-Reply-To: Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:RZRPQpP5gRDbecmiyr/GE+SRHU+DXgMz5lHrrQB7DWJnkoOjyg2 K30sKLY3bstzCh5sNb9u0n4vzpJnhUf3kom/Wvx0HiUSDBLP/DO7VaZYeafo671XrPyWciw vnfG7mDdhrRdfw+WkhapcjKAdsrG1QCGE4hUp94NKfmfRkMTqGhQPG18A2MvI8yCeMzRjRI u6JZvVNqlOSj0q7C62FXQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:hcQw/9bQR1o=;HL5Pf2hLEmDWinV+zatF7bP3R1l +kQw8rd9Ep4QCKYhup2nx2GEs6mb4obohDmH05Ff7ymBibhqU75K/r1lDdPKwVTaap+GgE7fa ahM3XHFEN19jDllEy0YPbts01U571bzGRy+KUVH0/j07X8YPmKXATQdx0xkNsFgFu/oSajBZ9 bUBBxJzIlwt28c+qKdhBZFyiuggTu136gxqiFxutDLJu0OXwJ4vp0p+CBgVMQ+cTXHY2QfD1K hOsxTGIV7vP6C+hzdjzCEZWcVV1dM2jUcxjFWnY/hChFlQkAFOYH4aQo42zt9IQU7ODWHAzo3 C9wrGnoskFEHPlPNM/n6Z0jtPxze2pyFEdFHajNvKCZqaaYUL7I7wKaSzpBsrbaNBapRVXv4D 0XMBurnDW1b/QHYH3rxtnIDnBaozZIoCcjGTeiEn9Eh22DL4h0M6sVJGVeL+oDIAAGKxv8bz/ KAzNT0Ff0LTZkFyt1JM82B7JotEeNNxZMLVVn5PwVWAbv9qwRecwYDRbDYMdsWERe3OOYlYTF 2Hy8CKPTtG2U4bbxPM2d0Fa5pl7FjmjjYg62ss7mIriXM6t+Y+ABM0Qjaxm/4VQowKJnTvXSF anDFUWazBxqP28/kFUWDl0de3tr9FJ5//nd3f0jcEu6S5Qd0XjHXgCZLb2j0U6JjNl0oNtbZa ZCrrlWFpJ/VwPQrdk9qYKP/RBD/+hWF9UDOYo7xVbNsi3ksjyyyegMUr0oJJlH8msgy9gCkC6 fbkJl+z7MQh6aVk+Cp+7KTIPH44BlvoZVWHkzVgbyyIBY1ioaZfly2BsuZwIuwu377GOT7fvN YSxxZRsj/hCoCfUT1jYoPFhPOWtYcXWTmnxSR1yPdorA3rWvWROnMyhJTWp8hbYSJOfVWGrff zMsIlecFJw0T1ATQMzmvVwcMBUmWSuxicVTLpK1Faj3W9jWpAnUrqL98Pu5d78Jj4eSBklaGU N3qjuQ== Content-Type: text/plain; charset="utf-8" From: Markus Elfring Date: Tue, 19 Dec 2023 14:16:35 +0100 Use another label so that a call of the function =E2=80=9Ckfree=E2=80=9D ca= n be avoided after a failed call of the function =E2=80=9Ckobject_get_path=E2=80=9D. Signed-off-by: Markus Elfring --- lib/kobject_uevent.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/kobject_uevent.c b/lib/kobject_uevent.c index fb9a2f06dd1e..811e579ed89d 100644 --- a/lib/kobject_uevent.c +++ b/lib/kobject_uevent.c @@ -529,7 +529,7 @@ int kobject_uevent_env(struct kobject *kobj, enum kobje= ct_action action, devpath =3D kobject_get_path(kobj, GFP_KERNEL); if (!devpath) { retval =3D -ENOENT; - goto exit; + goto free_env; } /* default keys */ @@ -623,6 +623,7 @@ int kobject_uevent_env(struct kobject *kobj, enum kobje= ct_action action, exit: kfree(devpath); +free_env: kfree(env); return retval; } -- 2.43.0 From nobody Fri Dec 19 11:12:01 2025 Received: from mout.web.de (mout.web.de [212.227.17.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81BCA1CF86; Tue, 19 Dec 2023 15:39:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=web.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b="tUIQQvd8" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1703000386; x=1703605186; i=markus.elfring@web.de; bh=ELfN4U9np08GBF/FMF+QrtAqU4uT40C8danVIjILAro=; h=X-UI-Sender-Class:Date:Subject:From:To:Cc:References: In-Reply-To; b=tUIQQvd8/gN+Npy+DiBKsakAWrd/g9z2P2I3/Do70Nqc9Zqrb5EAsprwgC+YTj8L yeF7DuWERqZONc1QEpa3sidChmPXfG4k1p56ZMNFYWv4TC3G0EWBGFhuv0SlWm/lP k39Auh35V7DtpuEqSHJ77WV1ICHyWfbNcQM6KCTR4TQPhS0d9Rh8NAZ9LYohuSV34 8xQt0IcEZ6j4NeDBqcCRD+vf6mZ5tOeSfFf6nmswr+Vk4Xlhc1SUzUC2ZHAlVYpSw DsiR8351y77U3oq/jQvkDk2RG2aXm5/KGMZ8/C28pVmHgE1a1BcsOQULKcywhwi0r IXybnJnMGvRZ4ddqFQ== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.85.95]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MVJRl-1rhPgq3VKh-00STCY; Tue, 19 Dec 2023 16:34:19 +0100 Message-ID: Date: Tue, 19 Dec 2023 16:34:19 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 2/3] kobject: Improve a size determination in kobject_uevent_env() Content-Language: en-GB From: Markus Elfring To: kernel-janitors@vger.kernel.org, Andrew Morton , Greg Kroah-Hartman , "Rafael J. Wysocki" Cc: LKML , cocci@inria.fr References: In-Reply-To: Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:JjhsMO2bB8+nD7c7+p6s/ulFW7kzBQgTwWHDT3htCK5RkSp7UH0 eKIPW1jgIOUi/ZkvNRDAy2Y5QJJ5sHTpvk30jaJetwdy2oPIFsCUuCCazWWDM7L0RJB82wd ZFGktXCo2j8qBNnYrNIuTQ+ybpRoMe+wPDyPIGK55TDnSWv/uQ/IlA535TKPY6cQaii67t5 KroN6Q4bfgxT8T2Cmh5kQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:Gpmpv0Pfr5E=;xA1CMRucwhDJNYTvQs05e7/IJfQ o2QMZhuB7JHfeuEFaxjV8OhGeLjNFLUn+XydDjrJA+rHQZEayEYtA7TqB5z3J6uP+0sJPXi9F cTZlJxgu66eO/Zo8PPhnV9PWXkVvT2M3BrN0JPI6Kp7Eu7HkBH9Qhou17AFEym5aWAkyyq2nY s6DkXRwzMijEzmzwA3H8SWTWqO0EeevvVjgljPpXO1arQlnZHneP3EViQ/5n/SCg6nycfbtuR rqyqjDgUcG1cWB45APN0C57+IGFvxXZgWUL+Fn1EDoihXLQRCGKi5okMG45vKcpAV7O6OY+KP OxMZTnxaue9hh8lp12t4pHnhEnvB256gKv64TfP7d1rTpPolTQuB7lXvmV5k96151ra4DjJDi 1tqlGJizHKlzw+liGVjSt/u7TBojtvmwNKbbzJ06JdhyWPMBPR+0YDysoqH703TAbW2+sppQk nSLM+lkl0gc+Ru+OnioNkiRDCIkVQq68WRYfVjPau76BGHMr+L/2cSybspiodHM5xSJ2WxmWf PxajztBRZqc6Cefk80hdM44QES+P529kI1gJkSH2C8QRhjNI1Vx/SKqMAhnU2AEbANaWTVvv2 Eey1xqkHnqcTH7uTiItvODtjeZ+CZwDjMU/fXlwjSiAsyZcKYZ21xwGf84blhw1f9WGihQv+j qMT1OMaLzGG7CTtbsjlyOWwdZkY36WpNuqfZBAkIpJcln5rxCHF6Xgv72qBtmeoZ5r77bsVPL 1VAgAZV/otKnFCR65yhhBKt8QlZ5uT2y7irIOJTM5ApcoOXaPN/on/wob79UmRj24u8CADRpz vN6c3s1korAktUYy/1AGryFFwz939tZq7rxRPawSK7lNM+CjVH+UYJX2WPWgJXltwdPbOmBj1 PnAX+8A8aYzh4GFFYhoPeLpgxYA3Xms6gz4pIzu2+HWEeMafG9CEXBM9qOWjsqUjUOlkuyGy/ yA5ksQ== Content-Type: text/plain; charset="utf-8" From: Markus Elfring Date: Tue, 19 Dec 2023 16:00:22 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- lib/kobject_uevent.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/kobject_uevent.c b/lib/kobject_uevent.c index 811e579ed89d..a9b1bc02f65c 100644 --- a/lib/kobject_uevent.c +++ b/lib/kobject_uevent.c @@ -521,7 +521,7 @@ int kobject_uevent_env(struct kobject *kobj, enum kobje= ct_action action, } /* environment buffer */ - env =3D kzalloc(sizeof(struct kobj_uevent_env), GFP_KERNEL); + env =3D kzalloc(sizeof(*env), GFP_KERNEL); if (!env) return -ENOMEM; -- 2.43.0 From nobody Fri Dec 19 11:12:01 2025 Received: from mout.web.de (mout.web.de [212.227.17.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C48C1CA82; Tue, 19 Dec 2023 15:36:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=web.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b="NdSHAllz" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1703000172; x=1703604972; i=markus.elfring@web.de; bh=behxKfyGna2w4fIuLyZUlD9UgVji5Pzaqh7fdVWijjk=; h=X-UI-Sender-Class:Date:Subject:From:To:Cc:References: In-Reply-To; b=NdSHAllz2ytmZIT0QQCD69MNm4qSxBOrxg96wlionm7kXZr/joZYDH7INPo3N3+g KoXYVYaKuknbstv0fU3v+mfBgQIbyEDDW8swCkjMzoWeb48bJ7eAcDyYH8hujKMD/ 4KHfJM37clRxBi0tVFEGCOe0B4R6aGOLKMVddak03dqlFH8yRJVZ2s6Yf6iI3Ragn iff1isB3nGfvsMf8+j8e4xnPaaZC8Haeb0L84L/w6b6UJ9kRE8eSMoXacv/qcPlrK ZUXxrZf3JaCyIpFJOrE3w5ux5K6GVOvFceRD53KmS4agGP/BMz+ZFWiWwLbAvS7hj Zuwpyown8cwj76WQlw== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.85.95]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MGxQX-1rT2XA40kl-00EGMH; Tue, 19 Dec 2023 16:36:12 +0100 Message-ID: <526df884-8d9f-4fe1-8a32-c98dfff261d7@web.de> Date: Tue, 19 Dec 2023 16:36:11 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 3/3] kobject: Delete an unnecessary variable initialisation in kobject_uevent_env() Content-Language: en-GB From: Markus Elfring To: kernel-janitors@vger.kernel.org, Andrew Morton , Greg Kroah-Hartman , "Rafael J. Wysocki" Cc: LKML , cocci@inria.fr References: In-Reply-To: Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:Ty9JQzMTJdBwRgq27eu4X1MYwBgEoqbzGhLFiC0uyypy8ISyY/3 04ttYsnYF4svdZvfzX2e0Q5LP9xnbZXCwWwLPotK0G3FSPKrDvSggC3MSn7WHsRqklFB8u8 Y/zvYhANVJwd/l7F38NBblZ6qZZHqwg+tm+flOv8n6ggTQHf/+98Jhh3Uyg15wdIWKJAzUW rYw7t/s52WNc20JKw5meg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:bn4Ds0KTrg4=;i9ZeJm85eydOOEPORA+V0LPdHbM 5dd4Z4bvbJMQeTztCMzJ5ZOE074edtSA8hze0krNwEGRBPzr+n7FGg/Tsth9nxgoKU8MsGE14 J5nDsA2n3dfOiqBE1I7KRw2+fwFlw/xcL9gIW/k++bHjNgZyOFA0RdXirtX997AEnkhAjFeYd SXwLcOEPBp6sNLWCpSQCIlFluLBFxOizeDNFCfFeWIKtZwtr4b6WjeQZHnusPsfMDN4J93C1T hPznwNJMqkBuXELcjpDLAnvWgd7tnnw3KMRKrkRxwKrjszWHVSokaUSiHqQJjCVUvgQcSOjmi bAjZV81AHAvg00HRxZQ3GsyV1FUd6xJVvaT947/UhMeW9lTEC+n2pi+0Fg1XCoesBWupmbv+c ufUM+YcVv/BaV33Vqd/4pHBwgIDzy+Sf6Vc7yap6TxhB6Lt1Pi28U1NSXDpyLtO+wWCfh5uko is+/2jLi3fD+V22WB7Cy+Dg1UARlflZSBrHjKBjJjmCTstjPKg2TcgH7Y+jtCNj1l4B6s/GKA LpJTVQC0ArOQjl1knDByBuFa6x1/Tw1ui5/gYQfPQXqCvIhYtbL34gHF8Bih8NasXSm3oRtph k23pSlBWO8lte3tTJsUXc0VM+EjjWeQf8BxSxuHqf+UDxEanFGJyHWOcVvExZv+yF450YHJL7 B3b/BhVmj/UTqzC2S02Wh5zciuL96MDNyfgldgzZODcKKWugIZyBXjL3b3XIY9QvuXLh2zmWy 2mHBlMLN9oXP33u0GK62z1SvHEpKOeI9naEUVZ2WDoQD0NS9VzCxEhAZKtrwQiz6sSqZl4Yhy g5hFxtKusafBRxL9/Vn50YH0AEhWBRHTpcCtzLzXHqly5+4Gx7XAu/A8vNpfsJeRBgqShlNm4 r354EUyMvxkjZik6xZzKjBTJea6EEtimOVJYI3rNuCAiS3wIGYp7BA3ZSZObWDhOfHfd14MLI +aTfAw== Content-Type: text/plain; charset="utf-8" From: Markus Elfring Date: Tue, 19 Dec 2023 16:03:39 +0100 The local variable =E2=80=9Cdevpath=E2=80=9D will eventually be set to an a= ppropriate pointer a bit later. Thus omit the explicit initialisation at the beginning. Signed-off-by: Markus Elfring --- lib/kobject_uevent.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/kobject_uevent.c b/lib/kobject_uevent.c index a9b1bc02f65c..1b7b42dc160c 100644 --- a/lib/kobject_uevent.c +++ b/lib/kobject_uevent.c @@ -459,7 +459,7 @@ int kobject_uevent_env(struct kobject *kobj, enum kobje= ct_action action, { struct kobj_uevent_env *env; const char *action_string =3D kobject_actions[action]; - const char *devpath =3D NULL; + const char *devpath; const char *subsystem; struct kobject *top_kobj; struct kset *kset; -- 2.43.0